'Re: Review Request 109691: turn "ignore geometry" forcerule into a setrule'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 109691: turn "ignore geometry" forcerule into a setrule
From:       "Commit Hook" <null () kde ! org>
Date:       2013-03-28 19:32:30
Message-ID: 20130328193230.24153.27711 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109691/
-----------------------------------------------------------

(Updated March 28, 2013, 7:32 p.m.)

Status
------

This change has been marked as submitted.

Review request for kwin and Martin Gräßlin.

Description
-------

this will allow to use "apply initially" as "force" used to act (ignore position on \
placement) and "force" to prevent clients from reconfiguring themselves (to not break \
a tabgroup or to just not be annoying)

As this will require a (pending) kconfupdate anyway, i took the opportunity to get \
rid of the legacy ignoreposition rule and completely replace it by the ignoregeometry \
rule (which was so far a wrapper)

As for the kconfupdate: gonna promote the kconfig tool next =)

This addresses bugs 252314 and 311720.
    http://bugs.kde.org/show_bug.cgi?id=252314
    http://bugs.kde.org/show_bug.cgi?id=311720

Diffs
-----

  kwin/geometry.cpp 56255db 
  kwin/kcmkwin/kwinrules/ruleswidget.h 585c4fe 
  kwin/kcmkwin/kwinrules/ruleswidget.cpp 4a3159e 
  kwin/kcmkwin/kwinrules/ruleswidgetbase.ui 60c781e 
  kwin/manage.cpp c1af7dd 
  kwin/rules.h 2299dd8 
  kwin/rules.cpp 8a1edc8 

Diff: http://git.reviewboard.kde.org/r/109691/diff/

Testing
-------

yupp, imagemagick "display" does no more align to the image size with the rule in \
place ("surprise")

Thanks,

Thomas Lübking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109691/">http://git.reviewboard.kde.org/r/109691/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated March 28, 2013, 7:32 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">this will allow to use &quot;apply initially&quot; as &quot;force&quot; \
used to act (ignore position on placement) and &quot;force&quot; to prevent clients \
from reconfiguring themselves (to not break a tabgroup or to just not be annoying)

As this will require a (pending) kconfupdate anyway, i took the opportunity to get \
rid of the legacy ignoreposition rule and completely replace it by the ignoregeometry \
rule (which was so far a wrapper)

As for the kconfupdate: gonna promote the kconfig tool next =)
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yupp, imagemagick &quot;display&quot; does no more align to the image \
size with the rule in place (&quot;surprise&quot;)</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=252314">252314</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=311720">311720</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/geometry.cpp <span style="color: grey">(56255db)</span></li>

 <li>kwin/kcmkwin/kwinrules/ruleswidget.h <span style="color: \
grey">(585c4fe)</span></li>

 <li>kwin/kcmkwin/kwinrules/ruleswidget.cpp <span style="color: \
grey">(4a3159e)</span></li>

 <li>kwin/kcmkwin/kwinrules/ruleswidgetbase.ui <span style="color: \
grey">(60c781e)</span></li>

 <li>kwin/manage.cpp <span style="color: grey">(c1af7dd)</span></li>

 <li>kwin/rules.h <span style="color: grey">(2299dd8)</span></li>

 <li>kwin/rules.cpp <span style="color: grey">(8a1edc8)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109691/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 