From kwin Thu Mar 28 19:32:30 2013 From: "Commit Hook" Date: Thu, 28 Mar 2013 19:32:30 +0000 To: kwin Subject: Re: Review Request 109678: block screenswitch if active screen follows mouse and inform the user abo Message-Id: <20130328193230.24317.93125 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=136449917012817 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5566708253318863358==" --===============5566708253318863358== Content-Type: multipart/alternative; boundary="===============3049117494684339584==" --===============3049117494684339584== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109678/ ----------------------------------------------------------- (Updated March 28, 2013, 7:32 p.m.) Status ------ This change has been marked as submitted. Review request for kwin and Martin Gräßlin. Description ------- summarized, see bug. about "how": - spamming a popup is imo no option at all - we try to avoid his otherwise and this is seriously not important enough to be considered an exception - we cannot invoke the notification interface directly, it could be absent (razorQt situation) - we cannot use KMessageBox etc. for similar reasons, if we end up with a real dialog, we're screwed -> do what's always done and invoke kdialog as helper This addresses bug 183410. http://bugs.kde.org/show_bug.cgi?id=183410 Diffs ----- kwin/useractions.cpp 9f21ce1 Diff: http://git.reviewboard.kde.org/r/109678/diff/ Testing ------- yupp, got notification Thanks, Thomas Lübking --===============3049117494684339584== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109678/

This change has been marked as submitted.

Review request for kwin and Martin Gräßlin.

By Thomas Lübking.

Updated March 28, 2013, 7:32 p.m.

Description

summarized, see bug.

about "how":
- spamming a popup is imo no option at all - we try to avoid his otherwise and this is seriously not important enough to be considered an exception
- we cannot invoke the notification interface directly, it could be absent (razorQt situation)
- we cannot use KMessageBox etc. for similar reasons, if we end up with a real dialog, we're screwed

-> do what's always done and invoke kdialog as helper

Testing

yupp, got notification

Bugs: 183410

Diffs

kwin/useractions.cpp (9f21ce1)

View Diff

--===============3049117494684339584==-- --===============5566708253318863358== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============5566708253318863358==--