'Re: Review Request 109762: remove glIsVSync'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 109762: remove glIsVSync
From:       "Ralf Jung" <post+kde () ralfj ! de>
Date:       2013-03-28 18:51:49
Message-ID: 20130328185149.18346.28394 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109762/#review30027
-----------------------------------------------------------

Submitted with commit f3245bd870ffdc4c675892ff5758609ecfb9b12b to branch master.
(And I used the wrong number in the commit)

- Ralf Jung

On March 28, 2013, 7:51 p.m., Ralf Jung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109762/
> -----------------------------------------------------------
> 
> (Updated March 28, 2013, 7:51 p.m.)
> 
> 
> Review request for kwin, Martin Gräßlin and Thomas Lübking.
> 
> 
> Description
> -------
> 
> This patch removes the GlVSync option, which is necessary since there is no UI \
> anymore for this option. It is (the uncontroversial) half of \
> https://git.reviewboard.kde.org/r/109086/ plus changing the GLX backend to actually \
> disable v-sync if the user said so. 
> 
> Diffs
> -----
> 
> kwin/glxbackend.cpp b749e9c 
> kwin/kwin.kcfg 3d254fb 
> kwin/options.h e816d4a 
> kwin/options.cpp 46a9396 
> 
> Diff: http://git.reviewboard.kde.org/r/109762/diff/
> 
> 
> Testing
> -------
> 
> It still compiles. V-sync is properly disabled if set so by the user.
> 
> 
> Thanks,
> 
> Ralf Jung
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109762/">http://git.reviewboard.kde.org/r/109762/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit \
f3245bd870ffdc4c675892ff5758609ecfb9b12b to branch master. (And I used the wrong \
number in the commit)</pre>  <br />

<p>- Ralf</p>

<br />
<p>On March 28th, 2013, 7:51 p.m. CET, Ralf Jung wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Martin Gräßlin and Thomas Lübking.</div>
<div>By Ralf Jung.</div>

<p style="color: grey;"><i>Updated March 28, 2013, 7:51 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch removes the GlVSync option, which is necessary since there is \
no UI anymore for this option. It is (the uncontroversial) half of \
https://git.reviewboard.kde.org/r/109086/ plus changing the GLX backend to actually \
disable v-sync if the user said so.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It still compiles. V-sync is properly disabled if set so by the \
user.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/glxbackend.cpp <span style="color: grey">(b749e9c)</span></li>

 <li>kwin/kwin.kcfg <span style="color: grey">(3d254fb)</span></li>

 <li>kwin/options.h <span style="color: grey">(e816d4a)</span></li>

 <li>kwin/options.cpp <span style="color: grey">(46a9396)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109762/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 