From kwin Thu Mar 28 18:08:31 2013 From: "Commit Hook" Date: Thu, 28 Mar 2013 18:08:31 +0000 To: kwin Subject: Re: Review Request 109086: remove glIsVSync and pointless waitsync Message-Id: <20130328180831.10772.74067 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=136449413411028 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1842716637286853161==" --===============1842716637286853161== Content-Type: multipart/alternative; boundary="===============9173550613036409517==" --===============9173550613036409517== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109086/ ----------------------------------------------------------- (Updated March 28, 2013, 6:08 p.m.) Status ------ This change has been marked as submitted. Review request for kwin, Martin Gräßlin and Ralf Jung. Description ------- follow-up to https://git.reviewboard.kde.org/r/107198/ We need more detailed info about vsync (notably whether it blocks and is present beyond the setting) WaitSync was an implementation detail of a backend only. Diffs ----- kwin/options.h b6de1d5 kwin/options.cpp 893b1fa kwin/scene.h f06d150 kwin/scene.cpp 685254b kwin/scene_opengl.h 7971c83 kwin/scene_opengl.cpp 3185c9e kwin/composite.cpp e6cb0d4 kwin/glxbackend.h ce46bac kwin/glxbackend.cpp be11497 Diff: http://git.reviewboard.kde.org/r/109086/diff/ Testing ------- running. Thanks, Thomas Lübking --===============9173550613036409517== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109086/

This change has been marked as submitted.

Review request for kwin, Martin Gräßlin and Ralf Jung.
By Thomas Lübking.

Updated March 28, 2013, 6:08 p.m.

Description 

follow-up to https://git.reviewboard.kde.org/r/107198/
We need more detailed info about vsync (notably whether it blocks and is present beyond the setting)
WaitSync was an implementation detail of a backend only.

Testing 

running.

Diffs

  • kwin/options.h (b6de1d5)
  • kwin/options.cpp (893b1fa)
  • kwin/scene.h (f06d150)
  • kwin/scene.cpp (685254b)
  • kwin/scene_opengl.h (7971c83)
  • kwin/scene_opengl.cpp (3185c9e)
  • kwin/composite.cpp (e6cb0d4)
  • kwin/glxbackend.h (ce46bac)
  • kwin/glxbackend.cpp (be11497)

View Diff
--===============9173550613036409517==-- --===============1842716637286853161== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============1842716637286853161==--