[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 109762: remove glIsVSync
From: "Ralf Jung" <post+kde () ralfj ! de>
Date: 2013-03-27 21:35:55
Message-ID: 20130327213555.16341.30654 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 27, 2013, 7:28 p.m., Thomas Lübking wrote:
> > The other review patch /does/ set the swapInterval to 0 on \
> > !options->glPreferBufferSwap()
> > That aside, i won't get around disassembling the patch anyway, so "ship it!" from \
> > my side.
> > Next step should be to remove all waitSync calls but the one for (remote..) swap \
> > && !interval and move startRenderTimer(); out of it and present() to \
> > prepareRenderingFrame() - so we can easily check for some "blocksForRetrace()" to \
> > manage present() in prepare/endRenderingFrame()
> The other review patch /does/ set the swapInterval to 0 on \
> !options->glPreferBufferSwap()
Indeed it does, sorry I missed that.
> On March 27, 2013, 7:28 p.m., Thomas Lübking wrote:
> > kwin/glxbackend.cpp, line 99
> > <http://git.reviewboard.kde.org/r/109762/diff/1/?file=124552#file124552line99>
> >
> > you can test this as bool (so no need for the shortening helper variable)
I used the "!=" syntax since it does not require the knowledge that \
Options::NoSwapEncourage == 0. Not that it should make any difference for the \
compiler ;-) so I can change it to whatever matches kwin programming style best. The \
EGL backend currently uses "!=" as well, but there the variable also has the purpose \
to avoid calling glPreferBufferSwap() twice.
- Ralf
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109762/#review29962
-----------------------------------------------------------
On March 27, 2013, 11:43 a.m., Ralf Jung wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109762/
> -----------------------------------------------------------
>
> (Updated March 27, 2013, 11:43 a.m.)
>
>
> Review request for kwin, Martin Gräßlin and Thomas Lübking.
>
>
> Description
> -------
>
> This patch removes the GlVSync option, which is necessary since there is no UI \
> anymore for this option. It is (the uncontroversial) half of \
> https://git.reviewboard.kde.org/r/109086/ plus changing the GLX backend to actually \
> disable v-sync if the user said so.
>
> Diffs
> -----
>
> kwin/glxbackend.cpp b749e9c
> kwin/kwin.kcfg 3d254fb
> kwin/options.h e816d4a
> kwin/options.cpp 46a9396
>
> Diff: http://git.reviewboard.kde.org/r/109762/diff/
>
>
> Testing
> -------
>
> It still compiles. V-sync is properly disabled if set so by the user.
>
>
> Thanks,
>
> Ralf Jung
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109762/">http://git.reviewboard.kde.org/r/109762/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 27th, 2013, 7:28 p.m. CET, <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The other review patch /does/ set the swapInterval to 0 on \
!options->glPreferBufferSwap()
That aside, i won't get around disassembling the patch anyway, so "ship \
it!" from my side.
Next step should be to remove all waitSync calls but the one for (remote..) swap \
&& !interval and move startRenderTimer(); out of it and present() to \
prepareRenderingFrame() - so we can easily check for some \
"blocksForRetrace()" to manage present() in \
prepare/endRenderingFrame()</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> The other review \
patch /does/ set the swapInterval to 0 on !options->glPreferBufferSwap() Indeed it \
does, sorry I missed that.</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 27th, 2013, 7:28 p.m. CET, <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109762/diff/1/?file=124552#file124552line99" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/glxbackend.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
GlxBackend::init()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">99</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> \
<span class="p">(</span><span class="n">options</span><span \
class="o">-></span><span class="n">isGlVSync</span><span class="p">())</span> \
<span class="p">{</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">99</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span \
class="kt">bool</span> <span class="n">wantSync</span> <span class="o">=</span> <span \
class="n">options</span><span class="o">-></span><span \
class="n">glPreferBufferSwap</span><span class="p">()</span> <span \
class="o">!=</span> <span class="n">Options</span><span class="o">::</span><span \
class="n">NoSwapEncourage</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">you can test this as \
bool (so no need for the shortening helper variable)</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I used the \
"!=" syntax since it does not require the knowledge that \
Options::NoSwapEncourage == 0. Not that it should make any difference for the \
compiler ;-) so I can change it to whatever matches kwin programming style best. The \
EGL backend currently uses "!=" as well, but there the variable also has \
the purpose to avoid calling glPreferBufferSwap() twice.</pre> <br />
<p>- Ralf</p>
<br />
<p>On March 27th, 2013, 11:43 a.m. CET, Ralf Jung wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Martin Gräßlin and Thomas Lübking.</div>
<div>By Ralf Jung.</div>
<p style="color: grey;"><i>Updated March 27, 2013, 11:43 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch removes the GlVSync option, which is necessary since there is \
no UI anymore for this option. It is (the uncontroversial) half of \
https://git.reviewboard.kde.org/r/109086/ plus changing the GLX backend to actually \
disable v-sync if the user said so.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It still compiles. V-sync is properly disabled if set so by the \
user.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/glxbackend.cpp <span style="color: grey">(b749e9c)</span></li>
<li>kwin/kwin.kcfg <span style="color: grey">(3d254fb)</span></li>
<li>kwin/options.h <span style="color: grey">(e816d4a)</span></li>
<li>kwin/options.cpp <span style="color: grey">(46a9396)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109762/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic