'Re: Review Request 109706: Adding an activitiesChanged signal to Toplevel'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 109706: Adding an activitiesChanged signal to Toplevel
From:       Thomas_Lübking <thomas.luebking () gmail ! com>
Date:       2013-03-26 17:42:26
Message-ID: 20130326174226.8782.82398 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109706/#review29903
-----------------------------------------------------------

Ship it!

Ship It!

- Thomas Lübking

On March 26, 2013, 7:56 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109706/
> -----------------------------------------------------------
> 
> (Updated March 26, 2013, 7:56 a.m.)
> 
> 
> Review request for kwin.
> 
> 
> Description
> -------
> 
> Adding an activitiesChanged signal to Toplevel
> 
> Only emitted from Client.
> 
> Targetting for 4.10 as this has been requested and can be considered a bugfix.
> 
> 
> This addresses bug 317366.
>     http://bugs.kde.org/show_bug.cgi?id=317366
> 
> 
> Diffs
> -----
> 
>   kwin/client.cpp a694cdd 
>   kwin/toplevel.h 3714908 
> 
> Diff: http://git.reviewboard.kde.org/r/109706/diff/
> 
> 
> Testing
> -------
> 
> compiled on master, will be tested on the model work
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109706/">http://git.reviewboard.kde.org/r/109706/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Thomas</p>

<br />
<p>On March 26th, 2013, 7:56 a.m. UTC, Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated March 26, 2013, 7:56 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adding an activitiesChanged signal to Toplevel

Only emitted from Client.

Targetting for 4.10 as this has been requested and can be considered a bugfix.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiled on master, will be tested on the model work</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=317366">317366</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/client.cpp <span style="color: grey">(a694cdd)</span></li>

 <li>kwin/toplevel.h <span style="color: grey">(3714908)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109706/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 