[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 109086: remove glIsVSync and pointless waitsync
From: "Ralf Jung" <post+kde () ralfj ! de>
Date: 2013-03-22 13:05:09
Message-ID: 20130322130509.27117.63269 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 22, 2013, 1:16 p.m., Martin Gräßlin wrote:
> > Is this one still needed or did it get obsoleted by another review?
This patch can be conceptually separated in two parts:
- Remove glISVSync: I am not sure whether Thomas merged that into his patch to change \
the UI (it's not in the review), but in any case it's a fairly trivial patch and a \
necessary one as glISVSync is removed from the UI (IMHO there's no further review \
needed here)
- Removing some waitsync, detecting whether glXSwapBuffers blocks, changing the \
timing logic and the 1-frame latency: This is unrelated to the other review, and \
still open for discussion. I still think that, seeing how common triple-buffering is, \
it should at least be possible to optionally use a timing logic suited for this kind \
of buffering, and get rid of the frame draw delay. I imagine some kind of option to \
toggle between KWin assuming double-buffering (-> blocking swap, timer logic drops \
frames, 1-frame latency) and triple-buffering (-> only-sometimes-blocking swap, \
simple timer logic which just does throttling, no draw latency). The default could be \
double-buffering (even though I assume most users are on triple-buffering) as that's \
the current behaviour. In the long term, we should consider what the impact is of \
using the double-buffering assumptions on a triple-buffering system and vice versa, \
and how common which setup is. Auto-detecting triple-buffering as not tiri vial (and \
doing it reliable will most certainly take a noticeable time), so IMHO it cannot be \
done on each startup. However, doing it only on first launch could be possible.
- Ralf
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109086/#review29704
-----------------------------------------------------------
On Feb. 24, 2013, 11:28 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109086/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2013, 11:28 p.m.)
>
>
> Review request for kwin, Martin Gräßlin and Ralf Jung.
>
>
> Description
> -------
>
> follow-up to https://git.reviewboard.kde.org/r/107198/
> We need more detailed info about vsync (notably whether it blocks and is present \
> beyond the setting) WaitSync was an implementation detail of a backend only.
>
>
> Diffs
> -----
>
> kwin/options.h b6de1d5
> kwin/options.cpp 893b1fa
> kwin/scene.h f06d150
> kwin/scene.cpp 685254b
> kwin/scene_opengl.h 7971c83
> kwin/scene_opengl.cpp 3185c9e
> kwin/composite.cpp e6cb0d4
> kwin/glxbackend.h ce46bac
> kwin/glxbackend.cpp be11497
>
> Diff: http://git.reviewboard.kde.org/r/109086/diff/
>
>
> Testing
> -------
>
> running.
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109086/">http://git.reviewboard.kde.org/r/109086/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 22nd, 2013, 1:16 p.m. CET, <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Is this one still needed or did it get obsoleted by another \
review?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch can be \
conceptually separated in two parts:
- Remove glISVSync: I am not sure whether Thomas merged that into his patch to change \
the UI (it's not in the review), but in any case it's a fairly trivial patch \
and a necessary one as glISVSync is removed from the UI (IMHO there's no further \
review needed here)
- Removing some waitsync, detecting whether glXSwapBuffers blocks, changing the \
timing logic and the 1-frame latency: This is unrelated to the other review, and \
still open for discussion. I still think that, seeing how common triple-buffering is, \
it should at least be possible to optionally use a timing logic suited for this kind \
of buffering, and get rid of the frame draw delay. I imagine some kind of option to \
toggle between KWin assuming double-buffering (-> blocking swap, timer logic drops \
frames, 1-frame latency) and triple-buffering (-> only-sometimes-blocking swap, \
simple timer logic which just does throttling, no draw latency). The default could be \
double-buffering (even though I assume most users are on triple-buffering) as \
that's the current behaviour. In the long term, we should consider what the \
impact is of using the double-buffering assumptions on a triple-buffering system and \
vice versa, and how common which setup is. Auto-detecting triple-buffering a s not \
tirivial (and doing it reliable will most certainly take a noticeable time), so IMHO \
it cannot be done on each startup. However, doing it only on first launch could be \
possible.</pre> <br />
<p>- Ralf</p>
<br />
<p>On February 24th, 2013, 11:28 p.m. CET, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Martin Gräßlin and Ralf Jung.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Feb. 24, 2013, 11:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">follow-up to https://git.reviewboard.kde.org/r/107198/ We need more \
detailed info about vsync (notably whether it blocks and is present beyond the \
setting) WaitSync was an implementation detail of a backend only.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">running.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/options.h <span style="color: grey">(b6de1d5)</span></li>
<li>kwin/options.cpp <span style="color: grey">(893b1fa)</span></li>
<li>kwin/scene.h <span style="color: grey">(f06d150)</span></li>
<li>kwin/scene.cpp <span style="color: grey">(685254b)</span></li>
<li>kwin/scene_opengl.h <span style="color: grey">(7971c83)</span></li>
<li>kwin/scene_opengl.cpp <span style="color: grey">(3185c9e)</span></li>
<li>kwin/composite.cpp <span style="color: grey">(e6cb0d4)</span></li>
<li>kwin/glxbackend.h <span style="color: grey">(ce46bac)</span></li>
<li>kwin/glxbackend.cpp <span style="color: grey">(be11497)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109086/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic