[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 109450: Remove doNotManage hack for Java Applets
From: "Commit Hook" <null () kde ! org>
Date: 2013-03-22 9:00:34
Message-ID: 20130322090034.27847.80918 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109450/
-----------------------------------------------------------
(Updated March 22, 2013, 9 a.m.)
Status
------
This change has been marked as submitted.
Review request for kwin.
Description
-------
Remove doNotManage hack for Java Applets
The hack used to be used to hide windows before they get embedded into
another window. This has been wrong on multiple levels:
1. it does not belong into a window manager - the window should take care
of this by itself
2. Window title is not a proper way to identify windows
3. Using D-Bus to inform an X11 window manager about windows which should
not get managed is rather strange
4. The hack only works with KWin, but not with any other X Window Manager
5. Windows identified with this hack still appear in Alt+Tab, that is
they are managed after all. Only a flicker is suppressed
6. Such windows are shown in the taskbar which nicely illustrates how
wrong a D-Bus call to the window manager is
That the hack has been introduced for Java Applets in KHTML also shows
that this is wrong. Why does Gecko and WebKit not need such a hack? Why
is KHTML tied so closely to X11 and KWin? Having a hack for a technology
which is obsoleted (Java Applets) and shouldn't be used due to security
issues is another reason to no longer support this hack.
The only other usage of doNotManage is by KStart to start any window
embedded in the systray. Which had been broken for quite some time and
has recently been removed.
Diffs
-----
kwin/dbusinterface.h a9030606a275dd3d47a961d62e2d191d3c5ee6d5
kwin/dbusinterface.cpp 7987e3f373faaad4046cf401a57a1bde84b32538
kwin/manage.cpp 509c7948fdb89c2390bcfc3b591612721c072e38
kwin/workspace.h b5411278c89a8c4ac1fd389edebed17bc1b46db1
kwin/workspace.cpp 46c103440891bdfb3101a918fe492c937a629764
Diff: http://git.reviewboard.kde.org/r/109450/diff/
Testing
-------
Thanks,
Martin Gräßlin
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109450/">http://git.reviewboard.kde.org/r/109450/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated March 22, 2013, 9 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Remove doNotManage hack for Java Applets
The hack used to be used to hide windows before they get embedded into
another window. This has been wrong on multiple levels:
1. it does not belong into a window manager - the window should take care
of this by itself
2. Window title is not a proper way to identify windows
3. Using D-Bus to inform an X11 window manager about windows which should
not get managed is rather strange
4. The hack only works with KWin, but not with any other X Window Manager
5. Windows identified with this hack still appear in Alt+Tab, that is
they are managed after all. Only a flicker is suppressed
6. Such windows are shown in the taskbar which nicely illustrates how
wrong a D-Bus call to the window manager is
That the hack has been introduced for Java Applets in KHTML also shows
that this is wrong. Why does Gecko and WebKit not need such a hack? Why
is KHTML tied so closely to X11 and KWin? Having a hack for a technology
which is obsoleted (Java Applets) and shouldn't be used due to security
issues is another reason to no longer support this hack.
The only other usage of doNotManage is by KStart to start any window
embedded in the systray. Which had been broken for quite some time and
has recently been removed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/dbusinterface.h <span style="color: \
grey">(a9030606a275dd3d47a961d62e2d191d3c5ee6d5)</span></li>
<li>kwin/dbusinterface.cpp <span style="color: \
grey">(7987e3f373faaad4046cf401a57a1bde84b32538)</span></li>
<li>kwin/manage.cpp <span style="color: \
grey">(509c7948fdb89c2390bcfc3b591612721c072e38)</span></li>
<li>kwin/workspace.h <span style="color: \
grey">(b5411278c89a8c4ac1fd389edebed17bc1b46db1)</span></li>
<li>kwin/workspace.cpp <span style="color: \
grey">(46c103440891bdfb3101a918fe492c937a629764)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109450/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic