'Review Request 109211: add AnimationEffect::set() and ::cancel()'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request 109211: add AnimationEffect::set() and ::cancel()
From:       Thomas_Lübking <thomas.luebking () gmail ! com>
Date:       2013-02-28 18:59:21
Message-ID: 20130228185921.28721.28306 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109211/
-----------------------------------------------------------

Review request for kwin and Martin Gräßlin.

Description
-------

This will allow to sue the AnimationEffect class for (temorarily) persistent changes \
like required by the translucency effect (which i already have, gonna post on the ML)

Diffs
-----

  kwin/libkwineffects/anidata.cpp f1a07d4 
  kwin/libkwineffects/anidata_p.h a0c450b 
  kwin/libkwineffects/kwinanimationeffect.h d7b6722 
  kwin/libkwineffects/kwinanimationeffect.cpp 9709be4 
  kwin/libkwineffects/kwineffects.h 464d7f2 

Diff: http://git.reviewboard.kde.org/r/109211/diff/

Testing
-------

yes, i've a translucency effect enabled (drives me crazy, but hey ;-)

Thanks,

Thomas Lübking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109211/">http://git.reviewboard.kde.org/r/109211/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This will allow to sue the AnimationEffect class for (temorarily) \
persistent changes like required by the translucency effect (which i already have, \
gonna post on the ML)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yes, i&#39;ve a translucency effect enabled (drives me crazy, but hey \
;-)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/libkwineffects/anidata.cpp <span style="color: grey">(f1a07d4)</span></li>

 <li>kwin/libkwineffects/anidata_p.h <span style="color: grey">(a0c450b)</span></li>

 <li>kwin/libkwineffects/kwinanimationeffect.h <span style="color: \
grey">(d7b6722)</span></li>

 <li>kwin/libkwineffects/kwinanimationeffect.cpp <span style="color: \
grey">(9709be4)</span></li>

 <li>kwin/libkwineffects/kwineffects.h <span style="color: \
grey">(464d7f2)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109211/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 