'Re: Review Request 109177: XCB port for kwinglobals.h'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 109177: XCB port for kwinglobals.h
From:       "Commit Hook" <null () kde ! org>
Date:       2013-02-27 10:48:15
Message-ID: 20130227104815.11547.13297 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109177/#review28199
-----------------------------------------------------------

This review has been submitted with commit d6b3f6983efebc42abd6028ece9c3ec7facea2d0 \
by Martin Gräßlin to branch master.

- Commit Hook

On Feb. 26, 2013, 7:16 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109177/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2013, 7:16 a.m.)
> 
> 
> Review request for kwin.
> 
> 
> Description
> -------
> 
> XCB port for kwinglobals.h
> 
> displayWidth/Height() are rewritten on top of XCB. rootWindow() and
> xTime() return xcb datatype instead of XLib datatype.
> 
> Unfortunatelly it's not possible to cache the result for displayWidth and
> Height, but getting the default screen is cached and provided in another
> method.
> 
> 
> Diffs
> -----
> 
> kwin/libkwineffects/kwinglobals.h dba432432fd3741309a1f5dbe5e564eae059b839 
> 
> Diff: http://git.reviewboard.kde.org/r/109177/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109177/">http://git.reviewboard.kde.org/r/109177/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit d6b3f6983efebc42abd6028ece9c3ec7facea2d0 by Martin Gräßlin to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On February 26th, 2013, 7:16 a.m. UTC, Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Feb. 26, 2013, 7:16 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">XCB port for kwinglobals.h

displayWidth/Height() are rewritten on top of XCB. rootWindow() and
xTime() return xcb datatype instead of XLib datatype.

Unfortunatelly it&#39;s not possible to cache the result for displayWidth and
Height, but getting the default screen is cached and provided in another
method.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/libkwineffects/kwinglobals.h <span style="color: \
grey">(dba432432fd3741309a1f5dbe5e564eae059b839)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109177/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 