[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 109176: Strip module path from all Qt #include <>
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2013-02-26 10:38:07
Message-ID: 20130226103807.12892.7890 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 26, 2013, 8:54 a.m., Hugo Pereira Da Costa wrote:
> > kwin/screenedge.cpp, line 45
> > <http://git.reviewboard.kde.org/r/109176/diff/2/?file=115877#file115877line45>
> >
> > shouldn't the QtDBus be removes
> > (etc.)
> >
> > on local software I've been through the excercise of removing all the path Qt's \
> > include directives for porting to Qt5, and it all went well. At some point I had \
> > to make some updates to CMakeLists though, to explicitely turn on some of the Qt \
> > (4) modules.
>
> Martin Gräßlin wrote:
> well I trust the script to do the right thing :-)
>
> The idea is to strip those parts which would cause problems when trying to use the \
> same code base for Qt 4 and Qt 5. QtDeclarative is still existing as an addon, so \
> the <QtDeclarative/QDeclarativeItem> is still valid. Same for QtDBus. Only problem \
> is QX11Info which does not exist in Qt 5.0, but is available I think in 5.1 as an \
> own module. So that will need manual adjustments once we do the port anyway.
> Hugo Pereira Da Costa wrote:
> QX11Info: interesting that it will be back for 5.1
> In oxygenclient it is used to access the X11 Display.
>
> Here when I ported other code to Qt5 (5.0) I had to use QPA to access the display. \
> Something like: QPlatformNativeInterface *native = \
> qApp->platformNativeInterface(); void *display = \
> native->nativeResourceForScreen(QByteArray("display"), \
> QGuiApplication::primaryScreen()); display_ = reinterpret_cast<Display*>(display);
>
> Also, in oxygenclient, the use of QX11Info is bound to passing hints to the widget \
> style in order not to install shadows on the window (I think its actually needed \
> for oxygen-gtk). In any case, since shadow will likely be refactored (right ?), \
> this might as well begone by then.
> Martin Gräßlin wrote:
> > In any case, since shadow will likely be refactored (right ?), this might as well \
> > begone by then.
> which shadows? Decoration shadows or the widget style shadow? Widget style shadows \
> obviously need adjustments as we have to question whether it's still a good idea to \
> pass the pixmap handles. As we don't have QPixmaps any more to render to the pixmap \
> it might be easier to just specify the binary data.
> And decorations, well I want a new lib anyway for Qt 5 :-)
>
> Hugo Pereira Da Costa wrote:
> > > In any case, since shadow will likely be refactored (right ?), this might as \
> > > well begone by then.
> > which shadows? Decoration shadows or the widget style shadow? Widget style \
> > shadows obviously need adjustments as we have to question whether it's still a \
> > good idea to pass the pixmap handles. As we don't have QPixmaps any more to \
> > render to the pixmap it might be easier to just specify the binary data.
> Style decorations. (for menus)
> And yes, I was thinking about the QPixmap::Handle issue (but you are right that one \
> could use basically the same mechanism, and pass data directly instead of handle)
> >
> > And decorations, well I want a new lib anyway for Qt 5 :-)
> hehe, got that yes ;)
>
> in any case, its obviously a ship it, on my side (concerning this review). Let's \
> not diverge.
staying OT: we'll likely need two functions
1. pass the data over to the kwin core/server and get back ref or name
2. demand that ref or name for a window (what requires knowledge about the validity)
since
a) clients ans esp. the style will re-use the very same shadow very often (so no \
point in recreation/reconversion) b) we don't want to store and transfer huge data \
across xproperty, do we? ;-)
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109176/#review28105
-----------------------------------------------------------
On Feb. 26, 2013, 8:04 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109176/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2013, 8:04 a.m.)
>
>
> Review request for kwin and Hugo Pereira Da Costa.
>
>
> Description
> -------
>
> Strip module path from all Qt #include <>
>
> Done with:
> fixqt4headers.pl --strip-modules
>
> Remove not needed includes from kwineffect header files
>
> Only include what's actually needed in the headers. This causes of course
> some additional needed includes in some implementation files.
>
>
> Diffs
> -----
>
> kwin/clients/aurorae/src/aurorae.cpp 682ae1253391145f2f2f5ed4e453c6f88008ac04
> kwin/clients/aurorae/src/lib/auroraetheme.h \
> 07b28ceafcb8276433b2a28fc4fc7f6b559de607 \
> kwin/clients/aurorae/src/lib/auroraetheme.cpp \
> 82844ff5d6df8a0c60b0593fd3204db2bf1525ac \
> kwin/clients/oxygen/config/oxygenanimationconfigwidget.cpp \
> 32ddc935789eac3b0c4cb5d8d11b132eef9aaa4c \
> kwin/clients/oxygen/config/oxygenconfig.cpp \
> 037be09e7148ca6fe8af87ffa044fedb95f1b765 \
> kwin/clients/oxygen/config/oxygenconfigwidget.h \
> a4aada1c47d91c98a6aaa686b6ea3b09d40fa6bd \
> kwin/clients/oxygen/config/oxygenconfigwidget.cpp \
> 71b108862497243402d77e3007400cc44c74cc0a \
> kwin/clients/oxygen/config/oxygendetectwidget.h \
> 191fcb8232d88a2adc636bce808ee8ca972f4815 \
> kwin/clients/oxygen/config/oxygendetectwidget.cpp \
> 8ddf4789cec4e37573da330422d1da1b14bc2ed4 \
> kwin/clients/oxygen/config/oxygenexceptiondialog.h \
> 8aabe9d0d17a3d4df0055e21a133637563e5837e \
> kwin/clients/oxygen/config/oxygenexceptionlistwidget.cpp \
> 31a0ba68b253b186f78ed2112eb0baf3bf9fdd62 \
> kwin/clients/oxygen/demo/oxygenshadowdemodialog.h \
> cfd2928fbcb69ee359dbbad26041eb6b275ccf28 \
> kwin/clients/oxygen/demo/oxygenshadowdemodialog.cpp \
> eb0fa56ccdfeb2ab8e2d69cc08c2eaa637b0cb65 \
> kwin/clients/oxygen/demo/oxygenshadowdemowidget.h \
> 133d6ccd5535ba72affeb5d4d9659e79bde2e786 kwin/clients/oxygen/oxygenclient.h \
> 79af43e10ffbc6526e85abbc57257e914b633c7c kwin/clients/oxygen/oxygenclient.cpp \
> 1bb8ab9dc5651766d06655e955a465210b95adc0 \
> kwin/clients/oxygen/oxygenclientgroupitemdata.h \
> e4678ed9977d417d1d62faacd0129481c0425f7c \
> kwin/clients/oxygen/oxygendecorationdefines.h \
> 434d3054c61a1e73e63cea8bf4659f2bbc286d81 \
> kwin/clients/oxygen/oxygenexceptionlist.cpp \
> 391b43ae29e64c0a9c426c4c97f3b6698657fed5 kwin/clients/oxygen/oxygenfactory.h \
> 0642df6f58acef4eb24c6d9f322aaec00a3d2c00 kwin/clients/oxygen/oxygensizegrip.h \
> 20cf63a4e5f44f2100e99bda2085a5cc1daf16c9 kwin/clients/oxygen/oxygensizegrip.cpp \
> 221ee74b79d9020bed5815c933e09145205c7ad7 \
> kwin/clients/oxygen/oxygentitleanimationdata.h \
> 050860d496b10039e917b086d99b5f80794c8b6f kwin/composite.h \
> b05d1ac04c12e355292f70069486d580ea887495 kwin/composite.cpp \
> 5702ec01d21a2dd7bef95a3eac713485fc2456a8 kwin/dbusinterface.h \
> 40a1dd667a1fe7615af16baa2d23e3df6b1b08e7 kwin/effects.cpp \
> 61e4aaa2f3cb89d178c14e1221710f6f4112df92 kwin/effects/cube/cubeslide.cpp \
> f0459058bf4b5b548d14e7509553f343277f4442 kwin/effects/dashboard/dashboard.h \
> 73d2c65dedc17b628d6659e51239ce574bb7f7f8 kwin/effects/desktopgrid/desktopgrid.h \
> 0f96befeba5ab1b9a0892c8a6e872082f27ce7ee kwin/effects/desktopgrid/desktopgrid.cpp \
> 9c7d98311618d53b9797f9c0b9d8d98f74ad6df5 kwin/effects/diminactive/diminactive.h \
> f1972ab557af9c3ea5874f25620b3b850d2d4c22 kwin/effects/dimscreen/dimscreen.h \
> 571684ed374652ab091a0d37700c453c8aabfbff kwin/effects/glide/glide.cpp \
> b68b2d6f78d1c9eb77d1e6f23b0d1534269127ec kwin/effects/magiclamp/magiclamp.cpp \
> ca8ee49646dce745fe6725ac1fca6ecc1ca2b96f \
> kwin/effects/minimizeanimation/minimizeanimation.cpp \
> 8823f17c23481ddc9445f546a5df8ecac05494c5 \
> kwin/effects/presentwindows/presentwindows.h \
> eecf70afd4ea94308196734a573788a931b3bf09 \
> kwin/effects/presentwindows/presentwindows.cpp \
> 5b2c6e47351a231dbfa8d8f40bcd8f64122cb0f2 kwin/effects/scalein/scalein.cpp \
> e78b0b25947780ba9508a443034e1ffeea35756b \
> kwin/effects/screenedge/screenedgeeffect.cpp \
> 25f1d4a4b67a1d2937067158b5a781a77185eaf2 kwin/effects/screenshot/screenshot.cpp \
> 02f02363b4f3de254936c665445df3857ab38c61 kwin/effects/sheet/sheet.cpp \
> 2e55ed448b35f50ee5c1a2af9a9f79eddf589179 kwin/effects/showfps/showfps.h \
> 00b45c5e618403838837a0ac15419639d0f82b7a kwin/effects/slide/slide.h \
> 419e840c9abc57c680fc950fed16ee97d0a261a0 \
> kwin/effects/slidingpopups/slidingpopups.cpp \
> dc000c5dd0410875b3bf954c7f7268acca043721 kwin/effects/snaphelper/snaphelper.h \
> 3dd67314bcb02228256e25c9a336958c110872d2 \
> kwin/effects/startupfeedback/startupfeedback.cpp \
> f608f7752e2d1635e067da546edb008f1ee7c803 kwin/effects/translucency/translucency.h \
> c23d44c5940a6fcfd1363a0b9ad15202d5bcaba7 kwin/effects/zoom/zoom.h \
> 768af8bd79f05e424bfa3a65d91e027ccd6e2914 kwin/effects/zoom/zoom.cpp \
> 2e14056a0f62b556cbac0a3da010c791e84528d9 kwin/events.cpp \
> c960a0ccc14b42eb39b1a44011e583055cd41411 kwin/geometry.cpp \
> cc048ac6caab4077e2e23af56017e520448d6cd5 \
> kwin/kcmkwin/kwincompositing/ktimerdialog.cpp \
> f8be2c172e77f5e14e73fa9cd582c776f3211807 \
> kwin/kcmkwin/kwindecoration/decorationmodel.cpp \
> 0414874cdf4a593c6449458df8d363b34e848d67 \
> kwin/kcmkwin/kwindecoration/kwindecoration.cpp \
> d24f29830b87c40a2dd31526bae3901e10e4047e kwin/kcmkwin/kwinoptions/windows.cpp \
> 3644de637e0c4f62863a516fd490b0ed71f26f9c kwin/kcmkwin/kwinscripts/module.cpp \
> 6327d24e42a7fdc1d97329bf024d8fb590cc424a kwin/kcmkwin/kwintabbox/layoutpreview.h \
> 220c5a35f31b11104459d8b08672f0ebddfa544c kwin/kcmkwin/kwintabbox/layoutpreview.cpp \
> 89a12e2100cc512b763fb7985bfa5e93b42fbcf4 kwin/libkdecorations/kcommondecoration.h \
> 2f9443de6bb3f5d9e85c416f1c1d010b476f015f kwin/libkdecorations/kdecoration.h \
> 2c20767d9ff921c8b0e55a9f491caa7659146cf1 kwin/libkdecorations/kdecoration_p.h \
> 71833cd3caf9a76bb4dd9488b48d3fea4e2ff299 \
> kwin/libkdecorations/kdecoration_plugins_p.h \
> 87ce51931479bcfa9ba27cd1a043d7a84cd96051 kwin/libkdecorations/kdecorationbridge.h \
> 2cb36c9e656ebc9726a9fef10ee35cbddb982ffd kwin/libkwineffects/kwinanimationeffect.h \
> d7b6722055e0e6917137686e0cf93a6e32c8c5a3 \
> kwin/libkwineffects/kwinanimationeffect.cpp \
> 9709be4517eae710abc41e6b3a52837255f552b7 kwin/libkwineffects/kwineffects.h \
> 79901ecd59c10a54790164598571636b96016b00 kwin/libkwineffects/kwineffects.cpp \
> 28b00399394e18cd4dc4cd9a64b1a45661b5ebae \
> kwin/libkwineffects/kwinglcolorcorrection.h \
> ad40c7aa9dae70b7f80597ae35054309ba337136 \
> kwin/libkwineffects/kwinglcolorcorrection_p.h \
> 0d7e247ad61a8da4e0efd0d8b3eca5ba35224e88 kwin/libkwineffects/kwinglobals.h \
> dba432432fd3741309a1f5dbe5e564eae059b839 kwin/libkwineffects/kwingltexture.h \
> 7a9df727701b78684225e1775fbe50d1502c3bdd kwin/libkwineffects/kwingltexture_p.h \
> 9675ec60acf96c487e1e8e2f3694db13ee70d02e kwin/libkwineffects/kwinglutils.h \
> f68094398252a4155289f53f549f55db9377c661 kwin/libkwineffects/kwinxrenderutils.h \
> 2d2ff7323ced99c89f63bb4cfe777aff834f3077 kwin/libkwineffects/kwinxrenderutils.cpp \
> 1cbef472f2c1431f0796abde36ed016f86931a44 kwin/outline.h \
> 81b1abd3bba19d6a97643e36b1c998916adaaada kwin/overlaywindow.cpp \
> 3602c12abac94b80c075017639a7f15880761fa0 kwin/scene_opengl.cpp \
> 3185c9eca7784e69c9a27a03904dccd984c4a2e3 kwin/scene_xrender.cpp \
> 019e6cd0ec88384b7075c2ad6c61ece8bf5c7ec3 kwin/screenedge.h \
> fe3446f41f33cb95508a654df838f8bb6c9e411d kwin/screenedge.cpp \
> cfcf7261bdb8bb04fa4ee54e6fbd73eb1ee1141f kwin/scripting/scriptedeffect.cpp \
> 83650f11dc68c7047900ac66ee30a8a83c9dc924 kwin/scripting/scripting.h \
> 63670591c58b4a421a8c403fd8bb2e2e0d6f4ee8 kwin/scripting/scripting.cpp \
> 41c5e9be5f951895c3aaec659eda08749ad09463 kwin/scripting/timer.cpp \
> 5629419bb762e3120ed114d26a250291fc1d0cd9 kwin/scripting/workspace_wrapper.h \
> 4b723295d8f9e96fcf7bdeeabd91b3e09dc28ab3 kwin/scripting/workspace_wrapper.cpp \
> 31ec40a626e62865454e8e1fba8c7d4ff0b71d02 kwin/shadow.h \
> f31a0f9e14c958914e3c9a114a938a0bc0b07e76 kwin/tabbox/declarative.cpp \
> 20f6cb1cf136634f9412ecf234451ccdb4b59b2c kwin/tests/test_screen_paint_data.cpp \
> 3202876cfb2bf781831d9a63116723604c280f91 kwin/tests/test_window_paint_data.cpp \
> e9de7e8367a126b44a280f5b5aba84a821b7a324 kwin/thumbnailitem.h \
> 401cb380999d4dbce679c0edce3091d8de0bd3e8 kwin/workspace.cpp \
> 464fd00167f2ef630a7b7e3246fa4e8b90233242
> Diff: http://git.reviewboard.kde.org/r/109176/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109176/">http://git.reviewboard.kde.org/r/109176/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 26th, 2013, 8:54 a.m. UTC, <b>Hugo \
Pereira Da Costa</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: \
2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109176/diff/2/?file=115877#file115877line45" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/screenedge.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">along \
with this program. If not, see <http://www.gnu.org/licenses/>.</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">45</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include \
<QtDBus/QDBusPendingCall></span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">45</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include \
<QtDBus/QDBusPendingCall></span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">shouldn't the QtDBus \
be removes (etc.)
on local software I've been through the excercise of removing all the path \
Qt's include directives for porting to Qt5, and it all went well. At some point I \
had to make some updates to CMakeLists though, to explicitely turn on some of the Qt \
(4) modules. </pre> </blockquote>
<p>On February 26th, 2013, 9:15 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">well I trust the script \
to do the right thing :-)
The idea is to strip those parts which would cause problems when trying to use the \
same code base for Qt 4 and Qt 5. QtDeclarative is still existing as an addon, so the \
<QtDeclarative/QDeclarativeItem> is still valid. Same for QtDBus. Only problem \
is QX11Info which does not exist in Qt 5.0, but is available I think in 5.1 as an own \
module. So that will need manual adjustments once we do the port anyway.</pre> \
</blockquote>
<p>On February 26th, 2013, 9:23 a.m. UTC, <b>Hugo Pereira Da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QX11Info: interesting \
that it will be back for 5.1 In oxygenclient it is used to access the X11 Display.
Here when I ported other code to Qt5 (5.0) I had to use QPA to access the display. \
Something like:
QPlatformNativeInterface *native = qApp->platformNativeInterface();
void *display = \
native->nativeResourceForScreen(QByteArray("display"), \
QGuiApplication::primaryScreen()); display_ = \
reinterpret_cast<Display*>(display);
Also, in oxygenclient, the use of QX11Info is bound to passing hints to the widget \
style in order not to install shadows on the window (I think its actually needed for \
oxygen-gtk). In any case, since shadow will likely be refactored (right ?), this \
might as well begone by then. </pre> </blockquote>
<p>On February 26th, 2013, 9:35 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> In any case, since \
shadow will likely be refactored (right ?), this might as well begone by then. which \
shadows? Decoration shadows or the widget style shadow? Widget style shadows \
obviously need adjustments as we have to question whether it's still a good idea \
to pass the pixmap handles. As we don't have QPixmaps any more to render to the \
pixmap it might be easier to just specify the binary data.
And decorations, well I want a new lib anyway for Qt 5 :-)</pre>
</blockquote>
<p>On February 26th, 2013, 9:40 a.m. UTC, <b>Hugo Pereira Da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> > In any case, \
since shadow will likely be refactored (right ?), this might as well begone by then. \
> which shadows? Decoration shadows or the widget style shadow? Widget style \
shadows obviously need adjustments as we have to question whether it's still a \
good idea to pass the pixmap handles. As we don't have QPixmaps any more to \
render to the pixmap it might be easier to just specify the binary data. Style \
decorations. (for menus) And yes, I was thinking about the QPixmap::Handle issue (but \
you are right that one could use basically the same mechanism, and pass data directly \
instead of handle)
>
> And decorations, well I want a new lib anyway for Qt 5 :-)
hehe, got that yes ;)
in any case, its obviously a ship it, on my side (concerning this review). Let's \
not diverge. </pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">staying OT: \
we'll likely need two functions 1. pass the data over to the kwin core/server and \
get back ref or name 2. demand that ref or name for a window (what requires knowledge \
about the validity)
since
a) clients ans esp. the style will re-use the very same shadow very often (so no \
point in recreation/reconversion) b) we don't want to store and transfer huge \
data across xproperty, do we? ;-)</pre> <br />
<p>- Thomas</p>
<br />
<p>On February 26th, 2013, 8:04 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Hugo Pereira Da Costa.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Feb. 26, 2013, 8:04 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Strip module path from all Qt #include <>
Done with:
fixqt4headers.pl --strip-modules
Remove not needed includes from kwineffect header files
Only include what's actually needed in the headers. This causes of course
some additional needed includes in some implementation files.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/clients/aurorae/src/aurorae.cpp <span style="color: \
grey">(682ae1253391145f2f2f5ed4e453c6f88008ac04)</span></li>
<li>kwin/clients/aurorae/src/lib/auroraetheme.h <span style="color: \
grey">(07b28ceafcb8276433b2a28fc4fc7f6b559de607)</span></li>
<li>kwin/clients/aurorae/src/lib/auroraetheme.cpp <span style="color: \
grey">(82844ff5d6df8a0c60b0593fd3204db2bf1525ac)</span></li>
<li>kwin/clients/oxygen/config/oxygenanimationconfigwidget.cpp <span style="color: \
grey">(32ddc935789eac3b0c4cb5d8d11b132eef9aaa4c)</span></li>
<li>kwin/clients/oxygen/config/oxygenconfig.cpp <span style="color: \
grey">(037be09e7148ca6fe8af87ffa044fedb95f1b765)</span></li>
<li>kwin/clients/oxygen/config/oxygenconfigwidget.h <span style="color: \
grey">(a4aada1c47d91c98a6aaa686b6ea3b09d40fa6bd)</span></li>
<li>kwin/clients/oxygen/config/oxygenconfigwidget.cpp <span style="color: \
grey">(71b108862497243402d77e3007400cc44c74cc0a)</span></li>
<li>kwin/clients/oxygen/config/oxygendetectwidget.h <span style="color: \
grey">(191fcb8232d88a2adc636bce808ee8ca972f4815)</span></li>
<li>kwin/clients/oxygen/config/oxygendetectwidget.cpp <span style="color: \
grey">(8ddf4789cec4e37573da330422d1da1b14bc2ed4)</span></li>
<li>kwin/clients/oxygen/config/oxygenexceptiondialog.h <span style="color: \
grey">(8aabe9d0d17a3d4df0055e21a133637563e5837e)</span></li>
<li>kwin/clients/oxygen/config/oxygenexceptionlistwidget.cpp <span style="color: \
grey">(31a0ba68b253b186f78ed2112eb0baf3bf9fdd62)</span></li>
<li>kwin/clients/oxygen/demo/oxygenshadowdemodialog.h <span style="color: \
grey">(cfd2928fbcb69ee359dbbad26041eb6b275ccf28)</span></li>
<li>kwin/clients/oxygen/demo/oxygenshadowdemodialog.cpp <span style="color: \
grey">(eb0fa56ccdfeb2ab8e2d69cc08c2eaa637b0cb65)</span></li>
<li>kwin/clients/oxygen/demo/oxygenshadowdemowidget.h <span style="color: \
grey">(133d6ccd5535ba72affeb5d4d9659e79bde2e786)</span></li>
<li>kwin/clients/oxygen/oxygenclient.h <span style="color: \
grey">(79af43e10ffbc6526e85abbc57257e914b633c7c)</span></li>
<li>kwin/clients/oxygen/oxygenclient.cpp <span style="color: \
grey">(1bb8ab9dc5651766d06655e955a465210b95adc0)</span></li>
<li>kwin/clients/oxygen/oxygenclientgroupitemdata.h <span style="color: \
grey">(e4678ed9977d417d1d62faacd0129481c0425f7c)</span></li>
<li>kwin/clients/oxygen/oxygendecorationdefines.h <span style="color: \
grey">(434d3054c61a1e73e63cea8bf4659f2bbc286d81)</span></li>
<li>kwin/clients/oxygen/oxygenexceptionlist.cpp <span style="color: \
grey">(391b43ae29e64c0a9c426c4c97f3b6698657fed5)</span></li>
<li>kwin/clients/oxygen/oxygenfactory.h <span style="color: \
grey">(0642df6f58acef4eb24c6d9f322aaec00a3d2c00)</span></li>
<li>kwin/clients/oxygen/oxygensizegrip.h <span style="color: \
grey">(20cf63a4e5f44f2100e99bda2085a5cc1daf16c9)</span></li>
<li>kwin/clients/oxygen/oxygensizegrip.cpp <span style="color: \
grey">(221ee74b79d9020bed5815c933e09145205c7ad7)</span></li>
<li>kwin/clients/oxygen/oxygentitleanimationdata.h <span style="color: \
grey">(050860d496b10039e917b086d99b5f80794c8b6f)</span></li>
<li>kwin/composite.h <span style="color: \
grey">(b05d1ac04c12e355292f70069486d580ea887495)</span></li>
<li>kwin/composite.cpp <span style="color: \
grey">(5702ec01d21a2dd7bef95a3eac713485fc2456a8)</span></li>
<li>kwin/dbusinterface.h <span style="color: \
grey">(40a1dd667a1fe7615af16baa2d23e3df6b1b08e7)</span></li>
<li>kwin/effects.cpp <span style="color: \
grey">(61e4aaa2f3cb89d178c14e1221710f6f4112df92)</span></li>
<li>kwin/effects/cube/cubeslide.cpp <span style="color: \
grey">(f0459058bf4b5b548d14e7509553f343277f4442)</span></li>
<li>kwin/effects/dashboard/dashboard.h <span style="color: \
grey">(73d2c65dedc17b628d6659e51239ce574bb7f7f8)</span></li>
<li>kwin/effects/desktopgrid/desktopgrid.h <span style="color: \
grey">(0f96befeba5ab1b9a0892c8a6e872082f27ce7ee)</span></li>
<li>kwin/effects/desktopgrid/desktopgrid.cpp <span style="color: \
grey">(9c7d98311618d53b9797f9c0b9d8d98f74ad6df5)</span></li>
<li>kwin/effects/diminactive/diminactive.h <span style="color: \
grey">(f1972ab557af9c3ea5874f25620b3b850d2d4c22)</span></li>
<li>kwin/effects/dimscreen/dimscreen.h <span style="color: \
grey">(571684ed374652ab091a0d37700c453c8aabfbff)</span></li>
<li>kwin/effects/glide/glide.cpp <span style="color: \
grey">(b68b2d6f78d1c9eb77d1e6f23b0d1534269127ec)</span></li>
<li>kwin/effects/magiclamp/magiclamp.cpp <span style="color: \
grey">(ca8ee49646dce745fe6725ac1fca6ecc1ca2b96f)</span></li>
<li>kwin/effects/minimizeanimation/minimizeanimation.cpp <span style="color: \
grey">(8823f17c23481ddc9445f546a5df8ecac05494c5)</span></li>
<li>kwin/effects/presentwindows/presentwindows.h <span style="color: \
grey">(eecf70afd4ea94308196734a573788a931b3bf09)</span></li>
<li>kwin/effects/presentwindows/presentwindows.cpp <span style="color: \
grey">(5b2c6e47351a231dbfa8d8f40bcd8f64122cb0f2)</span></li>
<li>kwin/effects/scalein/scalein.cpp <span style="color: \
grey">(e78b0b25947780ba9508a443034e1ffeea35756b)</span></li>
<li>kwin/effects/screenedge/screenedgeeffect.cpp <span style="color: \
grey">(25f1d4a4b67a1d2937067158b5a781a77185eaf2)</span></li>
<li>kwin/effects/screenshot/screenshot.cpp <span style="color: \
grey">(02f02363b4f3de254936c665445df3857ab38c61)</span></li>
<li>kwin/effects/sheet/sheet.cpp <span style="color: \
grey">(2e55ed448b35f50ee5c1a2af9a9f79eddf589179)</span></li>
<li>kwin/effects/showfps/showfps.h <span style="color: \
grey">(00b45c5e618403838837a0ac15419639d0f82b7a)</span></li>
<li>kwin/effects/slide/slide.h <span style="color: \
grey">(419e840c9abc57c680fc950fed16ee97d0a261a0)</span></li>
<li>kwin/effects/slidingpopups/slidingpopups.cpp <span style="color: \
grey">(dc000c5dd0410875b3bf954c7f7268acca043721)</span></li>
<li>kwin/effects/snaphelper/snaphelper.h <span style="color: \
grey">(3dd67314bcb02228256e25c9a336958c110872d2)</span></li>
<li>kwin/effects/startupfeedback/startupfeedback.cpp <span style="color: \
grey">(f608f7752e2d1635e067da546edb008f1ee7c803)</span></li>
<li>kwin/effects/translucency/translucency.h <span style="color: \
grey">(c23d44c5940a6fcfd1363a0b9ad15202d5bcaba7)</span></li>
<li>kwin/effects/zoom/zoom.h <span style="color: \
grey">(768af8bd79f05e424bfa3a65d91e027ccd6e2914)</span></li>
<li>kwin/effects/zoom/zoom.cpp <span style="color: \
grey">(2e14056a0f62b556cbac0a3da010c791e84528d9)</span></li>
<li>kwin/events.cpp <span style="color: \
grey">(c960a0ccc14b42eb39b1a44011e583055cd41411)</span></li>
<li>kwin/geometry.cpp <span style="color: \
grey">(cc048ac6caab4077e2e23af56017e520448d6cd5)</span></li>
<li>kwin/kcmkwin/kwincompositing/ktimerdialog.cpp <span style="color: \
grey">(f8be2c172e77f5e14e73fa9cd582c776f3211807)</span></li>
<li>kwin/kcmkwin/kwindecoration/decorationmodel.cpp <span style="color: \
grey">(0414874cdf4a593c6449458df8d363b34e848d67)</span></li>
<li>kwin/kcmkwin/kwindecoration/kwindecoration.cpp <span style="color: \
grey">(d24f29830b87c40a2dd31526bae3901e10e4047e)</span></li>
<li>kwin/kcmkwin/kwinoptions/windows.cpp <span style="color: \
grey">(3644de637e0c4f62863a516fd490b0ed71f26f9c)</span></li>
<li>kwin/kcmkwin/kwinscripts/module.cpp <span style="color: \
grey">(6327d24e42a7fdc1d97329bf024d8fb590cc424a)</span></li>
<li>kwin/kcmkwin/kwintabbox/layoutpreview.h <span style="color: \
grey">(220c5a35f31b11104459d8b08672f0ebddfa544c)</span></li>
<li>kwin/kcmkwin/kwintabbox/layoutpreview.cpp <span style="color: \
grey">(89a12e2100cc512b763fb7985bfa5e93b42fbcf4)</span></li>
<li>kwin/libkdecorations/kcommondecoration.h <span style="color: \
grey">(2f9443de6bb3f5d9e85c416f1c1d010b476f015f)</span></li>
<li>kwin/libkdecorations/kdecoration.h <span style="color: \
grey">(2c20767d9ff921c8b0e55a9f491caa7659146cf1)</span></li>
<li>kwin/libkdecorations/kdecoration_p.h <span style="color: \
grey">(71833cd3caf9a76bb4dd9488b48d3fea4e2ff299)</span></li>
<li>kwin/libkdecorations/kdecoration_plugins_p.h <span style="color: \
grey">(87ce51931479bcfa9ba27cd1a043d7a84cd96051)</span></li>
<li>kwin/libkdecorations/kdecorationbridge.h <span style="color: \
grey">(2cb36c9e656ebc9726a9fef10ee35cbddb982ffd)</span></li>
<li>kwin/libkwineffects/kwinanimationeffect.h <span style="color: \
grey">(d7b6722055e0e6917137686e0cf93a6e32c8c5a3)</span></li>
<li>kwin/libkwineffects/kwinanimationeffect.cpp <span style="color: \
grey">(9709be4517eae710abc41e6b3a52837255f552b7)</span></li>
<li>kwin/libkwineffects/kwineffects.h <span style="color: \
grey">(79901ecd59c10a54790164598571636b96016b00)</span></li>
<li>kwin/libkwineffects/kwineffects.cpp <span style="color: \
grey">(28b00399394e18cd4dc4cd9a64b1a45661b5ebae)</span></li>
<li>kwin/libkwineffects/kwinglcolorcorrection.h <span style="color: \
grey">(ad40c7aa9dae70b7f80597ae35054309ba337136)</span></li>
<li>kwin/libkwineffects/kwinglcolorcorrection_p.h <span style="color: \
grey">(0d7e247ad61a8da4e0efd0d8b3eca5ba35224e88)</span></li>
<li>kwin/libkwineffects/kwinglobals.h <span style="color: \
grey">(dba432432fd3741309a1f5dbe5e564eae059b839)</span></li>
<li>kwin/libkwineffects/kwingltexture.h <span style="color: \
grey">(7a9df727701b78684225e1775fbe50d1502c3bdd)</span></li>
<li>kwin/libkwineffects/kwingltexture_p.h <span style="color: \
grey">(9675ec60acf96c487e1e8e2f3694db13ee70d02e)</span></li>
<li>kwin/libkwineffects/kwinglutils.h <span style="color: \
grey">(f68094398252a4155289f53f549f55db9377c661)</span></li>
<li>kwin/libkwineffects/kwinxrenderutils.h <span style="color: \
grey">(2d2ff7323ced99c89f63bb4cfe777aff834f3077)</span></li>
<li>kwin/libkwineffects/kwinxrenderutils.cpp <span style="color: \
grey">(1cbef472f2c1431f0796abde36ed016f86931a44)</span></li>
<li>kwin/outline.h <span style="color: \
grey">(81b1abd3bba19d6a97643e36b1c998916adaaada)</span></li>
<li>kwin/overlaywindow.cpp <span style="color: \
grey">(3602c12abac94b80c075017639a7f15880761fa0)</span></li>
<li>kwin/scene_opengl.cpp <span style="color: \
grey">(3185c9eca7784e69c9a27a03904dccd984c4a2e3)</span></li>
<li>kwin/scene_xrender.cpp <span style="color: \
grey">(019e6cd0ec88384b7075c2ad6c61ece8bf5c7ec3)</span></li>
<li>kwin/screenedge.h <span style="color: \
grey">(fe3446f41f33cb95508a654df838f8bb6c9e411d)</span></li>
<li>kwin/screenedge.cpp <span style="color: \
grey">(cfcf7261bdb8bb04fa4ee54e6fbd73eb1ee1141f)</span></li>
<li>kwin/scripting/scriptedeffect.cpp <span style="color: \
grey">(83650f11dc68c7047900ac66ee30a8a83c9dc924)</span></li>
<li>kwin/scripting/scripting.h <span style="color: \
grey">(63670591c58b4a421a8c403fd8bb2e2e0d6f4ee8)</span></li>
<li>kwin/scripting/scripting.cpp <span style="color: \
grey">(41c5e9be5f951895c3aaec659eda08749ad09463)</span></li>
<li>kwin/scripting/timer.cpp <span style="color: \
grey">(5629419bb762e3120ed114d26a250291fc1d0cd9)</span></li>
<li>kwin/scripting/workspace_wrapper.h <span style="color: \
grey">(4b723295d8f9e96fcf7bdeeabd91b3e09dc28ab3)</span></li>
<li>kwin/scripting/workspace_wrapper.cpp <span style="color: \
grey">(31ec40a626e62865454e8e1fba8c7d4ff0b71d02)</span></li>
<li>kwin/shadow.h <span style="color: \
grey">(f31a0f9e14c958914e3c9a114a938a0bc0b07e76)</span></li>
<li>kwin/tabbox/declarative.cpp <span style="color: \
grey">(20f6cb1cf136634f9412ecf234451ccdb4b59b2c)</span></li>
<li>kwin/tests/test_screen_paint_data.cpp <span style="color: \
grey">(3202876cfb2bf781831d9a63116723604c280f91)</span></li>
<li>kwin/tests/test_window_paint_data.cpp <span style="color: \
grey">(e9de7e8367a126b44a280f5b5aba84a821b7a324)</span></li>
<li>kwin/thumbnailitem.h <span style="color: \
grey">(401cb380999d4dbce679c0edce3091d8de0bd3e8)</span></li>
<li>kwin/workspace.cpp <span style="color: \
grey">(464fd00167f2ef630a7b7e3246fa4e8b90233242)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109176/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic