'Review Request 109176: Remove not needed includes from kwineffect header files'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request 109176: Remove not needed includes from kwineffect header files
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2013-02-26 7:12:51
Message-ID: 20130226071251.15796.28274 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109176/
-----------------------------------------------------------

Review request for kwin.

Description
-------

Remove not needed includes from kwineffect header files

Only include what's actually needed in the headers. This causes of course
some additional needed includes in some implementation files.

Diffs
-----

  kwin/effects/cube/cubeslide.cpp f0459058bf4b5b548d14e7509553f343277f4442 
  kwin/effects/screenedge/screenedgeeffect.cpp 25f1d4a4b67a1d2937067158b5a781a77185eaf2 
  kwin/effects/screenshot/screenshot.cpp 02f02363b4f3de254936c665445df3857ab38c61 
  kwin/effects/sheet/sheet.cpp 2e55ed448b35f50ee5c1a2af9a9f79eddf589179 
  kwin/libkwineffects/kwinanimationeffect.cpp 9709be4517eae710abc41e6b3a52837255f552b7 
  kwin/libkwineffects/kwineffects.h 79901ecd59c10a54790164598571636b96016b00 
  kwin/libkwineffects/kwineffects.cpp 28b00399394e18cd4dc4cd9a64b1a45661b5ebae 
  kwin/libkwineffects/kwinglcolorcorrection.h ad40c7aa9dae70b7f80597ae35054309ba337136 
  kwin/libkwineffects/kwinglcolorcorrection_p.h 0d7e247ad61a8da4e0efd0d8b3eca5ba35224e88 
  kwin/libkwineffects/kwinglobals.h dba432432fd3741309a1f5dbe5e564eae059b839 
  kwin/libkwineffects/kwingltexture.h 7a9df727701b78684225e1775fbe50d1502c3bdd 
  kwin/libkwineffects/kwingltexture_p.h 9675ec60acf96c487e1e8e2f3694db13ee70d02e 
  kwin/libkwineffects/kwinglutils.h f68094398252a4155289f53f549f55db9377c661 
  kwin/libkwineffects/kwinxrenderutils.h 2d2ff7323ced99c89f63bb4cfe777aff834f3077 
  kwin/libkwineffects/kwinxrenderutils.cpp 1cbef472f2c1431f0796abde36ed016f86931a44 
  kwin/scene_opengl.cpp 3185c9eca7784e69c9a27a03904dccd984c4a2e3 
  kwin/scripting/workspace_wrapper.h 4b723295d8f9e96fcf7bdeeabd91b3e09dc28ab3 
  kwin/tests/test_screen_paint_data.cpp 3202876cfb2bf781831d9a63116723604c280f91 
  kwin/tests/test_window_paint_data.cpp e9de7e8367a126b44a280f5b5aba84a821b7a324 

Diff: http://git.reviewboard.kde.org/r/109176/diff/

Testing
-------

Thanks,

Martin Gräßlin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109176/">http://git.reviewboard.kde.org/r/109176/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Remove not needed includes from kwineffect header files

Only include what&#39;s actually needed in the headers. This causes of course
some additional needed includes in some implementation files.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/cube/cubeslide.cpp <span style="color: \
grey">(f0459058bf4b5b548d14e7509553f343277f4442)</span></li>

 <li>kwin/effects/screenedge/screenedgeeffect.cpp <span style="color: \
grey">(25f1d4a4b67a1d2937067158b5a781a77185eaf2)</span></li>

 <li>kwin/effects/screenshot/screenshot.cpp <span style="color: \
grey">(02f02363b4f3de254936c665445df3857ab38c61)</span></li>

 <li>kwin/effects/sheet/sheet.cpp <span style="color: \
grey">(2e55ed448b35f50ee5c1a2af9a9f79eddf589179)</span></li>

 <li>kwin/libkwineffects/kwinanimationeffect.cpp <span style="color: \
grey">(9709be4517eae710abc41e6b3a52837255f552b7)</span></li>

 <li>kwin/libkwineffects/kwineffects.h <span style="color: \
grey">(79901ecd59c10a54790164598571636b96016b00)</span></li>

 <li>kwin/libkwineffects/kwineffects.cpp <span style="color: \
grey">(28b00399394e18cd4dc4cd9a64b1a45661b5ebae)</span></li>

 <li>kwin/libkwineffects/kwinglcolorcorrection.h <span style="color: \
grey">(ad40c7aa9dae70b7f80597ae35054309ba337136)</span></li>

 <li>kwin/libkwineffects/kwinglcolorcorrection_p.h <span style="color: \
grey">(0d7e247ad61a8da4e0efd0d8b3eca5ba35224e88)</span></li>

 <li>kwin/libkwineffects/kwinglobals.h <span style="color: \
grey">(dba432432fd3741309a1f5dbe5e564eae059b839)</span></li>

 <li>kwin/libkwineffects/kwingltexture.h <span style="color: \
grey">(7a9df727701b78684225e1775fbe50d1502c3bdd)</span></li>

 <li>kwin/libkwineffects/kwingltexture_p.h <span style="color: \
grey">(9675ec60acf96c487e1e8e2f3694db13ee70d02e)</span></li>

 <li>kwin/libkwineffects/kwinglutils.h <span style="color: \
grey">(f68094398252a4155289f53f549f55db9377c661)</span></li>

 <li>kwin/libkwineffects/kwinxrenderutils.h <span style="color: \
grey">(2d2ff7323ced99c89f63bb4cfe777aff834f3077)</span></li>

 <li>kwin/libkwineffects/kwinxrenderutils.cpp <span style="color: \
grey">(1cbef472f2c1431f0796abde36ed016f86931a44)</span></li>

 <li>kwin/scene_opengl.cpp <span style="color: \
grey">(3185c9eca7784e69c9a27a03904dccd984c4a2e3)</span></li>

 <li>kwin/scripting/workspace_wrapper.h <span style="color: \
grey">(4b723295d8f9e96fcf7bdeeabd91b3e09dc28ab3)</span></li>

 <li>kwin/tests/test_screen_paint_data.cpp <span style="color: \
grey">(3202876cfb2bf781831d9a63116723604c280f91)</span></li>

 <li>kwin/tests/test_window_paint_data.cpp <span style="color: \
grey">(e9de7e8367a126b44a280f5b5aba84a821b7a324)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109176/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 