'Re: Review Request 109141: CMakeLists cleanup'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 109141: CMakeLists cleanup
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2013-02-25 13:48:54
Message-ID: 20130225134854.31665.14874 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109141/
-----------------------------------------------------------

(Updated Feb. 25, 2013, 2:48 p.m.)

Review request for kwin.

Changes
-------

* empty else()
* effects no longer need xfixes and xrender from XLib

Description (updated)
-------

Effects no longer need xfixes and xrender from XLib

CMake cleanup: empty else()

Split the libs we link to into multiple variables

Using a lib variable for:
* own libs
* qt libs
* kde libs
* xlib libs
* xcb libs

and link those groups together in target_link_libraries. This should
make the code easier to read and easier to support in future for some
time both Qt4 and Qt5.

Cmake cleanup: empty endfoo()

CMake Cleanup: empty endif

Diffs (updated)
-----

  kwin/kcmkwin/CMakeLists.txt 4bd3a3580cdcf197ca0e31a4767fac4d5923b553 
  kwin/libkwineffects/CMakeLists.txt 009d7bc21f796727c1d2428013bf989d500ce44e 
  kwin/libkwineffects/kwinxrenderutils.h 2d2ff7323ced99c89f63bb4cfe777aff834f3077 
  kwin/CMakeLists.txt b5b0385035e182db166ead3ead754ab39e6ad763 
  kwin/clients/CMakeLists.txt 45db68c4ead55986940dd8f87780ef985751c59d 
  kwin/effects/CMakeLists.txt b64b5c2e621f0229c2222a4e0f84d345a6b62cd9 

Diff: http://git.reviewboard.kde.org/r/109141/diff/

Testing
-------

Thanks,

Martin Gräßlin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109141/">http://git.reviewboard.kde.org/r/109141/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Feb. 25, 2013, 2:48 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">* empty else()
* effects no longer need xfixes and xrender from XLib</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  \
(updated)</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Effects no longer need xfixes and xrender from XLib

CMake cleanup: empty else()

Split the libs we link to into multiple variables

Using a lib variable for:
* own libs
* qt libs
* kde libs
* xlib libs
* xcb libs

and link those groups together in target_link_libraries. This should
make the code easier to read and easier to support in future for some
time both Qt4 and Qt5.

Cmake cleanup: empty endfoo()

CMake Cleanup: empty endif</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/kcmkwin/CMakeLists.txt <span style="color: \
grey">(4bd3a3580cdcf197ca0e31a4767fac4d5923b553)</span></li>

 <li>kwin/libkwineffects/CMakeLists.txt <span style="color: \
grey">(009d7bc21f796727c1d2428013bf989d500ce44e)</span></li>

 <li>kwin/libkwineffects/kwinxrenderutils.h <span style="color: \
grey">(2d2ff7323ced99c89f63bb4cfe777aff834f3077)</span></li>

 <li>kwin/CMakeLists.txt <span style="color: \
grey">(b5b0385035e182db166ead3ead754ab39e6ad763)</span></li>

 <li>kwin/clients/CMakeLists.txt <span style="color: \
grey">(45db68c4ead55986940dd8f87780ef985751c59d)</span></li>

 <li>kwin/effects/CMakeLists.txt <span style="color: \
grey">(b64b5c2e621f0229c2222a4e0f84d345a6b62cd9)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109141/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 