[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 108445: Add icons of selected desktop to Desktop TabBox
From: "Commit Hook" <null () kde ! org>
Date: 2013-02-25 12:39:59
Message-ID: 20130225123959.21682.45431 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108445/#review28008
-----------------------------------------------------------
This review has been submitted with commit f183a0bec4bf644da9327cbbee96f74497cc19d4 \
by Martin Gräßlin to branch master.
- Commit Hook
On Feb. 20, 2013, 11:23 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108445/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2013, 11:23 a.m.)
>
>
> Review request for kwin.
>
>
> Description
> -------
>
> Add icons of selected desktop to Desktop TabBox
>
> To support this feature the DesktopModel is turned into a tree model with
> the desktops on the root level and the Client's at the next level.
>
> In the view a VisualDataModel is used which kind of supports a tree model
> by setting the root index. A list view is added underneath all the
> desktops showing the icons of the windows on the desktop one switches to.
>
> BUG: 306187
> FIXED-IN: 4.11
>
>
> This addresses bug 306187.
> http://bugs.kde.org/show_bug.cgi?id=306187
>
>
> Diffs
> -----
>
> kwin/tabbox/clientmodel.cpp c8b1d19df224bf943cde849aa9f767ab67d96e4a
> kwin/tabbox/declarative.cpp 5beaf1bcf945126b7529b177c57aabf872243179
> kwin/tabbox/desktopmodel.cpp 0e43ce8e42010085db552b6d80bc68838cc42410
> kwin/tabbox/qml/desktop.qml 6c24ef32ea477fddb7b69e4ec3b51ab0a27ae8b3
>
> Diff: http://git.reviewboard.kde.org/r/108445/diff/
>
>
> Testing
> -------
>
> I'm not yet convinced that the model is correct as I get many:
> QML Image: Failed to get image from provider: image://client/6/1/1199892287-17
>
> Will try to add a unit test to it
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108445/">http://git.reviewboard.kde.org/r/108445/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit f183a0bec4bf644da9327cbbee96f74497cc19d4 by Martin Gräßlin to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On February 20th, 2013, 11:23 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Feb. 20, 2013, 11:23 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add icons of selected desktop to Desktop TabBox
To support this feature the DesktopModel is turned into a tree model with
the desktops on the root level and the Client's at the next level.
In the view a VisualDataModel is used which kind of supports a tree model
by setting the root index. A list view is added underneath all the
desktops showing the icons of the windows on the desktop one switches to.
BUG: 306187
FIXED-IN: 4.11</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I'm not yet convinced that the model is correct as I get many: QML \
Image: Failed to get image from provider: image://client/6/1/1199892287-17
Will try to add a unit test to it</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=306187">306187</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/tabbox/clientmodel.cpp <span style="color: \
grey">(c8b1d19df224bf943cde849aa9f767ab67d96e4a)</span></li>
<li>kwin/tabbox/declarative.cpp <span style="color: \
grey">(5beaf1bcf945126b7529b177c57aabf872243179)</span></li>
<li>kwin/tabbox/desktopmodel.cpp <span style="color: \
grey">(0e43ce8e42010085db552b6d80bc68838cc42410)</span></li>
<li>kwin/tabbox/qml/desktop.qml <span style="color: \
grey">(6c24ef32ea477fddb7b69e4ec3b51ab0a27ae8b3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108445/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic