'Re: Review Request 109086: remove glIsVSync and pointless waitsync'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 109086: remove glIsVSync and pointless waitsync
From:       Thomas_Lübking <thomas.luebking () gmail ! com>
Date:       2013-02-24 22:30:53
Message-ID: 20130224223053.13518.42766 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109086/#review27986
-----------------------------------------------------------

wrong update comment. update reduces to only one swapBuffer test an fixes the two other items.

- Thomas Lübking

On Feb. 24, 2013, 10:28 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109086/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2013, 10:28 p.m.)
> 
> 
> Review request for kwin, Martin Gräßlin and Ralf Jung.
> 
> 
> Description
> -------
> 
> follow-up to https://git.reviewboard.kde.org/r/107198/
> We need more detailed info about vsync (notably whether it blocks and is present beyond the setting)
> WaitSync was an implementation detail of a backend only.
> 
> 
> Diffs
> -----
> 
>   kwin/options.h b6de1d5 
>   kwin/options.cpp 893b1fa 
>   kwin/scene.h f06d150 
>   kwin/scene.cpp 685254b 
>   kwin/scene_opengl.h 7971c83 
>   kwin/scene_opengl.cpp 3185c9e 
>   kwin/composite.cpp e6cb0d4 
>   kwin/glxbackend.h ce46bac 
>   kwin/glxbackend.cpp be11497 
> 
> Diff: http://git.reviewboard.kde.org/r/109086/diff/
> 
> 
> Testing
> -------
> 
> running.
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109086/">http://git.reviewboard.kde.org/r/109086/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">wrong update comment. \
update reduces to only one swapBuffer test an fixes the two other items.</pre>  <br \
/>

<p>- Thomas</p>

<br />
<p>On February 24th, 2013, 10:28 p.m. UTC, Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Martin Gräßlin and Ralf Jung.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Feb. 24, 2013, 10:28 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">follow-up to https://git.reviewboard.kde.org/r/107198/ We need more \
detailed info about vsync (notably whether it blocks and is present beyond the \
setting) WaitSync was an implementation detail of a backend only.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">running.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/options.h <span style="color: grey">(b6de1d5)</span></li>

 <li>kwin/options.cpp <span style="color: grey">(893b1fa)</span></li>

 <li>kwin/scene.h <span style="color: grey">(f06d150)</span></li>

 <li>kwin/scene.cpp <span style="color: grey">(685254b)</span></li>

 <li>kwin/scene_opengl.h <span style="color: grey">(7971c83)</span></li>

 <li>kwin/scene_opengl.cpp <span style="color: grey">(3185c9e)</span></li>

 <li>kwin/composite.cpp <span style="color: grey">(e6cb0d4)</span></li>

 <li>kwin/glxbackend.h <span style="color: grey">(ce46bac)</span></li>

 <li>kwin/glxbackend.cpp <span style="color: grey">(be11497)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109086/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 