[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 109075: Rewrite of Scale In effect to JavaScript
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2013-02-21 13:18:59
Message-ID: 20130221131859.8191.85934 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109075/#review27841
-----------------------------------------------------------
kwin/effects/scalein/package/contents/code/main.js
<http://git.reviewboard.kde.org/r/109075/#comment20865>
looks like some code is missing here
- Martin Gräßlin
On Feb. 21, 2013, 2:08 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109075/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2013, 2:08 p.m.)
>
>
> Review request for kwin.
>
>
> Description
> -------
>
> This patch re-implements the Scale In effect in JavaScript.
>
> We probably need some sort of update script? Since the current effect is just \
> scalein.desktop while this one is now kwin4_effect_scalein.desktop
>
> Diffs
> -----
>
> kwin/effects/CMakeLists.txt 6d2457c
> kwin/effects/scalein/CMakeLists.txt 6a16861
> kwin/effects/scalein/package/CMakeLists.txt PRE-CREATION
> kwin/effects/scalein/package/contents/code/main.js PRE-CREATION
> kwin/effects/scalein/package/metadata.desktop PRE-CREATION
> kwin/effects/scalein/scalein.cpp e78b0b2
> kwin/effects/scalein/scalein.desktop a084435
> kwin/effects/scalein/scalein.h 0b3ae56
>
> Diff: http://git.reviewboard.kde.org/r/109075/diff/
>
>
> Testing
> -------
>
> On OpenGL it works as expected (windows zoom in, but for instance Plasma popups \
> don't) but on my lightdm --test-mode session which only supports XRender, also the \
> Plasma popups zoom in. Couldn't figure out why that is.
>
> Thanks,
>
> Kai Uwe Broulik
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109075/">http://git.reviewboard.kde.org/r/109075/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109075/diff/3/?file=114779#file114779line60" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/effects/scalein/package/contents/code/main.js</a> <span \
style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">60</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">init</span><span class="o">:</span> <span class="kd">function</span> <span \
class="p">()</span> <span class="p">{</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">61</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s2">"use strict"</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks like \
some code is missing here</pre> </div>
<br />
<p>- Martin</p>
<br />
<p>On February 21st, 2013, 2:08 p.m. CET, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Feb. 21, 2013, 2:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch re-implements the Scale In effect in JavaScript.
We probably need some sort of update script? Since the current effect is just \
scalein.desktop while this one is now kwin4_effect_scalein.desktop</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">On OpenGL it works as expected (windows zoom in, but for instance Plasma \
popups don't) but on my lightdm --test-mode session which only supports XRender, \
also the Plasma popups zoom in. Couldn't figure out why that is.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/CMakeLists.txt <span style="color: grey">(6d2457c)</span></li>
<li>kwin/effects/scalein/CMakeLists.txt <span style="color: \
grey">(6a16861)</span></li>
<li>kwin/effects/scalein/package/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/effects/scalein/package/contents/code/main.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/effects/scalein/package/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/effects/scalein/scalein.cpp <span style="color: grey">(e78b0b2)</span></li>
<li>kwin/effects/scalein/scalein.desktop <span style="color: \
grey">(a084435)</span></li>
<li>kwin/effects/scalein/scalein.h <span style="color: grey">(0b3ae56)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109075/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic