[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 108663: Do not alter font settings for pixel size fonts
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2013-01-30 9:09:44
Message-ID: 20130130090944.10377.98987 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 30, 2013, 7:40 a.m., Martin Gräßlin wrote:
> > applied the patch: problem not solved on my system
It's not supposed to.
As mentioned, i don't believe that you (lost tiny elements like the "ü" dots) and \
Aaron (some glyphs not rendered at all) experience the same issue. There's no reason \
why "ü" should be resolved to "u" and since XRender indicates this is some rendering \
issue (tiny elements lost - did you try xrender on the native graphicssystem, because \
it has a different font renderer - also: what about "ß"?), this will be in the \
rendering rather than utf resolution.
The patch is based on the on a CNHK user claim that setting the pointSize on \
pixelSize (asian) fonts is problematic and the estimation from Aarons screenshot that \
this is the case for him.
The vast majority of all users will not enter this codepath ever (also because \
they'll eg. have installed vector glyphs for asian fonts nowadays)
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108663/#review26391
-----------------------------------------------------------
On Jan. 29, 2013, 4:38 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108663/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2013, 4:38 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> Likely raster fonts which cannot be reasonably altered (bold, italic) and pointSize \
> cannot be set at all. I assume this fixes attached bug (but only CC it in the \
> commit)
>
> This addresses bug 313915.
> http://bugs.kde.org/show_bug.cgi?id=313915
>
>
> Diffs
> -----
>
> kwin/effects/boxswitch/boxswitch.cpp e15bcd4
> kwin/effects/coverswitch/coverswitch.cpp d1c1a92
> kwin/effects/desktopgrid/desktopgrid.cpp 53532cc
> kwin/effects/flipswitch/flipswitch.cpp 445405e
> kwin/effects/presentwindows/presentwindows.cpp ff53aef
> kwin/effects/windowgeometry/windowgeometry.cpp b33a05d
>
> Diff: http://git.reviewboard.kde.org/r/108663/diff/
>
>
> Testing
> -------
>
> I had report about this being very nasty for asian users in bespin (where such \
> alterations happen all over the UI, severely impacting usability of the GUI) and \
> while there meanwhile are/should be Asian vector fonts (such as all you use are - \
> TTF, Type1 and OTF) we'd still run in trouble here.
> Otherwise no real testing, not. Vast majority of users will not be impacted at all \
> and if someone used a raster font for the system, he only had trouble so far (= \
> "cannot become worse")
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108663/">http://git.reviewboard.kde.org/r/108663/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 30th, 2013, 7:40 a.m. UTC, <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">applied the patch: problem not solved on my system</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's not supposed \
to. As mentioned, i don't believe that you (lost tiny elements like the \
"ü" dots) and Aaron (some glyphs not rendered at all) experience the same \
issue. There's no reason why "ü" should be resolved to "u" \
and since XRender indicates this is some rendering issue (tiny elements lost - did \
you try xrender on the native graphicssystem, because it has a different font \
renderer - also: what about "ß"?), this will be in the rendering rather \
than utf resolution.
The patch is based on the on a CNHK user claim that setting the pointSize on \
pixelSize (asian) fonts is problematic and the estimation from Aarons screenshot that \
this is the case for him.
The vast majority of all users will not enter this codepath ever (also because \
they'll eg. have installed vector glyphs for asian fonts nowadays)</pre> <br />
<p>- Thomas</p>
<br />
<p>On January 29th, 2013, 4:38 p.m. UTC, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Jan. 29, 2013, 4:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Likely raster fonts which cannot be reasonably altered (bold, italic) \
and pointSize cannot be set at all. I assume this fixes attached bug (but only CC it \
in the commit)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I had report about this being very nasty for asian users in bespin \
(where such alterations happen all over the UI, severely impacting usability of the \
GUI) and while there meanwhile are/should be Asian vector fonts (such as all you use \
are - TTF, Type1 and OTF) we'd still run in trouble here.
Otherwise no real testing, not. Vast majority of users will not be impacted at all \
and if someone used a raster font for the system, he only had trouble so far (= \
"cannot become worse")</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=313915">313915</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/boxswitch/boxswitch.cpp <span style="color: \
grey">(e15bcd4)</span></li>
<li>kwin/effects/coverswitch/coverswitch.cpp <span style="color: \
grey">(d1c1a92)</span></li>
<li>kwin/effects/desktopgrid/desktopgrid.cpp <span style="color: \
grey">(53532cc)</span></li>
<li>kwin/effects/flipswitch/flipswitch.cpp <span style="color: \
grey">(445405e)</span></li>
<li>kwin/effects/presentwindows/presentwindows.cpp <span style="color: \
grey">(ff53aef)</span></li>
<li>kwin/effects/windowgeometry/windowgeometry.cpp <span style="color: \
grey">(b33a05d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108663/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic