'Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2013-01-28 14:38:41
Message-ID: 20130128143841.12979.44965 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108643/
-----------------------------------------------------------

Review request for kwin, Plasma, Martin Gräßlin, and Thomas Lübking.

Description
-------

Updated version of Thomas' patch from https://git.reviewboard.kde.org/r/108585/

Tested and works in the use case originally noted as broken, and as a bonus includes \
getting rid of usage of lib#kephal.

This addresses bug 313835.
    http://bugs.kde.org/show_bug.cgi?id=313835

Diffs
-----

  ksmserver/screenlocker/CMakeLists.txt bab32eda33526bbe5149bc903fbb6a28fb9d28d7 
  ksmserver/screenlocker/greeter/CMakeLists.txt \
f89a98d66b774d00bbe8b881c66298ed7e339dac   \
ksmserver/screenlocker/greeter/greeterapp.cpp \
b41cc74ce4f072610772366be3abdf1f4f25f24e   ksmserver/screenlocker/lockwindow.h \
5cbc76956a4b83d46da96a7ef768116ffdd505c3   ksmserver/screenlocker/lockwindow.cpp \
147853b5625277a35bf01247366c6597636c638c 

Diff: http://git.reviewboard.kde.org/r/108643/diff/

Testing
-------

start locker when internal laptop screen is on
plug in external screen
kscreen automagically switches it on and the laptop screen off
locker displays properly

Thanks,

Aaron J. Seigo

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108643/">http://git.reviewboard.kde.org/r/108643/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Plasma, Martin Gräßlin, and Thomas Lübking.</div>
<div>By Aaron J. Seigo.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Updated version of Thomas&#39; patch from \
https://git.reviewboard.kde.org/r/108585/

Tested and works in the use case originally noted as broken, and as a bonus includes \
getting rid of usage of lib#kephal.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">start locker when internal laptop screen is on plug in external screen
kscreen automagically switches it on and the laptop screen off
locker displays properly</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=313835">313835</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/screenlocker/CMakeLists.txt <span style="color: \
grey">(bab32eda33526bbe5149bc903fbb6a28fb9d28d7)</span></li>

 <li>ksmserver/screenlocker/greeter/CMakeLists.txt <span style="color: \
grey">(f89a98d66b774d00bbe8b881c66298ed7e339dac)</span></li>

 <li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: \
grey">(b41cc74ce4f072610772366be3abdf1f4f25f24e)</span></li>

 <li>ksmserver/screenlocker/lockwindow.h <span style="color: \
grey">(5cbc76956a4b83d46da96a7ef768116ffdd505c3)</span></li>

 <li>ksmserver/screenlocker/lockwindow.cpp <span style="color: \
grey">(147853b5625277a35bf01247366c6597636c638c)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108643/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 