[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 108585: Fix screenlocker lockwindow geometry on screen resizes
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2013-01-28 11:47:47
Message-ID: 20130128114747.23296.10256 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108585/#review26301
-----------------------------------------------------------
this still does not work p[roperly. now i'm getting a (too small) black rectangle on \
the screen around which i can see the rest of my desktop and the locker window is \
still not being shown. investigating now.
ksmserver/screenlocker/lockwindow.cpp
<http://git.reviewboard.kde.org/r/108585/#comment20020>
spaces, not tabs.
- Aaron J. Seigo
On Jan. 25, 2013, 11:04 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108585/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2013, 11:04 p.m.)
>
>
> Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin.
>
>
> Description
> -------
>
> Actually was wrong, we do get the signals from QDesktopWidget - so the fix is \
> pretty trivial ;-)
> Reg. bug #313835 i assume you're using some plasma screenlocker with widgets on it \
> (which has a translucent background when compositing is active and relies on the \
> lockwindow to cover the screen)
> I've not checked such screen"saver" and have to admit, i'd not even know where to \
> check for the sources.
>
> This addresses bug 313835.
> http://bugs.kde.org/show_bug.cgi?id=313835
>
>
> Diffs
> -----
>
> ksmserver/screenlocker/lockwindow.h 5cbc769
> ksmserver/screenlocker/lockwindow.cpp 147853b
>
> Diff: http://git.reviewboard.kde.org/r/108585/diff/
>
>
> Testing
> -------
>
> recompiled _all_ ksmserver, logged out, in, locked the screen, updated the screen \
> geometry ("arrrgghhh... geeezzz... goddamnfuckinghdmiinthedark"), killed the \
> gretter (noticed that i could have simply xrandr'd the geometry from VT1 as well - \
> "blast!")
> everything is nicely black (with compositing)
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108585/">http://git.reviewboard.kde.org/r/108585/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this still does not work \
p[roperly. now i'm getting a (too small) black rectangle on the screen around \
which i can see the rest of my desktop and the locker window is still not being \
shown. investigating now.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108585/diff/1/?file=109225#file109225line120" \
style="color: black; font-weight: bold; text-decoration: \
underline;">ksmserver/screenlocker/lockwindow.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
LockWindow::initialize()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">120</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="n">connect</span><span class="p">(</span><span \
class="n">QApplication</span><span class="o">::</span><span \
class="n">desktop</span><span class="p">(),</span> <span class="n">SIGNAL</span><span \
class="p">(</span><span class="n">resized</span><span class="p">(</span><span \
class="kt">int</span><span class="p">)),</span> <span class="n">SLOT</span><span \
class="p">(</span><span class="n">fixGeometry</span><span \
class="p">()));</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">121</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="n">connect</span><span class="p">(</span><span \
class="n">QApplication</span><span class="o">::</span><span \
class="n">desktop</span><span class="p">(),</span> <span class="n">SIGNAL</span><span \
class="p">(</span><span class="n">screenCountChanged</span><span \
class="p">(</span><span class="kt">int</span><span class="p">)),</span> <span \
class="n">SLOT</span><span class="p">(</span><span class="n">fixGeometry</span><span \
class="p">()));</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">spaces, not \
tabs.</pre> </div>
<br />
<p>- Aaron J.</p>
<br />
<p>On January 25th, 2013, 11:04 p.m. UTC, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Jan. 25, 2013, 11:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Actually was wrong, we do get the signals from QDesktopWidget - so the \
fix is pretty trivial ;-)
Reg. bug #313835 i assume you're using some plasma screenlocker with widgets on \
it (which has a translucent background when compositing is active and relies on the \
lockwindow to cover the screen)
I've not checked such screen"saver" and have to admit, i'd not even \
know where to check for the sources.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">recompiled _all_ ksmserver, logged out, in, locked the screen, updated \
the screen geometry ("arrrgghhh... geeezzz... \
goddamnfuckinghdmiinthedark"), killed the gretter (noticed that i could have \
simply xrandr'd the geometry from VT1 as well - "blast!")
everything is nicely black (with compositing)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=313835">313835</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/lockwindow.h <span style="color: \
grey">(5cbc769)</span></li>
<li>ksmserver/screenlocker/lockwindow.cpp <span style="color: \
grey">(147853b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108585/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic