[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 108438: Use translucent/dialogs/background elements where possible
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2013-01-23 14:51:15
Message-ID: 20130123145115.32375.11452 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 17, 2013, 3:40 p.m., Thomas Lübking wrote:
> > file:///usr/share/apps/kwin/tabbox/thumbnails/contents/ui/main.qml:139:9: QML \
> > Image: Failed to get image from provider: image://client/-1/1227386822-0 \
> > file:///usr/share/apps/kwin/tabbox/thumbnails/contents/ui/main.qml:35: \
> > ReferenceError: Can't find variable: compositing \
> > file:///usr/share/apps/kwin/tabbox/thumbnails/contents/ui/ShadowedSvgItem.qml:36: \
> > ReferenceError: Can't find variable: compositing
> > And many themes somehow seem to use the air dialog background (as fallback \
> > because they don't have an explicit ARGB path?)
>
> Martin Gräßlin wrote:
> where did you get these errors? Is that the preview in the KCM?
>
> Thomas Lübking wrote:
> Nope, on activating the tabbox inside kwin (tried "kwin --replace &" since it's \
> always a good idea when qml does not act as expected)
> Thomas Lübking wrote:
> PS: only on first invocation (maybe init problem of the compositing variable) and \
> there're no notable visual defects except that most themes are now Air (the blurred \
> variant, regardless of blurring)
Did you check non-air themes?
If this isn't a completely local phenomenon and there's no way to determine whether \
there's actually some translucent/* path and which is the correct for the current \
blur situation i'd propose that for KWin only (but without actually checking that) \
plasma could
a) connect to a compositingChanged(bool) signal from the application (from where we'd \
emit it)
-- only works for kwin
b) establish a selectionwatcher instead of or in addition to connecting to the \
KWindowSystem signal (works "instead" with others and kwin as long as the eventloop \
is up when creating the watcher)
Personal preference:
No fix < KWin QML path fix* < KWin signal fix < SelectionWatcher fix < Fix-a-round \
KWindowSystem < Fix Qt But the last two are no (more) option in 4.10 scope
*Only if it works - if KWin is the only plasma client effectively force-using Air, \
that's gonna cause us a bazillion of bug reports ;-)
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108438/#review25719
-----------------------------------------------------------
On Jan. 23, 2013, 1:47 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108438/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2013, 1:47 p.m.)
>
>
> Review request for kwin, Sebastian Kügler and Xuetian Weng.
>
>
> Description
> -------
>
> Use translucent/dialogs/background elements where possible
>
> In effects it's obvious that compositing is enabled, so specifying the
> translucent element is no problem.
>
> In tabbox a context property "compositing" is injected which decides
> whether "translucent" or "opaque" elements should be used.
>
> Also the masking is adjusted to ensure that only the shadow is not
> blurred.
>
> Reason for this change is that Plasma theme seems not always to pick up
> whether compositing is used when used from inside KWin. It does not cover
> the Desktop Change OSD which uses PlasmaCore.Dialog and there we cannot
> (yet) inject that we use compositing.
>
> CCBUG: 311995
>
>
> Diffs
> -----
>
> kwin/effects/desktopgrid/desktopgrid.cpp 53532ccff72d2a1f303265a898fd7b1fc7ea35a6
> kwin/effects/presentwindows/presentwindows.cpp \
> 100d5ec0ab80b50d8b3d0b68d11bc08f55da15ca kwin/tabbox/declarative.cpp \
> b4d615178a0e0b8b633626a1813dfa7065515b97 kwin/tabbox/qml/CMakeLists.txt \
> bda7d8b95ed3b4fb4093c9960f940a0d678710f8 kwin/tabbox/qml/ShadowedSvgItem.qml \
> 87de733bf0fa1ad19d4d9203de6c6fc3548ff57f \
> kwin/tabbox/qml/clients/big_icons/contents/ui/main.qml \
> 4a3666d2befe0010f7d9b7d4414853e8c92a92a1 \
> kwin/tabbox/qml/clients/compact/contents/ui/main.qml \
> 14fca297c40a8338de1fff413f7e4b5b0a4aef45 \
> kwin/tabbox/qml/clients/informative/contents/ui/main.qml \
> 5e3f9a6f2ad76e7eeb7ee1e51d42e0c891b762ec \
> kwin/tabbox/qml/clients/present_windows/contents/ui/main.qml \
> e539c8970acff701b92bdaaf816a40ccba94e4b8 \
> kwin/tabbox/qml/clients/small_icons/contents/ui/main.qml \
> 0c9b4f7f7df52f8a629d0c847185db38aa9f2c26 \
> kwin/tabbox/qml/clients/text/contents/ui/main.qml \
> ccae17d96b231269a7d8ec0ecc20b0ee69453d09 \
> kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml \
> 4c33703d54c84fd54da94f821234e4cbd9c1c001 kwin/tabbox/qml/desktop.qml \
> e8203b6004a321fcc5ae6d10347fdbb7144662a7
> Diff: http://git.reviewboard.kde.org/r/108438/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108438/">http://git.reviewboard.kde.org/r/108438/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 17th, 2013, 3:40 p.m. UTC, <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">file:///usr/share/apps/kwin/tabbox/thumbnails/contents/ui/main.qml:139:9: \
QML Image: Failed to get image from provider: image://client/-1/1227386822-0 \
file:///usr/share/apps/kwin/tabbox/thumbnails/contents/ui/main.qml:35: \
ReferenceError: Can't find variable: compositing \
file:///usr/share/apps/kwin/tabbox/thumbnails/contents/ui/ShadowedSvgItem.qml:36: \
ReferenceError: Can't find variable: compositing
And many themes somehow seem to use the air dialog background (as fallback because \
they don't have an explicit ARGB path?)</pre> </blockquote>
<p>On January 17th, 2013, 4:20 p.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">where did you get these \
errors? Is that the preview in the KCM?</pre> </blockquote>
<p>On January 17th, 2013, 5:02 p.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nope, on activating the \
tabbox inside kwin (tried "kwin --replace &" since it's always a \
good idea when qml does not act as expected)</pre> </blockquote>
<p>On January 17th, 2013, 7:30 p.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">PS: only on first \
invocation (maybe init problem of the compositing variable) and there're no \
notable visual defects except that most themes are now Air (the blurred variant, \
regardless of blurring)</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Did you check non-air \
themes?
If this isn't a completely local phenomenon and there's no way to determine \
whether there's actually some translucent/* path and which is the correct for the \
current blur situation i'd propose that for KWin only (but without actually \
checking that) plasma could
a) connect to a compositingChanged(bool) signal from the application (from where \
we'd emit it)
-- only works for kwin
b) establish a selectionwatcher instead of or in addition to connecting to the \
KWindowSystem signal (works "instead" with others and kwin as long as the \
eventloop is up when creating the watcher)
Personal preference:
No fix < KWin QML path fix* < KWin signal fix < SelectionWatcher fix < \
Fix-a-round KWindowSystem < Fix Qt But the last two are no (more) option in 4.10 \
scope
*Only if it works - if KWin is the only plasma client effectively force-using Air, \
that's gonna cause us a bazillion of bug reports ;-)</pre> <br />
<p>- Thomas</p>
<br />
<p>On January 23rd, 2013, 1:47 p.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Sebastian Kügler and Xuetian Weng.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Jan. 23, 2013, 1:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use translucent/dialogs/background elements where possible
In effects it's obvious that compositing is enabled, so specifying the
translucent element is no problem.
In tabbox a context property "compositing" is injected which decides
whether "translucent" or "opaque" elements should be used.
Also the masking is adjusted to ensure that only the shadow is not
blurred.
Reason for this change is that Plasma theme seems not always to pick up
whether compositing is used when used from inside KWin. It does not cover
the Desktop Change OSD which uses PlasmaCore.Dialog and there we cannot
(yet) inject that we use compositing.
CCBUG: 311995</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/desktopgrid/desktopgrid.cpp <span style="color: \
grey">(53532ccff72d2a1f303265a898fd7b1fc7ea35a6)</span></li>
<li>kwin/effects/presentwindows/presentwindows.cpp <span style="color: \
grey">(100d5ec0ab80b50d8b3d0b68d11bc08f55da15ca)</span></li>
<li>kwin/tabbox/declarative.cpp <span style="color: \
grey">(b4d615178a0e0b8b633626a1813dfa7065515b97)</span></li>
<li>kwin/tabbox/qml/CMakeLists.txt <span style="color: \
grey">(bda7d8b95ed3b4fb4093c9960f940a0d678710f8)</span></li>
<li>kwin/tabbox/qml/ShadowedSvgItem.qml <span style="color: \
grey">(87de733bf0fa1ad19d4d9203de6c6fc3548ff57f)</span></li>
<li>kwin/tabbox/qml/clients/big_icons/contents/ui/main.qml <span style="color: \
grey">(4a3666d2befe0010f7d9b7d4414853e8c92a92a1)</span></li>
<li>kwin/tabbox/qml/clients/compact/contents/ui/main.qml <span style="color: \
grey">(14fca297c40a8338de1fff413f7e4b5b0a4aef45)</span></li>
<li>kwin/tabbox/qml/clients/informative/contents/ui/main.qml <span style="color: \
grey">(5e3f9a6f2ad76e7eeb7ee1e51d42e0c891b762ec)</span></li>
<li>kwin/tabbox/qml/clients/present_windows/contents/ui/main.qml <span style="color: \
grey">(e539c8970acff701b92bdaaf816a40ccba94e4b8)</span></li>
<li>kwin/tabbox/qml/clients/small_icons/contents/ui/main.qml <span style="color: \
grey">(0c9b4f7f7df52f8a629d0c847185db38aa9f2c26)</span></li>
<li>kwin/tabbox/qml/clients/text/contents/ui/main.qml <span style="color: \
grey">(ccae17d96b231269a7d8ec0ecc20b0ee69453d09)</span></li>
<li>kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml <span style="color: \
grey">(4c33703d54c84fd54da94f821234e4cbd9c1c001)</span></li>
<li>kwin/tabbox/qml/desktop.qml <span style="color: \
grey">(e8203b6004a321fcc5ae6d10347fdbb7144662a7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108438/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic