'Re: Review Request: Port ScreenEdge::raisePanelProxies to xcb'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Port ScreenEdge::raisePanelProxies to xcb
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2013-01-11 14:23:46
Message-ID: 20130111142346.6385.4436 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108346/
-----------------------------------------------------------

(Updated Jan. 11, 2013, 2:23 p.m.)

Review request for kwin and Fredrik H=C3=B6glund.

Changes
-------

fixed the wrong array access, but kept the loops as they are, because one c=
heck uses both attributes and geometry

Description
-------

Port ScreenEdge::raisePanelProxies to xcb

The present windows effect showed some extreme slowness on deactivation.
Investigation showed that it is caused by ScreenEdge::raisePanelProxies
which takes up to 500 msec. By making this method async the problem goes
away.

As this is targetted for the 4.10 branch it doesn't use the wrappers.

Diffs (updated)
-----

  kwin/screenedge.cpp a1507c3543877477e564bba368feaa31bc44655e =

Diff: http://git.reviewboard.kde.org/r/108346/diff/

Testing
-------

Thanks,

Martin Gr=C3=A4=C3=9Flin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108346/">http://git.reviewboard.kde.org/r/108346/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Fredrik Höglund.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Jan. 11, 2013, 2:23 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">fixed the wrong array access, but kept the loops as they are, because \
one check uses both attributes and geometry</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Port ScreenEdge::raisePanelProxies to xcb

The present windows effect showed some extreme slowness on deactivation.
Investigation showed that it is caused by ScreenEdge::raisePanelProxies
which takes up to 500 msec. By making this method async the problem goes
away.

As this is targetted for the 4.10 branch it doesn&#39;t use the wrappers.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/screenedge.cpp <span style="color: \
grey">(a1507c3543877477e564bba368feaa31bc44655e)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108346/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 