[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Check max viewport and texture dimensions for glViewport
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2013-01-10 8:05:46
Message-ID: 20130110080546.24577.96875 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106917/#review25139
-----------------------------------------------------------
kwin/scene_opengl.cpp
<http://git.reviewboard.kde.org/r/106917/#comment19226>
I would remove the "Sorry"
kwin/scene_opengl.cpp
<http://git.reviewboard.kde.org/r/106917/#comment19224>
isServiceRegistered() is not doing a synced call to D-Bus or performing=
some introspection?
kwin/scene_opengl.cpp
<http://git.reviewboard.kde.org/r/106917/#comment19225>
where does it depend on KMessageBox?
- Martin Gr=C3=A4=C3=9Flin
On Nov. 10, 2012, 5:25 p.m., Thomas L=C3=BCbking wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106917/
> -----------------------------------------------------------
> =
> (Updated Nov. 10, 2012, 5:25 p.m.)
> =
> =
> Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
> =
> =
> Description
> -------
> =
> The patch checks
> 1. whether the requested dimension is beyond the propagated viewport capa=
bilities (and in case toggles compositing with a sorry)
> 2. Because recently MESA is a bit enthusiastic about the capabilities, al=
so whether the requested dimension is beyond the propagated texture capabil=
ities (and in case informs the user that this could or will lead to trouble=
, think of "maximized" windows)
> =
> =
> Diffs
> -----
> =
> kwin/kcmkwin/kwincompositing/dbus.h PRE-CREATION =
> kwin/kcmkwin/kwincompositing/main.h 35079c3 =
> kwin/kcmkwin/kwincompositing/main.cpp 84a2895 =
> kwin/scene_opengl.h 57d99ec =
> kwin/scene_opengl.cpp 4792c11 =
> =
> Diff: http://git.reviewboard.kde.org/r/106917/diff/
> =
> =
> Testing
> -------
> =
> Constrained the limits to "5" and either dropped out of compositing with =
the dialog or got the information dialog. "Do not show again" works as well=
. Dialog code is largely stolen from useractions.cpp.
> =
> =
> Thanks,
> =
> Thomas L=C3=BCbking
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106917/">http://git.reviewboard.kde.org/r/106917/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106917/diff/3/?file=94575#file94575line459" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/scene_opengl.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">bool SceneOpenGL::vieportLimitsMatched(const QSize &size) const {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">459</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="s">"restrict the OpenGL viewport \
size.<br>Sorry."</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would \
remove the "Sorry"</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106917/diff/3/?file=94575#file94575line460" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/scene_opengl.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">bool SceneOpenGL::vieportLimitsMatched(const QSize &size) const {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">460</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span \
class="n">QDBusConnection</span><span class="o">::</span><span \
class="n">sessionBus</span><span class="p">().</span><span \
class="n">interface</span><span class="p">()</span><span class="o">-></span><span \
class="n">isServiceRegistered</span><span class="p">(</span><span \
class="s">"org.kde.kwinCompositingDialog"</span><span \
class="p">).</span><span class="n">value</span><span class="p">())</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">isServiceRegistered() is not doing a synced call to D-Bus or performing \
some introspection?</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106917/diff/3/?file=94575#file94575line473" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/scene_opengl.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">bool SceneOpenGL::vieportLimitsMatched(const QSize &size) const {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">473</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">// Depends on KMessageBox</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">where does \
it depend on KMessageBox?</pre> </div>
<br />
<p>- Martin</p>
<br />
<p>On November 10th, 2012, 5:25 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Nov. 10, 2012, 5:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The patch checks 1. whether the requested dimension is beyond the \
propagated viewport capabilities (and in case toggles compositing with a sorry) 2. \
Because recently MESA is a bit enthusiastic about the capabilities, also whether the \
requested dimension is beyond the propagated texture capabilities (and in case \
informs the user that this could or will lead to trouble, think of \
"maximized" windows)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Constrained the limits to "5" and either dropped out of \
compositing with the dialog or got the information dialog. "Do not show \
again" works as well. Dialog code is largely stolen from useractions.cpp.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/kcmkwin/kwincompositing/dbus.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/kcmkwin/kwincompositing/main.h <span style="color: \
grey">(35079c3)</span></li>
<li>kwin/kcmkwin/kwincompositing/main.cpp <span style="color: \
grey">(84a2895)</span></li>
<li>kwin/scene_opengl.h <span style="color: grey">(57d99ec)</span></li>
<li>kwin/scene_opengl.cpp <span style="color: grey">(4792c11)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106917/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic