'Re: Review Request: Use defaults as specified in KWin::Options for FFM delay'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Use defaults as specified in KWin::Options for FFM delay
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2013-01-10 6:48:35
Message-ID: 20130110064835.13649.95909 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On Jan. 10, 2013, 1:16 a.m., Thomas L=C3=BCbking wrote:
> > I'd frankly suggest to adjust the defaults with this to a friendly "mea=
n" value of ~300ms.

we can do that - I use 300 for delay and 750 for raise delay (huge value as=
 I'm using a trackball and sometimes miss borders when scrolling ;-). So fo=
r me 300 msec sounds like a good default.

- Martin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108288/#review25115
-----------------------------------------------------------

On Jan. 9, 2013, 8:15 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108288/
> -----------------------------------------------------------
> =

> (Updated Jan. 9, 2013, 8:15 a.m.)
> =

> =

> Review request for kwin.
> =

> =

> Description
> -------
> =

> Use defaults as specified in KWin::Options for FFM delay
> =

> Caused incorrect defaults getting stored when FFM gets activated for
> the first time.
> =

> A small reminder that we should migrate to KConfigXT for all config
> options.
> =

> =

> Diffs
> -----
> =

>   kwin/kcmkwin/kwinoptions/windows.cpp 0c8d450cf4816bc55ddb03aa47d9001b4f=
418114 =

> =

> Diff: http://git.reviewboard.kde.org/r/108288/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Martin Gr=C3=A4=C3=9Flin
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108288/">http://git.reviewboard.kde.org/r/108288/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On January 10th, 2013, 1:16 a.m., <b>Thomas \
Lübking</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I&#39;d frankly suggest to adjust the defaults with this to a friendly \
&quot;mean&quot; value of ~300ms.</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">we can do that - I use \
300 for delay and 750 for raise delay (huge value as I&#39;m using a trackball and \
sometimes miss borders when scrolling ;-). So for me 300 msec sounds like a good \
default.</pre> <br />

<p>- Martin</p>

<br />
<p>On January 9th, 2013, 8:15 a.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Jan. 9, 2013, 8:15 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use defaults as specified in KWin::Options for FFM delay

Caused incorrect defaults getting stored when FFM gets activated for
the first time.

A small reminder that we should migrate to KConfigXT for all config
options.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/kcmkwin/kwinoptions/windows.cpp <span style="color: \
grey">(0c8d450cf4816bc55ddb03aa47d9001b4f418114)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108288/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 