[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Do not clip away shadows in SlidingPopupsEffect
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2013-01-09 11:11:26
Message-ID: 20130109111126.16391.30653 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 9, 2013, 8:52 a.m., Kai Uwe Broulik wrote:
> > Tested and works perfect except for that 1px overlapping shadow issue I mentioned \
> > earlier but it now only appears in the last bits of the sliding out animation, \
> > and in the first bits of the sliding back in animation.
>
> Martin Gräßlin wrote:
> I did not see that one at all. You only tested with XRender, right? Because I only \
> tested with OpenGL.
> Kai Uwe Broulik wrote:
> Tested with OpenGL1 now. Worked fine.
so probably an unrelated issue in the XRender shadow rendering code path.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108255/#review25030
-----------------------------------------------------------
On Jan. 9, 2013, 7:08 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108255/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2013, 7:08 a.m.)
>
>
> Review request for kwin and Plasma.
>
>
> Description
> -------
>
> Do not clip away shadows in SlidingPopupsEffect
>
> Animation now completely based on the expandedGeometry which includes the
> shadows and another repaint at the end of the animation is added to
> ensure that there are no leftover shadows.
>
> BUG: 312168
> FIXED-IN: 4.10
> REVIEW: 108255
>
>
> This addresses bug 312168.
> http://bugs.kde.org/show_bug.cgi?id=312168
>
>
> Diffs
> -----
>
> kwin/effects/slidingpopups/slidingpopups.cpp \
> 5ffc56b392a833127a6f22a60c2da10ae50f4c06
> Diff: http://git.reviewboard.kde.org/r/108255/diff/
>
>
> Testing
> -------
>
> I did some testing, but I would appreciate if a few more people could try the patch \
> and watch for rendering glitches. Sliding Popups has shown a huge regression \
> potential in the past, so we have to be extremely careful if we want the patch in \
> 4.10
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108255/">http://git.reviewboard.kde.org/r/108255/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 9th, 2013, 8:52 a.m., <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested and works perfect except for that 1px overlapping shadow issue I \
mentioned earlier but it now only appears in the last bits of the sliding out \
animation, and in the first bits of the sliding back in animation.</pre> \
</blockquote>
<p>On January 9th, 2013, 9:40 a.m., <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I did not see that one \
at all. You only tested with XRender, right? Because I only tested with OpenGL.</pre> \
</blockquote>
<p>On January 9th, 2013, 9:44 a.m., <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with OpenGL1 now. \
Worked fine.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">so probably an unrelated \
issue in the XRender shadow rendering code path.</pre> <br />
<p>- Martin</p>
<br />
<p>On January 9th, 2013, 7:08 a.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Jan. 9, 2013, 7:08 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Do not clip away shadows in SlidingPopupsEffect
Animation now completely based on the expandedGeometry which includes the
shadows and another repaint at the end of the animation is added to
ensure that there are no leftover shadows.
BUG: 312168
FIXED-IN: 4.10
REVIEW: 108255</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I did some testing, but I would appreciate if a few more people could \
try the patch and watch for rendering glitches. Sliding Popups has shown a huge \
regression potential in the past, so we have to be extremely careful if we want the \
patch in 4.10</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=312168">312168</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/slidingpopups/slidingpopups.cpp <span style="color: \
grey">(5ffc56b392a833127a6f22a60c2da10ae50f4c06)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108255/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic