'Re: Review Request: don't use input windows on 4.8.1'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: don't use input windows on 4.8.1
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2013-01-07 22:11:31
Message-ID: 20130107221131.30281.64314 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108249/#review24950
-----------------------------------------------------------

Ship it!

*sniff* now I cannot use it any more

- Martin Gräßlin

On Jan. 7, 2013, 8:26 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108249/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2013, 8:26 p.m.)
> 
> 
> Review request for kwin, Martin Gräßlin and Hugo Pereira Da Costa.
> 
> 
> Description
> -------
> 
> According to aacid, it's been broken in every Qt version before
> 
> @Hugo
> this prevents invisible resize borders on the core.
> If you need special handling in the config GUI, that's not covered.
> 
> 
> This addresses bug 312784.
>     http://bugs.kde.org/show_bug.cgi?id=312784
> 
> 
> Diffs
> -----
> 
>   kwin/client.cpp 43296b3 
> 
> Diff: http://git.reviewboard.kde.org/r/108249/diff/
> 
> 
> Testing
> -------
> 
> Compiles, get's me blind resize borders ... unless i raise the last number
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108249/">http://git.reviewboard.kde.org/r/108249/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">*sniff* now I cannot use \
it any more</pre>  <br />

<p>- Martin</p>

<br />
<p>On January 7th, 2013, 8:26 p.m., Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Martin Gräßlin and Hugo Pereira Da Costa.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Jan. 7, 2013, 8:26 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">According to aacid, it&#39;s been broken in every Qt version before

@Hugo
this prevents invisible resize borders on the core.
If you need special handling in the config GUI, that&#39;s not covered.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles, get&#39;s me blind resize borders ... unless i raise the last \
number</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=312784">312784</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/client.cpp <span style="color: grey">(43296b3)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108249/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 