[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Use XCB to resolve the X11 Extensions
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2013-01-07 11:08:30
Message-ID: 20130107110830.11310.4595 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107832/
-----------------------------------------------------------
(Updated Jan. 7, 2013, 11:08 a.m.)
Review request for kwin and Fredrik H=C3=B6glund.
Changes
-------
moved into xcbutils.h
Description (updated)
-------
Use XCB to resolve the X11 Extensions
The extension handling is removed from kwinglobals and moved into the
xcbutils in KWin core in namespace KWin::Xcb. The motivation for this
change is that the Extensions are only used in KWin core and are marked
as internal. So there is no need to have them in the library.
What remains in Extensions are the non-native pixmaps. This will be
removed once we are on Qt 5 as QPixmap can no longer reference an XPixmap.
The remaining code in kwinglobals also still initialize the XLib versions
of extensions emitting events. It seems like there are no XEvents emitted
if not done so even if the extension is correctly initialized with xcb.
This needs to be removed once the event handling is ported over to xcb.
Diffs (updated)
-----
kwin/CMakeLists.txt fbdf139dedfc31f43c3de10081700bc56ab07759 =
kwin/client.cpp eb082fad5996738a2afb8fb1a166923c16df1795 =
kwin/compositingprefs.cpp ea6cb2b5078a401d6f760a8a9bd38ec4cd0a43da =
kwin/events.cpp 89d3e2ceb9ffdc3a40a73a77b9014e9db2d8626c =
kwin/libkwineffects/CMakeLists.txt d10a3e72f324c6efd7fa3ee63ca1f9983e893a=
45 =
kwin/libkwineffects/kwinglobals.h b1b789630fcf258c618fe280bc4754f0319aa2a=
8 =
kwin/libkwineffects/kwinglobals.cpp b27d4a98fc03a256cc5ba96e7c58829344708=
847 =
kwin/manage.cpp c06071329f1c12be6a727e635049848fd1d1bd14 =
kwin/options.cpp 2670de75ac408d16f59ce3dfed0e6b94ee8f39f9 =
kwin/overlaywindow.cpp d6359c7829dee6f70babc4585b61dcae521be3ea =
kwin/scene_xrender.cpp 2a976ad40744972f9debb89350c8471013d18fc5 =
kwin/toplevel.cpp 6c718100c058450813ebff034bd6a3560985bde2 =
kwin/unmanaged.cpp 38826a547ef325593784f2c62f6dd56898648978 =
kwin/workspace.cpp 07e65ae49589230a9813a1f4ec7a230f77dc9d39 =
kwin/xcbutils.h ebe7c283c1704328337ce56402999f98e57dffed =
kwin/xcbutils.cpp PRE-CREATION =
Diff: http://git.reviewboard.kde.org/r/107832/diff/
Testing
-------
Thanks,
Martin Gr=C3=A4=C3=9Flin
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107832/">http://git.reviewboard.kde.org/r/107832/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Fredrik Höglund.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Jan. 7, 2013, 11:08 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">moved into xcbutils.h</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use XCB to resolve the X11 Extensions
The extension handling is removed from kwinglobals and moved into the
xcbutils in KWin core in namespace KWin::Xcb. The motivation for this
change is that the Extensions are only used in KWin core and are marked
as internal. So there is no need to have them in the library.
What remains in Extensions are the non-native pixmaps. This will be
removed once we are on Qt 5 as QPixmap can no longer reference an XPixmap.
The remaining code in kwinglobals also still initialize the XLib versions
of extensions emitting events. It seems like there are no XEvents emitted
if not done so even if the extension is correctly initialized with xcb.
This needs to be removed once the event handling is ported over to xcb.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/CMakeLists.txt <span style="color: \
grey">(fbdf139dedfc31f43c3de10081700bc56ab07759)</span></li>
<li>kwin/client.cpp <span style="color: \
grey">(eb082fad5996738a2afb8fb1a166923c16df1795)</span></li>
<li>kwin/compositingprefs.cpp <span style="color: \
grey">(ea6cb2b5078a401d6f760a8a9bd38ec4cd0a43da)</span></li>
<li>kwin/events.cpp <span style="color: \
grey">(89d3e2ceb9ffdc3a40a73a77b9014e9db2d8626c)</span></li>
<li>kwin/libkwineffects/CMakeLists.txt <span style="color: \
grey">(d10a3e72f324c6efd7fa3ee63ca1f9983e893a45)</span></li>
<li>kwin/libkwineffects/kwinglobals.h <span style="color: \
grey">(b1b789630fcf258c618fe280bc4754f0319aa2a8)</span></li>
<li>kwin/libkwineffects/kwinglobals.cpp <span style="color: \
grey">(b27d4a98fc03a256cc5ba96e7c58829344708847)</span></li>
<li>kwin/manage.cpp <span style="color: \
grey">(c06071329f1c12be6a727e635049848fd1d1bd14)</span></li>
<li>kwin/options.cpp <span style="color: \
grey">(2670de75ac408d16f59ce3dfed0e6b94ee8f39f9)</span></li>
<li>kwin/overlaywindow.cpp <span style="color: \
grey">(d6359c7829dee6f70babc4585b61dcae521be3ea)</span></li>
<li>kwin/scene_xrender.cpp <span style="color: \
grey">(2a976ad40744972f9debb89350c8471013d18fc5)</span></li>
<li>kwin/toplevel.cpp <span style="color: \
grey">(6c718100c058450813ebff034bd6a3560985bde2)</span></li>
<li>kwin/unmanaged.cpp <span style="color: \
grey">(38826a547ef325593784f2c62f6dd56898648978)</span></li>
<li>kwin/workspace.cpp <span style="color: \
grey">(07e65ae49589230a9813a1f4ec7a230f77dc9d39)</span></li>
<li>kwin/xcbutils.h <span style="color: \
grey">(ebe7c283c1704328337ce56402999f98e57dffed)</span></li>
<li>kwin/xcbutils.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107832/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic