--===============3606695424778433322== Content-Type: multipart/alternative; boundary="===============2150026052853122536==" --===============2150026052853122536== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Jan. 3, 2013, 5:09 p.m., Martin Gr=C3=A4=C3=9Flin wrote: > > If nobody complains I'm going to push this branch on Monday morning heretic thought: if VDManager wasn't a singleton, one could offer different= implementations and by this have a Desktop stack and a panning canvas and = ... different behaviors? - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107493/#review24590 ----------------------------------------------------------- On Jan. 3, 2013, 5:06 p.m., Martin Gr=C3=A4=C3=9Flin wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107493/ > ----------------------------------------------------------- > = > (Updated Jan. 3, 2013, 5:06 p.m.) > = > = > Review request for kwin. > = > = > Description > ------- > = > Move ScreenEdge configuration from Workspace to ScreenEdge > = > Main motivation for this change except the fact that it doesn't belong > into Workspace is that the screen edges got updated from within setting > the desktop layout which got removed with the introduction of the > VirtualDesktopManager. > = > The ScreenEdge now keeps some state to be able to correctly unreserve the > electric borders when changes in the configuration are performed. There > is still room for improvement as there are still some deep function calls > from within reconfiguring in Workspace. > = > Move Desktop Chain management from Workspace into own class > = > Most recently used virtual desktop chain is only used in the context of > TabBox and therefore moved into this namespace. KWin uses one desktop > chain for each activity. This is mapped by having multiple DesktopChains. > In addition there is a DesktopChainManager which contains all those > chains which are identified by a QString. > = > The manager gets connected to the signals emitted by VirtualDesktopManager > for changes in virtual desktops and to signals related to Activities > emitted by Workspace. This means the manager is rather generic as it does > not depend on any other components. > = > Move handling of Virtual Desktops into a VirtualDesktopManager > = > The ownership for virtual desktops is moved from Workspace into a new > VirtualDesktopManager. The manager is responsible for providing the count > of virtual desktops and keeping track of the currently used virtual > desktop. > = > All methods related to moving between desktops are also moved from > Workspace to the new manager, though all methods related to Clients on > Virtual Desktops remain in Workspace for the time being. This is to have > the new manager as independent from KWin core as possible. > = > An rather important change for the handling of virtual desktops is that > the count and the id of a desktop is now an unsinged integer instead of > an integer. The reason for that is that we cannot have a negative count > of desktops as well as it is not possible to be on a desktop with a > negative identifier. > = > In that regard it is important to remember that a Client can be on a > desktop with a negative identifier. The special value for a Client being > on all desktops is handled by using -1 as a desktop. For the time being > this is not adjusted but instead of comparing the virtual desktop ids one > should prefer to use the convenient methods like isOnDesktop and > isOnAllDesktops. This would allow in future to internally change the > representation for on all desktops. > = > = > Diffs > ----- > = > kwin/CMakeLists.txt 62e9964a60783456dd11958f7a105e9d4df110c2 = > kwin/activation.cpp a3c050cd5fab02e9a21d58c9e5fb93995332a309 = > kwin/bridge.cpp d54f0592870ddad0cf611b2f407db9716d40c862 = > kwin/client.cpp 43296b3a062df556a1c8d6e4a4a5da42d9c05c35 = > kwin/composite.cpp a19eccd64860ac8fcec2f4ec2a3b70be03c0378a = > kwin/dbusinterface.cpp abee120e8f086b6cb9241902ce36aeb015509f6b = > kwin/desktoplayout.cpp f275782e9e98cf13ae1d764d1c7edb2e97d07036 = > kwin/effects.cpp eaab46ff32f2b5aad5a1d5f0bebe5c62854a75ec = > kwin/effects/desktopgrid/desktopgrid.h f968fc18354f4c1d5cd3c9050afceee7= 7cdac151 = > kwin/effects/desktopgrid/desktopgrid.cpp 53532ccff72d2a1f303265a898fd7b= 1fc7ea35a6 = > kwin/events.cpp 281f9e708d4488c504b8fc5eba3de5757a59c915 = > kwin/geometry.cpp 00471655237ebb0edfa1b3201cf0196edaba301f = > kwin/kwinbindings.cpp b6fb09b8a0be114bff9dd9803f9943fbc6505649 = > kwin/layers.cpp 5104e19d1df83c897e25872d64f27aff556996e8 = > kwin/libkwineffects/kwineffects.h aa5d9e8b67c60b158e7ffb08dfcf3e8d2a16d= cd7 = > kwin/manage.cpp bda9821f2d235384ce062f1cfbbc9e53a2689f0f = > kwin/options.h 87917f917a420ab0b073a61372ef4e56ce7d4936 = > kwin/options.cpp a49ff922c24e1c56c704874a05288f98b20c6540 = > kwin/placement.cpp ff75e6cc1ca3cb7037c2bd8ea00a8e263eedc688 = > kwin/screenedge.h b2cda7b545ed37e8feef41b9403b983f469cf3bb = > kwin/screenedge.cpp a1507c3543877477e564bba368feaa31bc44655e = > kwin/scripting/workspace_wrapper.h 56648ef272f32c8d2b69d0fe4d394ac4d223= 2ba9 = > kwin/scripting/workspace_wrapper.cpp 0fdfcc576ffa2cf925b6e5c89368bdac8c= 02a59b = > kwin/sm.cpp c6350d162dc1a5168cacdeeadd62bb6329b266af = > kwin/tabbox/desktopchain.h PRE-CREATION = > kwin/tabbox/desktopchain.cpp PRE-CREATION = > kwin/tabbox/tabbox.h 73d83df406af103e71144cbd6499c78b5f118177 = > kwin/tabbox/tabbox.cpp 825a4a70d29f3b10b89d33ec042b2ad79108c871 = > kwin/tabbox/tests/CMakeLists.txt 9b40836350d2a6fc22839d1bf6e04589740ad3= 99 = > kwin/tabbox/tests/test_desktopchain.cpp PRE-CREATION = > kwin/tests/CMakeLists.txt 8bb2b47539d574bcabd78e372b5511b766fe1d15 = > kwin/tests/test_virtual_desktops.cpp PRE-CREATION = > kwin/toplevel.h 869da563615860311dac1e1283acc9fe2a35221b = > kwin/useractions.cpp 3617d2938cfd2483a0fb7591ffbce102db482b61 = > kwin/virtualdesktops.h PRE-CREATION = > kwin/virtualdesktops.cpp PRE-CREATION = > kwin/workspace.h 3efc240177b0423576c0d31295c510bcc216482c = > kwin/workspace.cpp df0b043cd3d10c6da6e321555d3b413d60269bde = > = > Diff: http://git.reviewboard.kde.org/r/107493/diff/ > = > = > Testing > ------- > = > works fine so far, but not yet tested in detail. I plan to add some unit = tests at least for the VirtualDesktopManager - let's see how bored I am tom= orrow during the flight and how long the battery lasts ;-) > = > = > Thanks, > = > Martin Gr=C3=A4=C3=9Flin > = > --===============2150026052853122536== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107493/ |
On January 3rd, 2013, 5:09 p.m., Martin Gr= =C3=A4=C3=9Flin wrote:
If nobody= complains I'm going to push this branch on Monday morning
heretic tho= ught: if VDManager wasn't a singleton, one could offer different implem= entations and by this have a Desktop stack and a panning canvas and ... dif= ferent behaviors?
- Thomas
On January 3rd, 2013, 5:06 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
Review request for kwin.
By Martin Gr=C3=A4=C3=9Flin.
Updated Jan. 3, 2013, 5:06 p.m. Descripti= on
Testing <= /h1>
Diffs=
|