This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108164/

I called it "Base" border (vertical titlebar in mind) but that's not ideal either - try "ConterTitle" ;-)

- Thomas


On January 4th, 2013, 1:10 p.m., Martin Gräßlin wrote:

Review request for kwin and Hugo Pereira Da Costa.
By Martin Gräßlin.

Updated Jan. 4, 2013, 1:10 p.m.

Description

Support for new decoration border sizes BorderBottom and BorderNone

BorderBottom is what is known from Oxygen as "No Side Borders". The name
should indicate that there is only a border at the bottom. BorderNone is
a mode with no borders at all.

The new enums are added to KDecoration and the KCM so that all decos can
make use of it.

Aurorae is adjusted to support the new sizes for QML themes (it breaks
the old svg based themes) and Plastik makes use of it, by rendering a
one-pixel border around the window, which illustrates that it's still up
to the decoration to decide how to make use of the setting.

@Hugo: in case you want to port Oxygen to the feature: due to ABI compatibility the BorderBottom and BorderNone are added to the end of the list, while in Oxygen they are listed as first elements (which make much more sense).

@All: a better name for BorderBottom would be nice :-)

Diffs

  • kwin/clients/aurorae/src/decorationoptions.h (4f469fec16f1045ca75101b497f31b04a55e48d8)
  • kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml (c6b3042bafbf4ec1afea5f083f2702955c739ffc)
  • kwin/kcmkwin/kwindecoration/configdialog.h (f07befc808c15e902a91b71b9f1ae30b72831573)
  • kwin/kcmkwin/kwindecoration/configdialog.cpp (a047c44d0e575a928a69f2dc3a325fbcfb444cfa)
  • kwin/kcmkwin/kwindecoration/kwindecoration.cpp (8e66099ff32a41ca27ccb038afe3422768e9491e)
  • kwin/libkdecorations/kdecoration.h (e37fd6275bfe2f072c44be3fdc55fe56d4036481)

View Diff

Screenshots

Plastik with no side border