From kwin Fri Jan 04 20:06:33 2013 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Fri, 04 Jan 2013 20:06:33 +0000 To: kwin Subject: Re: Review Request: Support for new decoration border sizes BorderBottom and BorderNone Message-Id: <20130104200633.19666.31679 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=135733001615102 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8022652700068655709==" --===============8022652700068655709== Content-Type: multipart/alternative; boundary="===============6176652951855519757==" --===============6176652951855519757== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108164/#review24694 ----------------------------------------------------------- I called it "Base" border (vertical titlebar in mind) but that's not ideal = either - try "ConterTitle" ;-) - Thomas L=C3=BCbking On Jan. 4, 2013, 1:10 p.m., Martin Gr=C3=A4=C3=9Flin wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108164/ > ----------------------------------------------------------- > = > (Updated Jan. 4, 2013, 1:10 p.m.) > = > = > Review request for kwin and Hugo Pereira Da Costa. > = > = > Description > ------- > = > Support for new decoration border sizes BorderBottom and BorderNone > = > BorderBottom is what is known from Oxygen as "No Side Borders". The name > should indicate that there is only a border at the bottom. BorderNone is > a mode with no borders at all. > = > The new enums are added to KDecoration and the KCM so that all decos can > make use of it. > = > Aurorae is adjusted to support the new sizes for QML themes (it breaks > the old svg based themes) and Plastik makes use of it, by rendering a > one-pixel border around the window, which illustrates that it's still up > to the decoration to decide how to make use of the setting. > = > @Hugo: in case you want to port Oxygen to the feature: due to ABI compati= bility the BorderBottom and BorderNone are added to the end of the list, wh= ile in Oxygen they are listed as first elements (which make much more sense= ). > = > @All: a better name for BorderBottom would be nice :-) > = > = > Diffs > ----- > = > kwin/clients/aurorae/src/decorationoptions.h 4f469fec16f1045ca75101b497= f31b04a55e48d8 = > kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml c6b304= 2bafbf4ec1afea5f083f2702955c739ffc = > kwin/kcmkwin/kwindecoration/configdialog.h f07befc808c15e902a91b71b9f1a= e30b72831573 = > kwin/kcmkwin/kwindecoration/configdialog.cpp a047c44d0e575a928a69f2dc3a= 325fbcfb444cfa = > kwin/kcmkwin/kwindecoration/kwindecoration.cpp 8e66099ff32a41ca27ccb038= afe3422768e9491e = > kwin/libkdecorations/kdecoration.h e37fd6275bfe2f072c44be3fdc55fe56d403= 6481 = > = > Diff: http://git.reviewboard.kde.org/r/108164/diff/ > = > = > Testing > ------- > = > = > Screenshots > ----------- > = > Plastik with no side border > http://git.reviewboard.kde.org/r/108164/s/971/ > = > = > Thanks, > = > Martin Gr=C3=A4=C3=9Flin > = > --===============6176652951855519757== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/108164/ 

I called i=
t "Base" border (vertical titlebar in mind) but that's not id=
eal either - try "ConterTitle" ;-)

- Thomas


On January 4th, 2013, 1:10 p.m., Martin Gr=C3=A4=C3=9Flin wrote:

Review request for kwin and Hugo Pereira Da Costa.
By Martin Gr=C3=A4=C3=9Flin.

Updated Jan. 4, 2013, 1:10 p.m.

Descripti= on 

Support for new decoration border sizes BorderBottom and Bor=
derNone

BorderBottom is what is known from Oxygen as "No Side Borders". T=
he name
should indicate that there is only a border at the bottom. BorderNone is
a mode with no borders at all.

The new enums are added to KDecoration and the KCM so that all decos can
make use of it.

Aurorae is adjusted to support the new sizes for QML themes (it breaks
the old svg based themes) and Plastik makes use of it, by rendering a
one-pixel border around the window, which illustrates that it's still up
to the decoration to decide how to make use of the setting.

@Hugo: in case you want to port Oxygen to the feature: due to ABI compatibi=
lity the BorderBottom and BorderNone are added to the end of the list, whil=
e in Oxygen they are listed as first elements (which make much more sense).

@All: a better name for BorderBottom would be nice :-)

Diffs=

  • kwin/clients/aurorae/src/decorationoptions.h (4f469fec16f1045ca75101b497f31b04a55e48d8)
  • kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml (c6b3042bafbf4ec1afea5f083f2702955c739ffc)
  • kwin/kcmkwin/kwindecoration/configdialog.h (f07befc808c15e902a91b71b9f1ae30b72831573)
  • kwin/kcmkwin/kwindecoration/configdialog.cpp (a047c44d0e575a928a69f2dc3a325fbcfb444cfa)
  • kwin/kcmkwin/kwindecoration/kwindecoration.cpp (8e66099ff32a41ca27ccb038afe3422768e9491e)
  • kwin/libkdecorations/kdecoration.h (e37fd6= 275bfe2f072c44be3fdc55fe56d4036481)

View Diff

Screensho= ts

3D"Plastik
--===============6176652951855519757==-- --===============8022652700068655709== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============8022652700068655709==--