[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Signal stacking order changes down to the effects
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2013-01-04 19:59:36
Message-ID: 20130104195936.17673.65469 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 2, 2013, 8:54 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> > what about Unmanaged? Yes they are not in the actual stacking order use=
d by KWin, but passed to the effects (see Workspace::xStackingOrder()).
> =
> Thomas L=C3=BCbking wrote:
> s/stacking/clientStacking/ ?
> =
> I'm not entirely sure what those reorders would be of interest (unman=
aged are combo dropdowns, popups, tooltips, plasmas panel proxies, the tabb=
ox ...)
> =
> At least for the effect(s) of intended use, those are completely irre=
levant and given their usual "input only" and/or temporary character, i see=
no use in "listen & fire" on every minor restack of unmanged windows.
> =
> Martin Gr=C3=A4=C3=9Flin wrote:
> usage: blur effect to know when to schedule a repaint.
> =
> Something else that came to my mind. What about the Deleted? Basicall=
y the stacking order changes when the Deleted gets removed but not when the=
Client is removed. I guess emitting an additional signal when the Deleted =
is destroyed, wouldn't hurt.
the effects get "windowDeleted()" when a window is deleted.
while override_redirect windows will usually only be added or removed, they=
could indeed alter their stacking order though, yes.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108059/#review24413
-----------------------------------------------------------
On Jan. 1, 2013, 12:54 a.m., Thomas L=C3=BCbking wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108059/
> -----------------------------------------------------------
> =
> (Updated Jan. 1, 2013, 12:54 a.m.)
> =
> =
> Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
> =
> =
> Description
> -------
> =
> So that in the next patch, the slideback effect can be altered to react o=
n this instead of comparing the stacking order in every paint pass.
> =
> =
> Diffs
> -----
> =
> kwin/effects.cpp 7025883 =
> kwin/layers.cpp 5104e19 =
> kwin/libkwineffects/kwineffects.h 6aea85d =
> kwin/workspace.h 8416334 =
> =
> Diff: http://git.reviewboard.kde.org/r/108059/diff/
> =
> =
> Testing
> -------
> =
> Yes, with be::faded.
> Order (propagate -> emit) is crucial.
> =
> =
> Thanks,
> =
> Thomas L=C3=BCbking
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108059/">http://git.reviewboard.kde.org/r/108059/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 2nd, 2013, 8:54 a.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">what about Unmanaged? Yes they are not in the actual stacking order used \
by KWin, but passed to the effects (see Workspace::xStackingOrder()).</pre> \
</blockquote>
<p>On January 2nd, 2013, 3:02 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">s/stacking/clientStacking/ ?
I'm not entirely sure what those reorders would be of interest (unmanaged are \
combo dropdowns, popups, tooltips, plasmas panel proxies, the tabbox ...)
At least for the effect(s) of intended use, those are completely irrelevant and given \
their usual "input only" and/or temporary character, i see no use in \
"listen & fire" on every minor restack of unmanged windows.</pre> \
</blockquote>
<p>On January 4th, 2013, 7:50 a.m., <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">usage: blur effect to \
know when to schedule a repaint.
Something else that came to my mind. What about the Deleted? Basically the stacking \
order changes when the Deleted gets removed but not when the Client is removed. I \
guess emitting an additional signal when the Deleted is destroyed, wouldn't \
hurt.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the effects get \
"windowDeleted()" when a window is deleted. while override_redirect windows \
will usually only be added or removed, they could indeed alter their stacking order \
though, yes.</pre> <br />
<p>- Thomas</p>
<br />
<p>On January 1st, 2013, 12:54 a.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Jan. 1, 2013, 12:54 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">So that in the next patch, the slideback effect can be altered to react \
on this instead of comparing the stacking order in every paint pass.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, with be::faded. Order (propagate -> emit) is crucial.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects.cpp <span style="color: grey">(7025883)</span></li>
<li>kwin/layers.cpp <span style="color: grey">(5104e19)</span></li>
<li>kwin/libkwineffects/kwineffects.h <span style="color: \
grey">(6aea85d)</span></li>
<li>kwin/workspace.h <span style="color: grey">(8416334)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108059/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic