From kwin Fri Jan 04 19:46:05 2013 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Fri, 04 Jan 2013 19:46:05 +0000 To: kwin Subject: Re: Review Request: improve multihead situation Message-Id: <20130104194605.13220.6314 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=135732877914509 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4654641228238927512==" --===============4654641228238927512== Content-Type: multipart/alternative; boundary="===============8306906730885003209==" --===============8306906730885003209== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Jan. 4, 2013, 9:44 a.m., Martin Gr=C3=A4=C3=9Flin wrote: > > kwin/tabbox/tabbox.cpp, lines 926-928 > > > > > > hey, what happened to the nice curly braces? Terrible accident - you really don't want to know. Much blood. They suffered a lot. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107853/#review24642 ----------------------------------------------------------- On Dec. 25, 2012, 2:12 p.m., Thomas L=C3=BCbking wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107853/ > ----------------------------------------------------------- > = > (Updated Dec. 25, 2012, 2:12 p.m.) > = > = > Review request for kwin and Martin Gr=C3=A4=C3=9Flin. > = > = > Description > ------- > = > according to comment at bug #256242 (and on my own short term perception)= this improves the tabbox on multihead setups because the focus is not pass= ed to the other head. > = > it does so by testing whether this kwin workspace singleton contains the = window with input focus (to start action with) > Single head is special cased an patch runs here for quite some time (sing= le head) > = > = > Diffs > ----- > = > kwin/composite.cpp bc51425 = > kwin/tabbox/tabbox.cpp 0541e59 = > kwin/workspace.h 8416334 = > kwin/workspace.cpp b9e137d = > kwin/xcbutils.h PRE-CREATION = > = > Diff: http://git.reviewboard.kde.org/r/107853/diff/ > = > = > Testing > ------- > = > "yes" > = > = > Thanks, > = > Thomas L=C3=BCbking > = > --===============8306906730885003209== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107853/

On January 4th, 2013, 9:44 a.m., Martin Gr= =C3=A4=C3=9Flin wrote:
= = = = = = =
kwin/tabbox/tabbox.cpp (Diff revision 3)
void TabBox::navigatingThroughWindows(bool forward, const KShortcut=
& shortcut, TabBoxMode mode)
926
    if (!m_ready){
926
    if (!m_ready)
927
        return;
927
        return;
928
    }
hey, what=
 happened to the nice curly braces?

Terrible accident - you really don't want to know.
Much blood. They suffered a lot.

- Thomas

On December 25th, 2012, 2:12 p.m., Thomas L=C3=BCbking wrote:

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.

By Thomas L=C3=BCbking.

Updated Dec. 25, 2012, 2:12 p.m.

Descripti= on

according to comment at bug #256242 (and on my own short ter=
m perception) this improves the tabbox on multihead setups because the focu=
s is not passed to the other head.

it does so by testing whether this kwin workspace singleton contains the wi=
ndow with input focus (to start action with)
Single head is special cased an patch runs here for quite some time (single=
 head)

Testing <= /h1>

"yes"

Diffs=

kwin/composite.cpp (bc51425)
kwin/tabbox/tabbox.cpp (0541e59)
kwin/workspace.h (8416334)
kwin/workspace.cpp (b9e137d)
kwin/xcbutils.h (PRE-CREATION)

--===============8306906730885003209==-- --===============4654641228238927512== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============4654641228238927512==--