'Re: Review Request: Port Input Window handling for Effects to XCB'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Port Input Window handling for Effects to XCB
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2013-01-04 11:13:05
Message-ID: 20130104111305.4599.40987 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107817/
-----------------------------------------------------------

(Updated Jan. 4, 2013, 11:13 a.m.)

Review request for kwin and Fredrik H=C3=B6glund.

Changes
-------

* added a window() to Xcb::Wrapper
* use WindowAttributes in checkInputWindowStacking

Description
-------

Port Input Window handling for Effects to XCB

Introduce helper classes to perform common xcb requests

Two helper classes WindowGeometry and WindowAttributes which can be
used to request the geometry and attributes more easily. This is based on
a templated class, taking cookieType, replyType and function pointers to
the request and reply functions as template parameters.

The ctor performs the async request and the reply is stored in a
QSharedPointer. Whenever the reply is needed it is checked whether it
has already been retrieved and if not will block by calling the reply
method. The class provides operator bool() to check whether the reply
succeeded (pointer is not null) and operator->() to directly access the
reply pointer.

Diffs (updated)
-----

  kwin/effects.h 1f0955072ca4dfca8797aed74f042b4339f913e5 =

  kwin/effects.cpp eaab46ff32f2b5aad5a1d5f0bebe5c62854a75ec =

  kwin/libkwineffects/kwineffects.h aa5d9e8b67c60b158e7ffb08dfcf3e8d2a16dcd=
7 =

  kwin/libkwineffects/kwineffects.cpp 4895ca0e1e4fce2ca38330cf6d5cd8a350baa=
d94 =

  kwin/xcbutils.h PRE-CREATION =

Diff: http://git.reviewboard.kde.org/r/107817/diff/

Testing
-------

Thanks,

Martin Gr=C3=A4=C3=9Flin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107817/">http://git.reviewboard.kde.org/r/107817/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Fredrik Höglund.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Jan. 4, 2013, 11:13 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">* added a window() to Xcb::Wrapper
* use WindowAttributes in checkInputWindowStacking</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Port Input Window handling for Effects to XCB

Introduce helper classes to perform common xcb requests

Two helper classes WindowGeometry and WindowAttributes which can be
used to request the geometry and attributes more easily. This is based on
a templated class, taking cookieType, replyType and function pointers to
the request and reply functions as template parameters.

The ctor performs the async request and the reply is stored in a
QSharedPointer. Whenever the reply is needed it is checked whether it
has already been retrieved and if not will block by calling the reply
method. The class provides operator bool() to check whether the reply
succeeded (pointer is not null) and operator-&gt;() to directly access the
reply pointer.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects.h <span style="color: \
grey">(1f0955072ca4dfca8797aed74f042b4339f913e5)</span></li>

 <li>kwin/effects.cpp <span style="color: \
grey">(eaab46ff32f2b5aad5a1d5f0bebe5c62854a75ec)</span></li>

 <li>kwin/libkwineffects/kwineffects.h <span style="color: \
grey">(aa5d9e8b67c60b158e7ffb08dfcf3e8d2a16dcd7)</span></li>

 <li>kwin/libkwineffects/kwineffects.cpp <span style="color: \
grey">(4895ca0e1e4fce2ca38330cf6d5cd8a350baad94)</span></li>

 <li>kwin/xcbutils.h <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107817/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 