This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107754/ |
On December 23rd, 2012, 8:55 a.m., Martin Gräßlin wrote:
kwin/scene_opengl.cpp (Diff revision 3) void SceneOpenGL2::slotColorCorrectionError()582 void SceneOpenGL2::slotColorCorrectionError()583 {
584 // This should also trigger slotColorCorrectedChanged()
585 options->setColorCorrected(false);586 }
why do you not define this slot in Options? Oh and please add a: // TODO: Qt5: replace by lambdaOn January 3rd, 2013, 7:04 p.m., Casian Andrei wrote:
It looks to me like it does not fit in Options - there are no slots for errors there, I wouldn't know even where to place it there. SceneOpenGL2 owns the color correction object, so it makes sense for it to handle the error. With that lambda feature, this slot will dissappear with Qt5 anyway :)
Q_SLOTS: void disableColorCorrection(); under all those Q_SIGNALS: and above private. The reason that there's no slot atm. is that we don't alter the *options* at runtime at all. I'd say the scene should know (and tell on request dbug dbus interface request pending ...) whether it's color corrected and initiallize that from the options and not touch options. @Martin The pointer should (in this context) maybe ro to stress that?
- Thomas
On January 3rd, 2013, 7:04 p.m., Casian Andrei wrote:
Review request for kwin, Thomas Lübking and Martin Gräßlin.
By Casian Andrei.
Updated Jan. 3, 2013, 7:04 p.m. Description
Testing
Diffs
|