'Re: Review Request: Abort color correction initialization and disable it in case of errors'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Abort color correction initialization and disable it in case of errors
From:       "Casian Andrei" <skeletk13 () gmail ! com>
Date:       2013-01-03 19:04:19
Message-ID: 20130103190419.24391.96153 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107754/
-----------------------------------------------------------

(Updated Jan. 3, 2013, 7:04 p.m.)

Review request for kwin, Thomas L=C3=BCbking and Martin Gr=C3=A4=C3=9Flin.

Description
-------

Abort color correction initialization and disable it in case of errors
    =

    Checks are now performed for GL errors and in case of errors everything
    is aborted. The error handling mechanism introduced for this purpose
    somewhat improves the color correction code.

Tracked down and fixed a GL invalid operation when first attempting to set =
the lookup texture uniform for color correction.

Diffs (updated)
-----

  kwin/libkwineffects/kwinglcolorcorrection.h ec080c0 =

  kwin/libkwineffects/kwinglcolorcorrection.cpp b5127e6 =

  kwin/libkwineffects/kwinglcolorcorrection_p.h f54aa49 =

  kwin/scene_opengl.h e6142c0 =

  kwin/scene_opengl.cpp 147a248 =

Diff: http://git.reviewboard.kde.org/r/107754/diff/

Testing
-------

Tested when a GL invalid operation error occurs - color correction is disab=
led and will not be enabled again because of the error. However, the check =
box in KCM remains checked - but this is ok I think.

Tested when no GL invalid operation is detected when doing color correction=
 stuff. Everything works fine from my point of view.

Thanks,

Casian Andrei

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107754/">http://git.reviewboard.kde.org/r/107754/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Thomas Lübking and Martin Gräßlin.</div>
<div>By Casian Andrei.</div>

<p style="color: grey;"><i>Updated Jan. 3, 2013, 7:04 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Abort color correction initialization and disable it in case of errors  
    Checks are now performed for GL errors and in case of errors everything
    is aborted. The error handling mechanism introduced for this purpose
    somewhat improves the color correction code.

Tracked down and fixed a GL invalid operation when first attempting to set the lookup \
texture uniform for color correction.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested when a GL invalid operation error occurs - color correction is \
disabled and will not be enabled again because of the error. However, the check box \
in KCM remains checked - but this is ok I think.

Tested when no GL invalid operation is detected when doing color correction stuff. \
Everything works fine from my point of view. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/libkwineffects/kwinglcolorcorrection.h <span style="color: \
grey">(ec080c0)</span></li>

 <li>kwin/libkwineffects/kwinglcolorcorrection.cpp <span style="color: \
grey">(b5127e6)</span></li>

 <li>kwin/libkwineffects/kwinglcolorcorrection_p.h <span style="color: \
grey">(f54aa49)</span></li>

 <li>kwin/scene_opengl.h <span style="color: grey">(e6142c0)</span></li>

 <li>kwin/scene_opengl.cpp <span style="color: grey">(147a248)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107754/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 