'Re: Review Request: collect shadows of existing clients when toggling the compositor'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: collect shadows of existing clients when toggling the compositor
From:       "Commit Hook" <null () kde ! org>
Date:       2013-01-02 18:00:21
Message-ID: 20130102180021.1371.61960 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107965/#review24455
-----------------------------------------------------------

This review has been submitted with commit d2d926f98b9d1a5dd0c73617b60a0d09=
476d6f6b by Thomas L=C3=BCbking to branch KDE/4.10.

- Commit Hook

On Dec. 27, 2012, 9:09 p.m., Thomas L=C3=BCbking wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107965/
> -----------------------------------------------------------
> =

> (Updated Dec. 27, 2012, 9:09 p.m.)
> =

> =

> Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
> =

> =

> Description
> -------
> =

> because it annoyed me for long enough and oxygen will someday use them an=
d we got all those plasma related shadow reports (and i don't want it to lo=
ok like "WIP" ;-)
> =

> =

> Diffs
> -----
> =

>   kwin/composite.cpp bc51425 =

> =

> Diff: http://git.reviewboard.kde.org/r/107965/diff/
> =

> =

> Testing
> -------
> =

> yes, shift+alt+f12 + bespin : no shadows until de/activating a client (im=
plicitly updating the shadow)
> -> shift+alt+f12 + bespin : all windows are nicely shadowed
> =

> =

> Thanks,
> =

> Thomas L=C3=BCbking
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107965/">http://git.reviewboard.kde.org/r/107965/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit d2d926f98b9d1a5dd0c73617b60a0d09476d6f6b by Thomas Lübking to \
branch KDE/4.10.</pre>  <br />

<p>- Commit</p>

<br />
<p>On December 27th, 2012, 9:09 p.m., Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Dec. 27, 2012, 9:09 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">because it annoyed me for long enough and oxygen will someday use them \
and we got all those plasma related shadow reports (and i don&#39;t want it to look \
like &quot;WIP&quot; ;-)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yes, shift+alt+f12 + bespin : no shadows until de/activating a client \
                (implicitly updating the shadow)
-&gt; shift+alt+f12 + bespin : all windows are nicely shadowed</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/composite.cpp <span style="color: grey">(bc51425)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107965/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 