[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Fix some KRazy2 issues
From:       "Commit Hook" <null () kde ! org>
Date:       2013-01-02 17:42:10
Message-ID: 20130102174210.30358.56725 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107998/#review24451
-----------------------------------------------------------


This review has been submitted with commit 8bf0b5daf4c029ef3604455520c85117=
ee6d0628 by Martin Gr=C3=A4=C3=9Flin to branch master.

- Commit Hook


On Dec. 29, 2012, 7:38 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107998/
> -----------------------------------------------------------
> =

> (Updated Dec. 29, 2012, 7:38 a.m.)
> =

> =

> Review request for kwin and Hugo Pereira Da Costa.
> =

> =

> Description
> -------
> =

> Remove duplicated include
> =

> =

> Fix spelling
> =

> =

> Fix non-const ref iterator issues reported by Krazy2 checker foreach
> =

> =

> Mark most ctors as explicit as reported by Krazy2 checker
> =

> =

> Fix Krazy2 issues reported by doublequote_chars checker
> =

> =

> Diffs
> -----
> =

>   kwin/bridge.h 9b34fbde5710b3ae031ff9a78f700c30eaacbfc3 =

>   kwin/client.h e8ae850deb4f421bb3437f048db809c892d4e6dc =

>   kwin/clients/aurorae/src/colorhelper.h ece5a512bab88c6b8eff4c0f712d45b5=
4966d18a =

>   kwin/clients/aurorae/src/lib/auroraetheme.h 3705932b7b2abd9383e6e8a9d31=
ec7ff2bc156c3 =

>   kwin/clients/b2/b2client.h c9e9b57c35ea8880dbe194df9129ef8009e8605f =

>   kwin/clients/oxygen/config/oxygenconfigurationui.h 772cce887553aa638339=
8bef0efc66bb97491acb =

>   kwin/clients/oxygen/config/oxygendetectwidget.h b5755641f96bd2674cecdbe=
fb1637ca616048e3d =

>   kwin/clients/oxygen/config/oxygenexceptiondialog.h 8ec6d8baa42f75c114b2=
80f411f4f9f82ae3b560 =

>   kwin/clients/oxygen/config/oxygenshadowconfigurationui.h f7e81c4d9ec6bb=
17ad132ff542a643131f214806 =

>   kwin/clients/oxygen/oxygenclientgroupitemdata.h 76a6c04022bacd6c8bd9513=
194feeb17d3fbc689 =

>   kwin/clients/oxygen/oxygenconfiguration.h 52fd6902833d519b6aca3b35dcade=
b91ca8d4498 =

>   kwin/clients/oxygen/oxygendecohelper.h e86687254c0bb65e0c937d50e97dcb32=
9873e825 =

>   kwin/clients/oxygen/oxygenexception.h 22a700eeaa7973325e25f189136daf813=
61a5255 =

>   kwin/clients/oxygen/oxygenexceptionlist.h 640cc3b4a9e79b5e9a4879943c053=
50fa0ca48c0 =

>   kwin/clients/oxygen/oxygensizegrip.h 5bfb22bacad99012ae100299082db8ca73=
43b498 =

>   kwin/clients/oxygen/oxygentitleanimationdata.h 4634577eb20061ce507706a6=
7c69004ce4776230 =

>   kwin/composite.cpp bc51425a021f643f45d2c1ddd156c2092ba91ec5 =

>   kwin/dbusinterface.h d8e8cd35007255c9c12e08fc86f3e5ca95361dbb =

>   kwin/effects.h d985de4e4f76ecb53099b36d22e7678ba199b9f3 =

>   kwin/effects/boxswitch/boxswitch_proxy.h eab863c0ff7d83b7ccf1431d9b57e4=
b816a8dc43 =

>   kwin/effects/cube/cube_proxy.h f28b9a41e4a1bb7b04e0abfe25339cbe54ecec9f =

>   kwin/effects/desktopgrid/desktopgrid.h 498e2fde4a2c34312866860d5d707fe7=
81d3d412 =

>   kwin/effects/presentwindows/presentwindows.h e891715aa4f4689394e8c4adb7=
8e339480f782f7 =

>   kwin/effects/presentwindows/presentwindows_proxy.h efcd81ffe81cdad7b71a=
c7849b6dfd0c040e18d9 =

>   kwin/geometry.cpp 6a7ded4cc2018c5792b3b26e02252a11ab8b5c65 =

>   kwin/kcmkwin/kwindecoration/buttons.h 1eaa298efb25614c6596ae0858361a8e3=
c61311b =

>   kwin/kcmkwin/kwindecoration/decorationmodel.h efc6d7ad7279400b8708204fe=
4ef50e148ee0b91 =

>   kwin/kcmkwin/kwindecoration/preview.h 72cf7c1448e5072e2aab73d8d0b53c269=
351cd3d =

>   kwin/kcmkwin/kwindesktop/desktopnameswidget.h fccf0663e769e46c765e49ebc=
e4a7416f594ab8b =

>   kwin/kcmkwin/kwinrules/ruleslist.h b49f2594d0bd46ae6885877f390a3758d428=
b15f =

>   kwin/kcmkwin/kwinrules/ruleswidget.h a4b5b9133033968e59857a5a890a5d19b5=
3d97de =

>   kwin/kcmkwin/kwinrules/yesnobox.h cc226e3fa0909576c0e5c18853add911fc970=
f84 =

>   kwin/kcmkwin/kwinscreenedges/monitor.h bf0392efffba0233a08c8e5de158debd=
11b3e4e8 =

>   kwin/kcmkwin/kwinscripts/module.h f2e195cd9857ffb0d6b70e403fa86c9ab01cb=
5cf =

>   kwin/kcmkwin/kwintabbox/layoutpreview.h 1eee65aa71cd8b2ed53cfef201a0591=
a349f530f =

>   kwin/kcmkwin/kwintabbox/thumbnailitem.h 04977d6d6fa4e114e1cdb9afa60a231=
b6bef7094 =

>   kwin/lanczosfilter.h 07d67b0e841ce050b5fe820504a72a259cc13cef =

>   kwin/libkdecorations/kdecoration_plugins_p.h e23e3320671aa18c69e9e9f192=
0b38cadc27a64d =

>   kwin/libkwineffects/anidata_p.h df4e088b58736a37fa8db77de6ba7984617160a=
c =

>   kwin/libkwineffects/kwinanimationeffect.h 76a5b9b5041c14556b5aa4b0394d7=
e970ee2c078 =

>   kwin/libkwineffects/kwineffects.h 6aea85d20772a8a69855b81ef687b91dc93b9=
8ac =

>   kwin/libkwineffects/kwingltexture.h a18dc94317fe7baabc3278d2daf1c006135=
c015b =

>   kwin/libkwineffects/kwinglutils.h ab82068a3b5c05a53741c99b5ac0efccbcb3f=
01b =

>   kwin/libkwineffects/kwinxrenderutils.h f564002aee820a89f7c84bcc6bec75b0=
c84a4722 =

>   kwin/libkwineffects/kwinxrenderutils.cpp b6350454bbb6149990f98d37ce88e3=
b933fbb2b4 =

>   kwin/main.cpp 85c297bd12439154db54f1cfd9a25a39a19f3c23 =

>   kwin/manage.cpp 190aaf25c1f2c2a76b8da3a5bcb1df40abbe1a59 =

>   kwin/options.h f9f623f346c7d6556169abb18079085e013af4db =

>   kwin/rules.h 418311efc996c03a7ebd6e7fc9ebf969c817362c =

>   kwin/scene.h 1b170660187b32e6df2bc34261d891199a7c9add =

>   kwin/scene_opengl.h e6142c0c2c291176c3c996e79d377c7d72cb7997 =

>   kwin/scene_xrender.h 645700f58ae7863b6f9a918531eeb6510283b4be =

>   kwin/scripting/scripting.h 12645658c4c080721949311968c7a5c02ec5f64b =

>   kwin/scripting/workspace_wrapper.h 556994cb0a1c6f4d96c42718d427d0bb468b=
72dc =

>   kwin/tabbox/clientmodel.h bc737c9a1847e654a87fc0b9e97d5eac688227d7 =

>   kwin/tabbox/clientmodel.cpp daa063af05edbce1122366c192122e5d2f7af5c3 =

>   kwin/tabbox/declarative.h 3b4d126e598d2e2cd96c841c0c0d6c5d27da601c =

>   kwin/tabbox/desktopmodel.h 52d8bf4aa7e61a1d2a060509205f19366ff8267b =

>   kwin/tabbox/tabbox.h bba0b39b7e316b9895a8d1fabe196fdad9bf0348 =

>   kwin/tabbox/tabbox.cpp 0541e5948dfbdb45c779420946402df9c090ce72 =

>   kwin/tabbox/tabboxhandler.cpp 66d2acb1af1fb403e0eb70bcf7676d32914edee9 =

>   kwin/tabgroup.h 96329b1fa9df5655dd8b2e94c6072721ed4a780f =

>   kwin/thumbnailitem.h a219a33d1360b9407137c3aae8d9677449eb719f =

>   kwin/tools/decobenchmark/preview.h 5ce3b22c8025bc579dc82122b4f03918966f=
a9f5 =

>   kwin/toplevel.h a8c76977d6667bda7bf66477a46d36027bc9dc3e =

>   kwin/unmanaged.h 851d7712c7ae2250d0340b73518834f324c453b4 =

>   kwin/utils.h 5b68d57a4101ae6d7eefd38624d646a38d7b32fc =

>   kwin/workspace.h 84163347d346d6381a4d825b560d30f04787e3c2 =

> =

> Diff: http://git.reviewboard.kde.org/r/107998/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Martin Gr=C3=A4=C3=9Flin
> =

>


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107998/">http://git.reviewboard.kde.org/r/107998/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 8bf0b5daf4c029ef3604455520c85117ee6d0628 by Martin Gräßlin to \
branch master.</pre>  <br />







<p>- Commit</p>


<br />
<p>On December 29th, 2012, 7:38 a.m., Martin Gräßlin wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Hugo Pereira Da Costa.</div>
<div>By Martin Gräßlin.</div>


<p style="color: grey;"><i>Updated Dec. 29, 2012, 7:38 a.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Remove duplicated include


Fix spelling


Fix non-const ref iterator issues reported by Krazy2 checker foreach


Mark most ctors as explicit as reported by Krazy2 checker


Fix Krazy2 issues reported by doublequote_chars checker</pre>
  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/bridge.h <span style="color: \
grey">(9b34fbde5710b3ae031ff9a78f700c30eaacbfc3)</span></li>

 <li>kwin/client.h <span style="color: \
grey">(e8ae850deb4f421bb3437f048db809c892d4e6dc)</span></li>

 <li>kwin/clients/aurorae/src/colorhelper.h <span style="color: \
grey">(ece5a512bab88c6b8eff4c0f712d45b54966d18a)</span></li>

 <li>kwin/clients/aurorae/src/lib/auroraetheme.h <span style="color: \
grey">(3705932b7b2abd9383e6e8a9d31ec7ff2bc156c3)</span></li>

 <li>kwin/clients/b2/b2client.h <span style="color: \
grey">(c9e9b57c35ea8880dbe194df9129ef8009e8605f)</span></li>

 <li>kwin/clients/oxygen/config/oxygenconfigurationui.h <span style="color: \
grey">(772cce887553aa6383398bef0efc66bb97491acb)</span></li>

 <li>kwin/clients/oxygen/config/oxygendetectwidget.h <span style="color: \
grey">(b5755641f96bd2674cecdbefb1637ca616048e3d)</span></li>

 <li>kwin/clients/oxygen/config/oxygenexceptiondialog.h <span style="color: \
grey">(8ec6d8baa42f75c114b280f411f4f9f82ae3b560)</span></li>

 <li>kwin/clients/oxygen/config/oxygenshadowconfigurationui.h <span style="color: \
grey">(f7e81c4d9ec6bb17ad132ff542a643131f214806)</span></li>

 <li>kwin/clients/oxygen/oxygenclientgroupitemdata.h <span style="color: \
grey">(76a6c04022bacd6c8bd9513194feeb17d3fbc689)</span></li>

 <li>kwin/clients/oxygen/oxygenconfiguration.h <span style="color: \
grey">(52fd6902833d519b6aca3b35dcadeb91ca8d4498)</span></li>

 <li>kwin/clients/oxygen/oxygendecohelper.h <span style="color: \
grey">(e86687254c0bb65e0c937d50e97dcb329873e825)</span></li>

 <li>kwin/clients/oxygen/oxygenexception.h <span style="color: \
grey">(22a700eeaa7973325e25f189136daf81361a5255)</span></li>

 <li>kwin/clients/oxygen/oxygenexceptionlist.h <span style="color: \
grey">(640cc3b4a9e79b5e9a4879943c05350fa0ca48c0)</span></li>

 <li>kwin/clients/oxygen/oxygensizegrip.h <span style="color: \
grey">(5bfb22bacad99012ae100299082db8ca7343b498)</span></li>

 <li>kwin/clients/oxygen/oxygentitleanimationdata.h <span style="color: \
grey">(4634577eb20061ce507706a67c69004ce4776230)</span></li>

 <li>kwin/composite.cpp <span style="color: \
grey">(bc51425a021f643f45d2c1ddd156c2092ba91ec5)</span></li>

 <li>kwin/dbusinterface.h <span style="color: \
grey">(d8e8cd35007255c9c12e08fc86f3e5ca95361dbb)</span></li>

 <li>kwin/effects.h <span style="color: \
grey">(d985de4e4f76ecb53099b36d22e7678ba199b9f3)</span></li>

 <li>kwin/effects/boxswitch/boxswitch_proxy.h <span style="color: \
grey">(eab863c0ff7d83b7ccf1431d9b57e4b816a8dc43)</span></li>

 <li>kwin/effects/cube/cube_proxy.h <span style="color: \
grey">(f28b9a41e4a1bb7b04e0abfe25339cbe54ecec9f)</span></li>

 <li>kwin/effects/desktopgrid/desktopgrid.h <span style="color: \
grey">(498e2fde4a2c34312866860d5d707fe781d3d412)</span></li>

 <li>kwin/effects/presentwindows/presentwindows.h <span style="color: \
grey">(e891715aa4f4689394e8c4adb78e339480f782f7)</span></li>

 <li>kwin/effects/presentwindows/presentwindows_proxy.h <span style="color: \
grey">(efcd81ffe81cdad7b71ac7849b6dfd0c040e18d9)</span></li>

 <li>kwin/geometry.cpp <span style="color: \
grey">(6a7ded4cc2018c5792b3b26e02252a11ab8b5c65)</span></li>

 <li>kwin/kcmkwin/kwindecoration/buttons.h <span style="color: \
grey">(1eaa298efb25614c6596ae0858361a8e3c61311b)</span></li>

 <li>kwin/kcmkwin/kwindecoration/decorationmodel.h <span style="color: \
grey">(efc6d7ad7279400b8708204fe4ef50e148ee0b91)</span></li>

 <li>kwin/kcmkwin/kwindecoration/preview.h <span style="color: \
grey">(72cf7c1448e5072e2aab73d8d0b53c269351cd3d)</span></li>

 <li>kwin/kcmkwin/kwindesktop/desktopnameswidget.h <span style="color: \
grey">(fccf0663e769e46c765e49ebce4a7416f594ab8b)</span></li>

 <li>kwin/kcmkwin/kwinrules/ruleslist.h <span style="color: \
grey">(b49f2594d0bd46ae6885877f390a3758d428b15f)</span></li>

 <li>kwin/kcmkwin/kwinrules/ruleswidget.h <span style="color: \
grey">(a4b5b9133033968e59857a5a890a5d19b53d97de)</span></li>

 <li>kwin/kcmkwin/kwinrules/yesnobox.h <span style="color: \
grey">(cc226e3fa0909576c0e5c18853add911fc970f84)</span></li>

 <li>kwin/kcmkwin/kwinscreenedges/monitor.h <span style="color: \
grey">(bf0392efffba0233a08c8e5de158debd11b3e4e8)</span></li>

 <li>kwin/kcmkwin/kwinscripts/module.h <span style="color: \
grey">(f2e195cd9857ffb0d6b70e403fa86c9ab01cb5cf)</span></li>

 <li>kwin/kcmkwin/kwintabbox/layoutpreview.h <span style="color: \
grey">(1eee65aa71cd8b2ed53cfef201a0591a349f530f)</span></li>

 <li>kwin/kcmkwin/kwintabbox/thumbnailitem.h <span style="color: \
grey">(04977d6d6fa4e114e1cdb9afa60a231b6bef7094)</span></li>

 <li>kwin/lanczosfilter.h <span style="color: \
grey">(07d67b0e841ce050b5fe820504a72a259cc13cef)</span></li>

 <li>kwin/libkdecorations/kdecoration_plugins_p.h <span style="color: \
grey">(e23e3320671aa18c69e9e9f1920b38cadc27a64d)</span></li>

 <li>kwin/libkwineffects/anidata_p.h <span style="color: \
grey">(df4e088b58736a37fa8db77de6ba7984617160ac)</span></li>

 <li>kwin/libkwineffects/kwinanimationeffect.h <span style="color: \
grey">(76a5b9b5041c14556b5aa4b0394d7e970ee2c078)</span></li>

 <li>kwin/libkwineffects/kwineffects.h <span style="color: \
grey">(6aea85d20772a8a69855b81ef687b91dc93b98ac)</span></li>

 <li>kwin/libkwineffects/kwingltexture.h <span style="color: \
grey">(a18dc94317fe7baabc3278d2daf1c006135c015b)</span></li>

 <li>kwin/libkwineffects/kwinglutils.h <span style="color: \
grey">(ab82068a3b5c05a53741c99b5ac0efccbcb3f01b)</span></li>

 <li>kwin/libkwineffects/kwinxrenderutils.h <span style="color: \
grey">(f564002aee820a89f7c84bcc6bec75b0c84a4722)</span></li>

 <li>kwin/libkwineffects/kwinxrenderutils.cpp <span style="color: \
grey">(b6350454bbb6149990f98d37ce88e3b933fbb2b4)</span></li>

 <li>kwin/main.cpp <span style="color: \
grey">(85c297bd12439154db54f1cfd9a25a39a19f3c23)</span></li>

 <li>kwin/manage.cpp <span style="color: \
grey">(190aaf25c1f2c2a76b8da3a5bcb1df40abbe1a59)</span></li>

 <li>kwin/options.h <span style="color: \
grey">(f9f623f346c7d6556169abb18079085e013af4db)</span></li>

 <li>kwin/rules.h <span style="color: \
grey">(418311efc996c03a7ebd6e7fc9ebf969c817362c)</span></li>

 <li>kwin/scene.h <span style="color: \
grey">(1b170660187b32e6df2bc34261d891199a7c9add)</span></li>

 <li>kwin/scene_opengl.h <span style="color: \
grey">(e6142c0c2c291176c3c996e79d377c7d72cb7997)</span></li>

 <li>kwin/scene_xrender.h <span style="color: \
grey">(645700f58ae7863b6f9a918531eeb6510283b4be)</span></li>

 <li>kwin/scripting/scripting.h <span style="color: \
grey">(12645658c4c080721949311968c7a5c02ec5f64b)</span></li>

 <li>kwin/scripting/workspace_wrapper.h <span style="color: \
grey">(556994cb0a1c6f4d96c42718d427d0bb468b72dc)</span></li>

 <li>kwin/tabbox/clientmodel.h <span style="color: \
grey">(bc737c9a1847e654a87fc0b9e97d5eac688227d7)</span></li>

 <li>kwin/tabbox/clientmodel.cpp <span style="color: \
grey">(daa063af05edbce1122366c192122e5d2f7af5c3)</span></li>

 <li>kwin/tabbox/declarative.h <span style="color: \
grey">(3b4d126e598d2e2cd96c841c0c0d6c5d27da601c)</span></li>

 <li>kwin/tabbox/desktopmodel.h <span style="color: \
grey">(52d8bf4aa7e61a1d2a060509205f19366ff8267b)</span></li>

 <li>kwin/tabbox/tabbox.h <span style="color: \
grey">(bba0b39b7e316b9895a8d1fabe196fdad9bf0348)</span></li>

 <li>kwin/tabbox/tabbox.cpp <span style="color: \
grey">(0541e5948dfbdb45c779420946402df9c090ce72)</span></li>

 <li>kwin/tabbox/tabboxhandler.cpp <span style="color: \
grey">(66d2acb1af1fb403e0eb70bcf7676d32914edee9)</span></li>

 <li>kwin/tabgroup.h <span style="color: \
grey">(96329b1fa9df5655dd8b2e94c6072721ed4a780f)</span></li>

 <li>kwin/thumbnailitem.h <span style="color: \
grey">(a219a33d1360b9407137c3aae8d9677449eb719f)</span></li>

 <li>kwin/tools/decobenchmark/preview.h <span style="color: \
grey">(5ce3b22c8025bc579dc82122b4f03918966fa9f5)</span></li>

 <li>kwin/toplevel.h <span style="color: \
grey">(a8c76977d6667bda7bf66477a46d36027bc9dc3e)</span></li>

 <li>kwin/unmanaged.h <span style="color: \
grey">(851d7712c7ae2250d0340b73518834f324c453b4)</span></li>

 <li>kwin/utils.h <span style="color: \
grey">(5b68d57a4101ae6d7eefd38624d646a38d7b32fc)</span></li>

 <li>kwin/workspace.h <span style="color: \
grey">(84163347d346d6381a4d825b560d30f04787e3c2)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107998/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin


[prev in list] [next in list] [prev in thread] [next in thread]