[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: deco kcm, defer deletion of QML view to next event cycle
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2013-01-02 14:54:59
Message-ID: 20130102145459.4393.35957 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 2, 2013, 8:42 a.m., Martin Gräßlin wrote:
> > I would like that someone who experiences the crash in a reliable way verifies \
> > that it solves the problem. Also I rather blame a certain unnamed distribution \
> > than just adding code in the hope that it helps ;-)
Because of the enxounter of bug #311018 with 4.9.95 i doubt this is actually a \
solution. From the crashing Qt line there's apparently a dangeling parent() pointer, \
what rather should not happen (because deleting the parent should take the kid with \
it anyway)
We'll need a valgrind output from someone experiencing it.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108028/#review24410
-----------------------------------------------------------
On Dec. 30, 2012, 9:11 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108028/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2012, 9:11 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> THIS IS NOW VOID
>
> bug #311018 reoccurred
>
>
> This addresses bug 304617.
> http://bugs.kde.org/show_bug.cgi?id=304617
>
>
> Diffs
> -----
>
> kwin/kcmkwin/kwindecoration/kwindecoration.cpp 8e66099
>
> Diff: http://git.reviewboard.kde.org/r/108028/diff/
>
>
> Testing
> -------
>
> doesn't cause additional crash, but that's all i can say.
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108028/">http://git.reviewboard.kde.org/r/108028/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 2nd, 2013, 8:42 a.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I would like that someone who experiences the crash in a reliable way \
verifies that it solves the problem. Also I rather blame a certain unnamed \
distribution than just adding code in the hope that it helps ;-)</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Because of the enxounter \
of bug #311018 with 4.9.95 i doubt this is actually a solution. From the crashing Qt \
line there's apparently a dangeling parent() pointer, what rather should not \
happen (because deleting the parent should take the kid with it anyway)
We'll need a valgrind output from someone experiencing it.</pre>
<br />
<p>- Thomas</p>
<br />
<p>On December 30th, 2012, 9:11 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Dec. 30, 2012, 9:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">THIS IS NOW VOID
bug #311018 reoccurred</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">doesn't cause additional crash, but that's all i can say.</pre> \
</td> </tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=304617">304617</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/kcmkwin/kwindecoration/kwindecoration.cpp <span style="color: \
grey">(8e66099)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108028/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic