[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Use the invalid NULL uuid instead of "ALL" to indeicate the "on all activities"
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2013-01-02 8:38:45
Message-ID: 20130102083845.20746.21498 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107855/#review24409
-----------------------------------------------------------
Ship it!
I like that solution. Has the "ALL" been used somewhere in a config file (e=
.g. Rules)? If yes we need an update script.
kwin/client.cpp
<http://git.reviewboard.kde.org/r/107855/#comment18710>
@Ivan: could that define become part of the public API?
- Martin Gr=C3=A4=C3=9Flin
On Dec. 31, 2012, 8:24 p.m., Thomas L=C3=BCbking wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107855/
> -----------------------------------------------------------
> =
> (Updated Dec. 31, 2012, 8:24 p.m.)
> =
> =
> Review request for kwin, Ivan =C4=8Cuki=C4=87 and Martin Gr=C3=A4=C3=9Fli=
n.
> =
> =
> Description
> -------
> =
> When the activity daemon is not reposponding, the lib cache will answer w=
ith the null activity which is so far just "invalid", cannot be activate an=
d by this its not a good idea to assign any window to it (happens when you =
open a window and it gets on the current "null" activity)
> =
> Using it instead of the "ALL" property is more robust (anytime there's st=
h. slightly wrong in the system we fall back to "on all activities" rather =
than loosing windows on some unreachable activities) as well as more consis=
tent (there's now always a uuid string as activity property)
> =
> Notice that there's a pending reference to "ALL" in "service/ui/plugins/d=
eclarativeui/DeclarativeUi.cpp" which Ivan wants to scratch as soon as we u=
se the null uuid in git master.
> =
> =
> Diffs
> -----
> =
> kwin/client.cpp b555c11 =
> =
> Diff: http://git.reviewboard.kde.org/r/107855/diff/
> =
> =
> Testing
> -------
> =
> No regression spotted.
> Reg. the original problem:
> semi - i once ran into one or more window/s being on that id, not with th=
e patch since after.
> =
> =
> Thanks,
> =
> Thomas L=C3=BCbking
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107855/">http://git.reviewboard.kde.org/r/107855/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I like that solution. \
Has the "ALL" been used somewhere in a config file (e.g. Rules)? If yes we \
need an update script.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/107855/diff/3/?file=103543#file103543line1505" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/client.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Client::setOnActivity(const QString &activity, bool enable)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1505</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#define NULL_UUID \
"00000000-0000-0000-0000-000000000000"</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">@Ivan: \
could that define become part of the public API?</pre> </div>
<br />
<p>- Martin</p>
<br />
<p>On December 31st, 2012, 8:24 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Ivan Čukić and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Dec. 31, 2012, 8:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When the activity daemon is not reposponding, the lib cache will answer \
with the null activity which is so far just "invalid", cannot be activate \
and by this its not a good idea to assign any window to it (happens when you open a \
window and it gets on the current "null" activity)
Using it instead of the "ALL" property is more robust (anytime there's \
sth. slightly wrong in the system we fall back to "on all activities" \
rather than loosing windows on some unreachable activities) as well as more \
consistent (there's now always a uuid string as activity property)
Notice that there's a pending reference to "ALL" in \
"service/ui/plugins/declarativeui/DeclarativeUi.cpp" which Ivan wants to \
scratch as soon as we use the null uuid in git master.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No regression spotted. Reg. the original problem:
semi - i once ran into one or more window/s being on that id, not with the patch \
since after.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/client.cpp <span style="color: grey">(b555c11)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107855/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic