[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: avoid nulluid activity
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-12-30 21:48:40
Message-ID: 20121230214840.18670.39642 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Dec. 30, 2012, 7:42 p.m., Ivan =C4=8Cuki=C4=87 wrote:
> > May I suggest a bit different approach - instead of handling the null a=
ctivity like it is something special, why not just do this - when an activi=
ty that has windows only on it is deleted, those are moved to the current a=
ctivity. This would be more generic.
> =
> Thomas L=C3=BCbking wrote:
> /**
> * updates clients when an activity is destroyed.
> * this ensures that a client does not get 'lost' if the only activit=
y it's on is removed.
> */
> void Workspace::slotActivityRemoved(const QString &activity)
> ...
> =
> That's not the problem, also see bug #309203
> I ran into it later on as well - but don't ask me for what reason (an=
d there was actually no "legal" way to get back to the client, but "xprop -=
remove _KDE_NET_WM_ACTIVITIES -id <wid>")
> =
> Apparently whether getting lost in dbus or whatever, it can under som=
e circumstances happen that windows are assigned to the null uuid and, mayb=
e it is due to its special nature, never leave it, resp. not leave it autom=
atically.
> =
> Whenever the activitymanagerd crashes, or stops responding or dbus is=
flooded or ppl. say "i don't need no st.. what was aarons blogpost ;-)" or=
for whatever reason the library says "nulluuid" the result should not be i=
naccessible windows, never.
> Thus the sane solution is to treat this as invalid, thus absent of sp=
ecific, thus "ALL".
> =
> We could also remove the special "ALL" property and use the nulluuid =
as it.
> =
> Ivan =C4=8Cuki=C4=87 wrote:
> > We could also remove the special "ALL" property and use the nulluui=
d as it.
> =
> Like!
Ok, patch in KWin is here, but there's at least a reference in "service/ui/=
plugins/declarativeui/DeclarativeUi.cpp" you need to get rid of as well, si=
nce we're not gonna support this any more.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107855/#review24287
-----------------------------------------------------------
On Dec. 30, 2012, 3:47 p.m., Thomas L=C3=BCbking wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107855/
> -----------------------------------------------------------
> =
> (Updated Dec. 30, 2012, 3:47 p.m.)
> =
> =
> Review request for kwin, Ivan =C4=8Cuki=C4=87 and Martin Gr=C3=A4=C3=9Fli=
n.
> =
> =
> Description
> -------
> =
> This is replied as activity by the lib cache in case the server is (yet) =
not up, but no window should ever be assigned to it - so we should rather r=
emove it (and in doubt treat this as "all activities" condition)
> =
> =
> Diffs
> -----
> =
> kwin/client.cpp b555c11 =
> =
> Diff: http://git.reviewboard.kde.org/r/107855/diff/
> =
> =
> Testing
> -------
> =
> semi - i once ran into one or more window/s being on that id, not with th=
e patch since after (surprise)
> =
> =
> Thanks,
> =
> Thomas L=C3=BCbking
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107855/">http://git.reviewboard.kde.org/r/107855/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 30th, 2012, 7:42 p.m., <b>Ivan \
Čukić</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">May I suggest a bit different approach - instead of handling the null \
activity like it is something special, why not just do this - when an activity that \
has windows only on it is deleted, those are moved to the current activity. This \
would be more generic.</pre> </blockquote>
<p>On December 30th, 2012, 8:21 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">/**
* updates clients when an activity is destroyed.
* this ensures that a client does not get 'lost' if the only activity \
it's on is removed.
*/
void Workspace::slotActivityRemoved(const QString &activity)
...
That's not the problem, also see bug #309203
I ran into it later on as well - but don't ask me for what reason (and there was \
actually no "legal" way to get back to the client, but "xprop -remove \
_KDE_NET_WM_ACTIVITIES -id <wid>")
Apparently whether getting lost in dbus or whatever, it can under some circumstances \
happen that windows are assigned to the null uuid and, maybe it is due to its special \
nature, never leave it, resp. not leave it automatically.
Whenever the activitymanagerd crashes, or stops responding or dbus is flooded or ppl. \
say "i don't need no st.. what was aarons blogpost ;-)" or for whatever \
reason the library says "nulluuid" the result should not be inaccessible \
windows, never. Thus the sane solution is to treat this as invalid, thus absent of \
specific, thus "ALL".
We could also remove the special "ALL" property and use the nulluuid as \
it.</pre> </blockquote>
<p>On December 30th, 2012, 8:32 p.m., <b>Ivan Čukić</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> We could also \
remove the special "ALL" property and use the nulluuid as it.
Like!</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, patch in KWin is \
here, but there's at least a reference in \
"service/ui/plugins/declarativeui/DeclarativeUi.cpp" you need to get rid of \
as well, since we're not gonna support this any more.</pre> <br />
<p>- Thomas</p>
<br />
<p>On December 30th, 2012, 3:47 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Ivan Čukić and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Dec. 30, 2012, 3:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is replied as activity by the lib cache in case the server is (yet) \
not up, but no window should ever be assigned to it - so we should rather remove it \
(and in doubt treat this as "all activities" condition)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">semi - i once ran into one or more window/s being on that id, not with \
the patch since after (surprise)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/client.cpp <span style="color: grey">(b555c11)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107855/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic