From kwin Sat Dec 29 19:45:41 2012 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Sat, 29 Dec 2012 19:45:41 +0000 To: kwin Subject: Re: Review Request: here ya go, daddy =) Message-Id: <20121229194541.3477.14961 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=135681035411534 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4741816757905933158==" --===============4741816757905933158== Content-Type: multipart/alternative; boundary="===============3090407800085773117==" --===============3090407800085773117== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Dec. 29, 2012, 6:38 p.m., Martin Gr=C3=A4=C3=9Flin wrote: > > kwin/effects/snaphelper/snaphelper.cpp, line 209 > > > > > > i++? cnp ;-) - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108005/#review24204 ----------------------------------------------------------- On Dec. 29, 2012, 3:36 p.m., Thomas L=C3=BCbking wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108005/ > ----------------------------------------------------------- > = > (Updated Dec. 29, 2012, 3:36 p.m.) > = > = > Review request for kwin and Martin Gr=C3=A4=C3=9Flin. > = > = > Description > ------- > = > Didn't we figure that JJ do not work? > = > = > This addresses bug 311551. > http://bugs.kde.org/show_bug.cgi?id=3D311551 > = > = > Diffs > ----- > = > kwin/effects/snaphelper/snaphelper.h 464ae3f = > kwin/effects/snaphelper/snaphelper.cpp cdb00bc = > = > Diff: http://git.reviewboard.kde.org/r/108005/diff/ > = > = > Testing > ------- > = > Yes. I still do not know what this thing is good for, but it updates corr= ectly. > = > = > Thanks, > = > Thomas L=C3=BCbking > = > --===============3090407800085773117== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/108005/

On December 29th, 2012, 6:38 p.m., Martin G= r=C3=A4=C3=9Flin wrote:

= = =
kwin/effects/snaphelper/snaphelper.cpp (Diff revision 1) 

   
void SnapHelperEffect::slotWindowResized(KWin::EffectWindow *w, con=
st QRect &oldRect)


  

 

  

    
    

    209
    
        for (int i <=
span class=3D"o">=3D 0;<=
/span> i < effects->numScr=
eens(); i++) {

  


 




  
i++?

 









cnp ;-)








- Thomas






On December 29th, 2012, 3:36 p.m., Thomas L=C3=BCbking wrote:









 

  


Review request for kwin and Martin Gr=C3=A4=C3=9Flin.


By Thomas L=C3=BCbking.




Updated Dec. 29, 2012, 3:36 p.m.








Descripti=
on 

 

 

  
   
Didn't we figure that JJ do not work?

  		
 






Testing <=
/h1>


 

  
   
Yes. I still do not know what this thing is good for, but it=
 updates correctly.

  		
 








 Bugs: 


 311551







Diffs=
 


    

 
  • kwin/effects/snaphelper/snaphelper.h (464a=
e3f)
    • 

 
  • kwin/effects/snaphelper/snaphelper.cpp (cd=
b00bc)
    • 





View Diff





  		
 











  

 



--===============3090407800085773117==--

--===============4741816757905933158==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

--===============4741816757905933158==--