'Review Request: skip resetting states if client was untabbed for release'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: skip resetting states if client was untabbed for release
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-12-29 14:55:52
Message-ID: 20121229145552.18076.36436 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108003/
-----------------------------------------------------------

Review request for kwin and Martin Gräßlin.

Description
-------

summarized.
the problem here is that ::releaseWindow calls finishCompositing() before \
workspace()->removeClient(this, Allowed) where the tabgroup restores the former \
state, causing slots on NULL effectwindows being invoked and the effect is not \
prepared for that.

Other options would be to
a) check the effect window everytime before emitting a slot...
b) fully untab the window before emitting the clientRemoved signal (but that's \
pointless) c) explicitly disconnecting EffectsHandlerImpl from Client/Toplevel in eg. \
EffectsHandlerImpl::slotWindowClosed()

I actually think (c) is more reasonable but skipping pointless action won't harm \
either and has faar more narrow impact (so not sure whether we should disconnect the \
client in slotWindowClosed() - doesn't seem critical either, though)

This addresses bug 310142.
    http://bugs.kde.org/show_bug.cgi?id=310142

Diffs
-----

  kwin/client.h e8ae850 
  kwin/client.cpp b555c11 
  kwin/workspace.cpp b9e137d 

Diff: http://git.reviewboard.kde.org/r/108003/diff/

Testing
-------

Nope, i don't wobble nor maximize ;-)

Thanks,

Thomas Lübking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108003/">http://git.reviewboard.kde.org/r/108003/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">summarized. the problem here is that ::releaseWindow calls \
finishCompositing() before workspace()-&gt;removeClient(this, Allowed) where the \
tabgroup restores the former state, causing slots on NULL effectwindows being invoked \
and the effect is not prepared for that.

Other options would be to
a) check the effect window everytime before emitting a slot...
b) fully untab the window before emitting the clientRemoved signal (but that&#39;s \
pointless) c) explicitly disconnecting EffectsHandlerImpl from Client/Toplevel in eg. \
EffectsHandlerImpl::slotWindowClosed()

I actually think (c) is more reasonable but skipping pointless action won&#39;t harm \
either and has faar more narrow impact (so not sure whether we should disconnect the \
client in slotWindowClosed() - doesn&#39;t seem critical either, though)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Nope, i don&#39;t wobble nor maximize ;-)</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=310142">310142</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/client.h <span style="color: grey">(e8ae850)</span></li>

 <li>kwin/client.cpp <span style="color: grey">(b555c11)</span></li>

 <li>kwin/workspace.cpp <span style="color: grey">(b9e137d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108003/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 