'Re: Review Request: improve multihead situation'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: improve multihead situation
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-12-24 20:13:47
Message-ID: 20121224201347.599.41209 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107853/
-----------------------------------------------------------

(Updated Dec. 24, 2012, 8:13 p.m.)

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.

Changes
-------

take_this_you_nasty_little_under_score_s!

Fixed comments, added altered xcbutils.h - have a look, then let's discuss =
this to a state where we can use it.

I did NOT test this variant against an actual multihead setup so far, only =
commented the !is_multihead shortcut to make the code actually run and qDeb=
ug's the returned in_put_fo_cus_win_dow and ge_o_me_try_roo_t

See, that really sucks ;-P

Description
-------

according to comment at bug #256242 (and on my own short term perception) t=
his improves the tabbox on multihead setups because the focus is not passed=
 to the other head.

it does so by testing whether this kwin workspace singleton contains the wi=
ndow with input focus (to start action with)
Single head is special cased an patch runs here for quite some time (single=
 head)

Diffs (updated)
-----

  kwin/composite.cpp bc51425 =

  kwin/tabbox/tabbox.cpp 0541e59 =

  kwin/workspace.h 8416334 =

  kwin/workspace.cpp b9e137d =

  kwin/xcbutils.h PRE-CREATION =

Diff: http://git.reviewboard.kde.org/r/107853/diff/

Testing
-------

"yes"

Thanks,

Thomas L=C3=BCbking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107853/">http://git.reviewboard.kde.org/r/107853/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Dec. 24, 2012, 8:13 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">take_this_you_nasty_little_under_score_s!

Fixed comments, added altered xcbutils.h - have a look, then let&#39;s discuss this \
to a state where we can use it.

I did NOT test this variant against an actual multihead setup so far, only commented \
the !is_multihead shortcut to make the code actually run and qDebug&#39;s the \
returned in_put_fo_cus_win_dow and ge_o_me_try_roo_t

See, that really sucks ;-P</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">according to comment at bug #256242 (and on my own short term \
perception) this improves the tabbox on multihead setups because the focus is not \
passed to the other head.

it does so by testing whether this kwin workspace singleton contains the window with \
input focus (to start action with) Single head is special cased an patch runs here \
for quite some time (single head)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">&quot;yes&quot;</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/composite.cpp <span style="color: grey">(bc51425)</span></li>

 <li>kwin/tabbox/tabbox.cpp <span style="color: grey">(0541e59)</span></li>

 <li>kwin/workspace.h <span style="color: grey">(8416334)</span></li>

 <li>kwin/workspace.cpp <span style="color: grey">(b9e137d)</span></li>

 <li>kwin/xcbutils.h <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107853/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 