[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Port Input Window handling for Effects to XCB
From: Fredrik_Höglund <fredrik () kde ! org>
Date: 2012-12-20 14:08:47
Message-ID: 20121220140847.31867.12972 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107817/#review23754
-----------------------------------------------------------
kwin/effects.cpp
<http://git.reviewboard.kde.org/r/107817/#comment18172>
This is equivalent to an XSync(), so a request shouldn't be checked unl=
ess there's a very good reason to think it might fail.
kwin/effects.cpp
<http://git.reviewboard.kde.org/r/107817/#comment18171>
This should be split into two loops; one that sends the requests and st=
ores the cookies in an array, and one that loops over the cookies and gets =
the replies.
- Fredrik H=C3=B6glund
On Dec. 20, 2012, 1:14 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107817/
> -----------------------------------------------------------
> =
> (Updated Dec. 20, 2012, 1:14 p.m.)
> =
> =
> Review request for kwin and Fredrik H=C3=B6glund.
> =
> =
> Description
> -------
> =
> Port Input Window handling for Effects to XCB
> =
> =
> Diffs
> -----
> =
> kwin/effects.h d985de4e4f76ecb53099b36d22e7678ba199b9f3 =
> kwin/effects.cpp 70258835054cb579625bc42ea7f077a718d06104 =
> kwin/libkwineffects/kwineffects.h 6aea85d20772a8a69855b81ef687b91dc93b9=
8ac =
> kwin/libkwineffects/kwineffects.cpp 4895ca0e1e4fce2ca38330cf6d5cd8a350b=
aad94 =
> =
> Diff: http://git.reviewboard.kde.org/r/107817/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Martin Gr=C3=A4=C3=9Flin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107817/">http://git.reviewboard.kde.org/r/107817/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/107817/diff/1/?file=100464#file100464line1072" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/effects.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QRect \
EffectsHandlerImpl::clientArea(clientAreaOption opt, const EffectWindow* c) \
const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1069</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">ScopedCPointer</span><span class="o"><</span><span \
class="n">xcb_generic_error_t</span><span class="o">></span> <span \
class="n">error</span> <span class="o">=</span> <span \
class="n">xcb_request_check</span><span class="p">(</span><span \
class="n">connection</span><span class="p">(),</span> <span \
class="n">cwCookie</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is \
equivalent to an XSync(), so a request shouldn't be checked unless there's a \
very good reason to think it might fail.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/107817/diff/1/?file=100464#file100464line1154" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/effects.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
EffectsHandlerImpl::checkInputWindowEvent(XEvent* e)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">1135</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">foreach</span> <span class="p">(</span><span class="k">const</span> <span \
class="n">InputWindowPair</span> <span class="o">&</span><span \
class="n">it</span><span class="p">,</span> <span class="n">input_windows</span><span \
class="p">)</span> <span class="p">{</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">1151</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">foreach</span> <span class="p">(</span><span class="k">const</span> <span \
class="n">InputWindowPair</span> <span class="o">&</span><span \
class="n">it</span><span class="p">,</span> <span class="n">input_windows</span><span \
class="p">)</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This should \
be split into two loops; one that sends the requests and stores the cookies in an \
array, and one that loops over the cookies and gets the replies.</pre> </div>
<br />
<p>- Fredrik</p>
<br />
<p>On December 20th, 2012, 1:14 p.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Fredrik Höglund.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Dec. 20, 2012, 1:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Port Input Window handling for Effects to XCB</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects.h <span style="color: \
grey">(d985de4e4f76ecb53099b36d22e7678ba199b9f3)</span></li>
<li>kwin/effects.cpp <span style="color: \
grey">(70258835054cb579625bc42ea7f077a718d06104)</span></li>
<li>kwin/libkwineffects/kwineffects.h <span style="color: \
grey">(6aea85d20772a8a69855b81ef687b91dc93b98ac)</span></li>
<li>kwin/libkwineffects/kwineffects.cpp <span style="color: \
grey">(4895ca0e1e4fce2ca38330cf6d5cd8a350baad94)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107817/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic