[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Fix double vertical separator in Task Switcher KCM
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-12-17 14:02:32
Message-ID: 20121217140232.29182.79684 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Dec. 17, 2012, 1:02 p.m., Thomas L=C3=BCbking wrote:
> > There's quite some action in this patch - please have a quick check whe=
ther the taborder (blue toolbutton with number) is still ok and then just p=
ush it unless Kai protests until 20:00 CET (because of the freeze 5h later)=
- if you can do that timewise. Otherwise attach the formatted patch ... or=
i'll fix it myself tonight ;-)
*sigh* - that's the great part about QtDesigner...
No, please set them in reasonable order* while at it (they likely got corup=
ted by another minor change and no re-check ... probably by me ;-)
* top left -> down right on the left, then top left -> down right on the ri=
ght.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107778/#review23599
-----------------------------------------------------------
On Dec. 17, 2012, 1:44 p.m., Hugo Pereira Da Costa wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107778/
> -----------------------------------------------------------
> =
> (Updated Dec. 17, 2012, 1:44 p.m.)
> =
> =
> Review request for kwin, Thomas L=C3=BCbking, Martin Gr=C3=A4=C3=9Flin, a=
nd Kai Uwe Broulik.
> =
> =
> Description
> -------
> =
> Fix double vertical separator in Task Switcher KCM
> Diff is just UI stuff.
> See screenshots instead.
> Same review as https://git.reviewboard.kde.org/r/107587/ except that kwin=
does compile here, and works well.
> Also needs forward porting to master, and backporting to KDE/4.9 (I think)
> =
> =
> Diffs
> -----
> =
> kwin/kcmkwin/kwintabbox/main.ui e1393f7 =
> =
> Diff: http://git.reviewboard.kde.org/r/107778/diff/
> =
> =
> Testing
> -------
> =
> looks good.
> =
> =
> Screenshots
> -----------
> =
> before
> http://git.reviewboard.kde.org/r/107778/s/908/
> after
> http://git.reviewboard.kde.org/r/107778/s/909/
> tab order before
> http://git.reviewboard.kde.org/r/107778/s/910/
> tab order after
> http://git.reviewboard.kde.org/r/107778/s/911/
> =
> =
> Thanks,
> =
> Hugo Pereira Da Costa
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107778/">http://git.reviewboard.kde.org/r/107778/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 17th, 2012, 1:02 p.m., <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">There's quite some action in this patch - please have a quick check \
whether the taborder (blue toolbutton with number) is still ok and then just push it \
unless Kai protests until 20:00 CET (because of the freeze 5h later) - if you can do \
that timewise. Otherwise attach the formatted patch ... or i'll fix it myself \
tonight ;-)</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">*sigh* - that's the \
great part about QtDesigner...
No, please set them in reasonable order* while at it (they likely got corupted by \
another minor change and no re-check ... probably by me ;-)
* top left -> down right on the left, then top left -> down right on the \
right.</pre> <br />
<p>- Thomas</p>
<br />
<p>On December 17th, 2012, 1:44 p.m., Hugo Pereira Da Costa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Thomas Lübking, Martin Gräßlin, and Kai Uwe \
Broulik.</div> <div>By Hugo Pereira Da Costa.</div>
<p style="color: grey;"><i>Updated Dec. 17, 2012, 1:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix double vertical separator in Task Switcher KCM Diff is just UI \
stuff. See screenshots instead.
Same review as https://git.reviewboard.kde.org/r/107587/ except that kwin does \
compile here, and works well. Also needs forward porting to master, and backporting \
to KDE/4.9 (I think)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">looks good.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/kcmkwin/kwintabbox/main.ui <span style="color: grey">(e1393f7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107778/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107778/s/908/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/17/systemsettings2_400x100.png" \
style="border: 1px black solid;" alt="before" /></a>
<a href="http://git.reviewboard.kde.org/r/107778/s/909/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/17/systemsettings3_400x100.png" \
style="border: 1px black solid;" alt="after" /></a>
<a href="http://git.reviewboard.kde.org/r/107778/s/910/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/17/taborder0_400x100.png" \
style="border: 1px black solid;" alt="tab order before" /></a>
<a href="http://git.reviewboard.kde.org/r/107778/s/911/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/17/taborder1_400x100.png" \
style="border: 1px black solid;" alt="tab order after" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic