'Re: Review Request: Only change current activity on explicit client activation'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Only change current activity on explicit client activation
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-12-16 21:04:46
Message-ID: 20121216210446.24626.49931 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107761/
-----------------------------------------------------------

(Updated Dec. 16, 2012, 9:04 p.m.)

Review request for kwin, Ivan Čukić and Martin Gräßlin.

Changes
-------

actually tested....

Description (updated)
-------

IT DOES NOT WORK - SNI force calls for activation.

-> We can either only attach it to the current activity or keep the window hidden.

To actually make things worse, the FDO systrays do not cause anything like that, ie. \
if you deactivate the kded module or try this on anything non-KDE/SNI the behavior \
will be totally different (as right now: the window will get added, activated, but \
not show on screen...)

This seems to be quite buggy altogether - we need to figure what to do with clients \
being mapped, but not on the current activity.

- Set them also on the current activity?
- Trigger an activity change?
- Deny mapping (eg. the systray menu of smplayer offered me to hide the window, while \
                it was not present)?
- By no means get them the focus (ie. invoke isOnCurrentActivity() in isShown() or \
whatever lets it pass)

This addresses bugs 242149 and 285053.
    http://bugs.kde.org/show_bug.cgi?id=242149
    http://bugs.kde.org/show_bug.cgi?id=285053

Diffs
-----

  kwin/activation.cpp a3c050c 

Diff: http://git.reviewboard.kde.org/r/107761/diff/

Testing (updated)
-------

Thanks,

Thomas Lübking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107761/">http://git.reviewboard.kde.org/r/107761/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Ivan Čukić and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Dec. 16, 2012, 9:04 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">actually tested....</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  \
(updated)</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">IT DOES NOT WORK - SNI force calls for activation.

-&gt; We can either only attach it to the current activity or keep the window hidden.

To actually make things worse, the FDO systrays do not cause anything like that, ie. \
if you deactivate the kded module or try this on anything non-KDE/SNI the behavior \
will be totally different (as right now: the window will get added, activated, but \
not show on screen...)

This seems to be quite buggy altogether - we need to figure what to do with clients \
being mapped, but not on the current activity.

- Set them also on the current activity?
- Trigger an activity change?
- Deny mapping (eg. the systray menu of smplayer offered me to hide the window, while \
                it was not present)?
- By no means get them the focus (ie. invoke isOnCurrentActivity() in isShown() or \
whatever lets it pass)</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=242149">242149</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=285053">285053</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/activation.cpp <span style="color: grey">(a3c050c)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107761/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 