'Review Request: Utilize QWidgetAction + QCheckBox for activity menu'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: Utilize QWidgetAction + QCheckBox for activity menu
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-12-16 16:25:07
Message-ID: 20121216162507.17881.83372 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107762/
-----------------------------------------------------------

Review request for kwin and Martin Gräßlin.

Description
-------

It's not like i'd like the solution, but there are quite some complaints that \
altering activities is nasty - and it is. QWidgetActions will not implicitly close \
the menu (despite the action is triggered) but that's in a way also playing on \
implementation details of QMenu. The menu otherwise acts as expected.

I also introduced a blocker (because otherwise the window will suddenly disappear \
when the user is on activity #1, window is tagged ALL, he wants to get it off a#3 and \
starts by clicking a#2 ...) and cleaned up some minor stuff (comment, before we \
introduce another virtual to  the deco, we'll just allow it to hook onto some \
activityChanged(QString activity) slot)

This addresses bug 283309.
    http://bugs.kde.org/show_bug.cgi?id=283309

Diffs
-----

  kwin/client.h e8ae850 
  kwin/client.cpp b555c11 
  kwin/useractions.cpp 118cd13 

Diff: http://git.reviewboard.kde.org/r/107762/diff/

Testing
-------

Yes. Not impressive, but better than atm.

Thanks,

Thomas Lübking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107762/">http://git.reviewboard.kde.org/r/107762/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It&#39;s not like i&#39;d like the solution, but there are quite some \
complaints that altering activities is nasty - and it is. QWidgetActions will not \
implicitly close the menu (despite the action is triggered) but that&#39;s in a way \
also playing on implementation details of QMenu. The menu otherwise acts as expected.

I also introduced a blocker (because otherwise the window will suddenly disappear \
when the user is on activity #1, window is tagged ALL, he wants to get it off a#3 and \
starts by clicking a#2 ...) and cleaned up some minor stuff (comment, before we \
introduce another virtual to  the deco, we&#39;ll just allow it to hook onto some \
activityChanged(QString activity) slot)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes. Not impressive, but better than atm.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=283309">283309</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/client.h <span style="color: grey">(e8ae850)</span></li>

 <li>kwin/client.cpp <span style="color: grey">(b555c11)</span></li>

 <li>kwin/useractions.cpp <span style="color: grey">(118cd13)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107762/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 