[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Fix two ui issues in kcm kwin
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-12-15 22:13:55
Message-ID: 20121215221355.6242.36254 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107746/#review23512
-----------------------------------------------------------
There's https://git.reviewboard.kde.org/r/107587/
Please coordinate with Kai (pending "kwin does not compile here" issue) and=
then someone ship it.
- Thomas L=C3=BCbking
On Dec. 15, 2012, 10:07 p.m., Hugo Pereira Da Costa wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107746/
> -----------------------------------------------------------
> =
> (Updated Dec. 15, 2012, 10:07 p.m.)
> =
> =
> Review request for kwin, Thomas L=C3=BCbking and Martin Gr=C3=A4=C3=9Flin.
> =
> =
> Description
> -------
> =
> Fix two ui issues in kcm kwin.
> - two vertical lines in main task switcher
> - wrong horizontal extend of horizontal lines in window behavior -> windo=
w actions
> =
> Comments: =
> 1/ the diff itself is just designer's magic. Look at the screenshot
> 2/ for the first issue there might already be a review request about this=
(you tell me)
> 3/ since both issues are quite minor, I put them in a single review. Tell=
me if you prefer 2.
> 4/ the first issue could also be backported to KDE/4.9, I think ... =
> =
> =
> Diffs
> -----
> =
> kwin/kcmkwin/kwinoptions/actions.ui cc9d5de =
> kwin/kcmkwin/kwintabbox/main.ui e1393f7 =
> =
> Diff: http://git.reviewboard.kde.org/r/107746/diff/
> =
> =
> Testing
> -------
> =
> looks good now =
> =
> =
> Screenshots
> -----------
> =
> main task switcher (before)
> http://git.reviewboard.kde.org/r/107746/s/900/
> main task switcher (after)
> http://git.reviewboard.kde.org/r/107746/s/901/
> window actions (before)
> http://git.reviewboard.kde.org/r/107746/s/902/
> window actions (after)
> http://git.reviewboard.kde.org/r/107746/s/904/
> =
> =
> Thanks,
> =
> Hugo Pereira Da Costa
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107746/">http://git.reviewboard.kde.org/r/107746/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There's \
https://git.reviewboard.kde.org/r/107587/ Please coordinate with Kai (pending \
"kwin does not compile here" issue) and then someone ship it.</pre> <br />
<p>- Thomas</p>
<br />
<p>On December 15th, 2012, 10:07 p.m., Hugo Pereira Da Costa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Thomas Lübking and Martin Gräßlin.</div>
<div>By Hugo Pereira Da Costa.</div>
<p style="color: grey;"><i>Updated Dec. 15, 2012, 10:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix two ui issues in kcm kwin.
- two vertical lines in main task switcher
- wrong horizontal extend of horizontal lines in window behavior -> window actions
Comments:
1/ the diff itself is just designer's magic. Look at the screenshot
2/ for the first issue there might already be a review request about this (you tell \
me) 3/ since both issues are quite minor, I put them in a single review. Tell me if \
you prefer 2. 4/ the first issue could also be backported to KDE/4.9, I think ... \
</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">looks good now </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/kcmkwin/kwinoptions/actions.ui <span style="color: \
grey">(cc9d5de)</span></li>
<li>kwin/kcmkwin/kwintabbox/main.ui <span style="color: grey">(e1393f7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107746/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107746/s/900/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/15/systemsettings1_400x100.png" \
style="border: 1px black solid;" alt="main task switcher (before)" /></a>
<a href="http://git.reviewboard.kde.org/r/107746/s/901/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/15/systemsettings3_400x100.png" \
style="border: 1px black solid;" alt="main task switcher (after)" /></a>
<a href="http://git.reviewboard.kde.org/r/107746/s/902/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/15/systemsettings0_400x100.png" \
style="border: 1px black solid;" alt="window actions (before)" /></a>
<a href="http://git.reviewboard.kde.org/r/107746/s/904/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/15/systemsettings2_1_400x100.png" \
style="border: 1px black solid;" alt="window actions (after)" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic