[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Laptop style appmenu support
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-11-27 14:13:10
Message-ID: 20121127141310.12773.48774 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 27, 2012, 1:49 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
> > How long have I waited for someone touching that decoration - I think w=
e have a new Laptop maintainer :-D
> > =
> > Personally I don't care much, change looks good (I'm impressed by the a=
bility to draw in binary), it just has to wait till master is open for feat=
ure commits again.
> =
> Cedric Bellegarde wrote:
> >it just has to wait till master is open for feature commits again.
> =
> Will let me time to port BII too :)
> =
> Martin Gr=C3=A4=C3=9Flin wrote:
> be aware that some of the decorations are scheduled for removal - the=
y are just waiting for Nuno to get up a design for a leightweight decoratio=
n which would work with X11 network transparency.
... and that will not use KCommonDecoration wrap-a-round-classes ;-)
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107485/#review22644
-----------------------------------------------------------
On Nov. 27, 2012, 1:13 p.m., Cedric Bellegarde wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107485/
> -----------------------------------------------------------
> =
> (Updated Nov. 27, 2012, 1:13 p.m.)
> =
> =
> Review request for kwin.
> =
> =
> Description
> -------
> =
> Add appmenu button support to laptop style.
> =
> =
> Diffs
> -----
> =
> kwin/clients/laptop/laptopclient.cpp 355355c =
> =
> Diff: http://git.reviewboard.kde.org/r/107485/diff/
> =
> =
> Testing
> -------
> =
> =
> Screenshots
> -----------
> =
> Laptop screenshot
> http://git.reviewboard.kde.org/r/107485/s/856/
> =
> =
> Thanks,
> =
> Cedric Bellegarde
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107485/">http://git.reviewboard.kde.org/r/107485/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 27th, 2012, 1:49 p.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">How long have I waited for someone touching that decoration - I think we \
have a new Laptop maintainer :-D
Personally I don't care much, change looks good (I'm impressed by the ability \
to draw in binary), it just has to wait till master is open for feature commits \
again.</pre> </blockquote>
<p>On November 27th, 2012, 1:53 p.m., <b>Cedric Bellegarde</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">>it just has to wait \
till master is open for feature commits again.
Will let me time to port BII too :)</pre>
</blockquote>
<p>On November 27th, 2012, 2 p.m., <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">be aware that some of \
the decorations are scheduled for removal - they are just waiting for Nuno to get up \
a design for a leightweight decoration which would work with X11 network \
transparency.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">... and that will not \
use KCommonDecoration wrap-a-round-classes ;-)</pre> <br />
<p>- Thomas</p>
<br />
<p>On November 27th, 2012, 1:13 p.m., Cedric Bellegarde wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Cedric Bellegarde.</div>
<p style="color: grey;"><i>Updated Nov. 27, 2012, 1:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add appmenu button support to laptop style.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/clients/laptop/laptopclient.cpp <span style="color: \
grey">(355355c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107485/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107485/s/856/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/27/laptop_400x100.png" \
style="border: 1px black solid;" alt="Laptop screenshot" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic