'Re: Review Request: Do not check whether -session cmd argument is passed to kwin in kdemain'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Do not check whether -session cmd argument is passed to kwin in kdemain
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-11-26 11:50:00
Message-ID: 20121126115000.6301.17914 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107468/#review22552
-----------------------------------------------------------

Ship it!

Ship It!

- Thomas L=C3=BCbking

On Nov. 26, 2012, 9:42 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107468/
> -----------------------------------------------------------
> =

> (Updated Nov. 26, 2012, 9:42 a.m.)
> =

> =

> Review request for kwin.
> =

> =

> Description
> -------
> =

> Do not check whether -session cmd argument is passed to kwin in kdemain
> =

> This got used to check whether the session is being restored and only if
> the session was not being restored the multi-head checks used to be
> performed. Since 299a78772b823d28cf3c48aff696cfb978d0ae7e the multi-head
> checks are no longer bound to not restoring the session which obsoletes
> the remaining checks.
> =

> =

> Diffs
> -----
> =

>   kwin/main.cpp e1609973a973b60728462e0303a51be7376c8f73 =

> =

> Diff: http://git.reviewboard.kde.org/r/107468/diff/
> =

> =

> Testing
> -------
> =

> compiles without unused variable warning.
> =

> =

> Thanks,
> =

> Martin Gr=C3=A4=C3=9Flin
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107468/">http://git.reviewboard.kde.org/r/107468/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Thomas</p>

<br />
<p>On November 26th, 2012, 9:42 a.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Nov. 26, 2012, 9:42 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Do not check whether -session cmd argument is passed to kwin in kdemain

This got used to check whether the session is being restored and only if
the session was not being restored the multi-head checks used to be
performed. Since 299a78772b823d28cf3c48aff696cfb978d0ae7e the multi-head
checks are no longer bound to not restoring the session which obsoletes
the remaining checks.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiles without unused variable warning.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/main.cpp <span style="color: \
grey">(e1609973a973b60728462e0303a51be7376c8f73)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107468/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 