[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Move circulateDesktopApplications into DBusInterface
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-11-22 9:16:01
Message-ID: 20121122091601.4561.80881 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 21, 2012, 5:49 p.m., Thomas Lübking wrote:
> > kwin/dbusinterface.cpp, line 24
> > <http://git.reviewboard.kde.org/r/107406/diff/1/?file=95639#file95639line24>
> >
> > comment that this can be removed with dropping the function?
sidemark: "does not work"
kwin respects a rule to set anything as desktop, but kstart does not alter the type \
at all... i'll guess i'll look into the kstart code tonight ;-)
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107406/#review22334
-----------------------------------------------------------
On Nov. 21, 2012, 2:15 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107406/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2012, 2:15 p.m.)
>
>
> Review request for kwin.
>
>
> Description
> -------
>
> Move circulateDesktopApplications into DBusInterface
>
> It is not used anywhere inside KWin at all and the DBus method is not
> used anywhere inside KDE's repositories (according to lxr). Because of
> that marked as deprecated and going to die with Qt 5.
>
>
> Diffs
> -----
>
> kwin/dbusinterface.h e49d4e0ab2c946c9baffe5d72c0afab4530f60ff
> kwin/dbusinterface.cpp 180f6cf670285e4485422652771a86399c59b9f7
> kwin/layers.cpp 706cb4bf41f8fc55aff980e86345b723777527ea
> kwin/workspace.h db7b1552089507dca18fbd43b37bd172fc642127
>
> Diff: http://git.reviewboard.kde.org/r/107406/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107406/">http://git.reviewboard.kde.org/r/107406/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 21st, 2012, 5:49 p.m., <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/107406/diff/1/?file=95639#file95639line24" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/dbusinterface.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">You \
should have received a copy of the GNU General Public License</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">24</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#include "client.h"</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">comment that this can be \
removed with dropping the function?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">sidemark: \
"does not work" kwin respects a rule to set anything as desktop, but kstart \
does not alter the type at all... i'll guess i'll look into the kstart code \
tonight ;-) </pre>
<br />
<p>- Thomas</p>
<br />
<p>On November 21st, 2012, 2:15 p.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Nov. 21, 2012, 2:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Move circulateDesktopApplications into DBusInterface
It is not used anywhere inside KWin at all and the DBus method is not
used anywhere inside KDE's repositories (according to lxr). Because of
that marked as deprecated and going to die with Qt 5.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/dbusinterface.h <span style="color: \
grey">(e49d4e0ab2c946c9baffe5d72c0afab4530f60ff)</span></li>
<li>kwin/dbusinterface.cpp <span style="color: \
grey">(180f6cf670285e4485422652771a86399c59b9f7)</span></li>
<li>kwin/layers.cpp <span style="color: \
grey">(706cb4bf41f8fc55aff980e86345b723777527ea)</span></li>
<li>kwin/workspace.h <span style="color: \
grey">(db7b1552089507dca18fbd43b37bd172fc642127)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107406/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic